feat(react): Update stable types for v17 #48971

eps1lon · 2020-10-20T22:58:53Z

~~Not including updates for experimental release channel. Goal is to have a minimal update that can be shipped as soon as possible.~~ Experimental release channel handled in #49152

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
Follow the advice from the readme.
Avoid common mistakes.
Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes:
- https://github.com/facebook/react/releases/tag/v17.0.0
- https://html.spec.whatwg.org/multipage/interaction.html#attr-enterkeyhint
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
Include tests for your changes
~~[ ]~~ If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

typescript-bot · 2020-10-20T23:52:57Z

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

4 packages in this PR

react-dom on npm, on unpkg
react-is on npm, on unpkg (author is owner)
react-test-renderer on npm, on unpkg
react on npm, on unpkg (author is owner)
- owner-approval: @ferdaber

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48971,
  "author": "eps1lon",
  "headCommitAbbrOid": "ff3e81e",
  "headCommitOid": "ff3e81ee5146465089131975734ff31c863f4bd8",
  "stalenessInDays": 0,
  "lastPushDate": "2020-11-20T14:36:41.000Z",
  "reopenedDate": "2020-10-20T23:51:51.000Z",
  "lastCommentDate": "2020-11-20T11:38:38.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/v16/node-stream/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/v16/server/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/v16/test-utils/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/v16/test/react-dom-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-dom/v16/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        },
        {
          "path": "types/react-dom/v16/tslint.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        }
      ],
      "owners": [
        "MartynasZilinskas",
        "theruther4d",
        "Jessidhia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-is",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-is/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/v16/react-is-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-is/v16/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        },
        {
          "path": "types/react-is/v16/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AviVahl",
        "christianchown",
        "eps1lon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-test-renderer",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-test-renderer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-test-renderer/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-test-renderer/v16/react-test-renderer-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/react-test-renderer/v16/shallow/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-test-renderer/v16/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        },
        {
          "path": "types/react-test-renderer/v16/tslint.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        }
      ],
      "owners": [
        "arvitaly",
        "lochbrunner",
        "johnnyreilly",
        "jgoz",
        "Jessidhia",
        "maddhruv"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/OTHER_FILES.txt",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react/v16/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        },
        {
          "path": "types/react/v16/tslint.json",
          "kind": "package-meta",
          "suspect": "not the required form"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "digiguru",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ferdaber",
      "date": "2020-11-20T16:49:12.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "Andarist",
      "date": "2020-11-20T11:24:15.000Z",
      "abbrOid": "87585b4"
    },
    {
      "type": "stale",
      "reviewer": "n1ru4l",
      "date": "2020-11-20T10:08:12.000Z",
      "abbrOid": "df6978a"
    },
    {
      "type": "stale",
      "reviewer": "maraisr",
      "date": "2020-10-24T04:47:45.000Z",
      "abbrOid": "3d3fb93"
    }
  ],
  "ciResult": "pass"
}

typescript-bot · 2020-10-20T23:52:58Z

🔔 @MartynasZilinskas @theruther4d @Jessidhia @AviVahl @christianchown @arvitaly @lochbrunner @johnnyreilly @jgoz @maddhruv @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

danger-public · 2020-10-20T23:58:38Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-dom (`unpkg`)

was missing the following properties:

flushSync
unstable_createPortal
flushSync
unstable_createPortal

react-is (`unpkg`)

was missing the following properties:

isConcurrentMode
isConcurrentMode
isConcurrentMode

react-test-renderer (`unpkg`)

was missing the following properties:

unstable_batchedUpdates
unstable_concurrentAct

Generated by 🚫 dangerJS against ff3e81e

eps1lon · 2020-10-21T15:41:31Z

Looks like there's just too much to benchmark.

types/react/experimental.d.ts

dispix · 2020-10-27T12:22:20Z

I think this PR should take the time to fix a long running issue with the FC type: #40993

Having an optional children by default doesn't make sense but since it's a breaking change, we could remove it in this PR while respecting semver.

eps1lon · 2020-10-27T13:53:41Z

I think this PR should take the time to fix a long running issue with the FC type: #40993

Having an optional children by default doesn't make sense but since it's a breaking change, removing it in this PR would make sense.

We've discussed this in #46691 and decided to postpone any type related breaking change to v18 because React core members specifically asked us not to. If you disagree please continue the discussion in the issue.

dispix · 2020-10-27T13:57:24Z

I think this PR should take the time to fix a long running issue with the FC type: #40993
Having an optional children by default doesn't make sense but since it's a breaking change, removing it in this PR would make sense.

We've discussed this in #46691 and decided to postpone any type related breaking change to v18 because React core members specifically asked us not to. If you disagree please continue the discussion in the issue.

Oh, I missed that one but that makes sense. Thanks for the info 👍

typescript-bot · 2020-10-27T14:24:38Z

@maraisr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

alecmev · 2020-10-27T14:53:56Z

disableRemotePlayback might be a safe addition?

eps1lon · 2020-10-27T15:48:14Z

disableRemotePlayback might be a safe addition?

@alecmev disableRemotePlayback is included in this PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48971/files#diff-32cfd8cb197872bcba371f5018185d2e75fa540b52cda2dd7d8ac12dcc021299R2360

typescript-bot · 2020-10-29T23:42:09Z

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

react-dom/v*

Comparison details for react-dom/* 📊

	master	#48971	diff
Batch compilation
Memory usage (MiB)	127.0	127.1	0.0%
Type count	27065	27073	0%
Assignability cache size	6578	6578	0%

Language service
Samples taken	422	422	0%
Identifiers in tests	422	422	0%
`getCompletionsAtPosition`
Mean duration (ms)	666.7	670.0	+0.5%
Mean CV	8.0%	8.4%
Worst duration (ms)	897.7	832.3	-7.3%
Worst identifier	rootElement	rootElement
`getQuickInfoAtPosition`
Mean duration (ms)	663.0	667.0	+0.6%
Mean CV	8.5%	8.5%	-0.5%
Worst duration (ms)	885.9	896.5	+1.2%
Worst identifier	createElement	createElement

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

react-dom/v*

Comparison details for react-dom/* 📊

	master	#48971	diff
Batch compilation
Memory usage (MiB)	125.8	126.9	+0.9%
Type count	27065	27073	0%
Assignability cache size	6578	6578	0%

Language service
Samples taken	422	422	0%
Identifiers in tests	422	422	0%
`getCompletionsAtPosition`
Mean duration (ms)	662.9	661.9	-0.2%
Mean CV	8.2%	8.3%
Worst duration (ms)	904.0	891.7	-1.4%
Worst identifier	div	div
`getQuickInfoAtPosition`
Mean duration (ms)	660.1	661.2	+0.2%
Mean CV	8.4%	8.7%	+3.7%
Worst duration (ms)	904.7	977.7	+8.1%
Worst identifier	renderIntoDocument	renderIntoDocument

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

eps1lon · 2020-11-20T10:57:28Z

Just dismiss it instead of blaming me then - Also, I suggested changes not forced you to apply them...

We have to be a bit more considerate with the feedback we give in an automated repository.

Andarist · 2020-11-20T11:03:55Z

We have to be a bit more considerate with the feedback we give in an automated repository.

I must say that I agree with @n1ru4l on this one. His intentions were good and coming from the care about the users and various use cases, and bashing him like this is not helpful. He could also not be fully aware of all the implications of his actions on the automated process. It should be enough to just comment back on it explaining the problem without dragging this through several comments that are not helpful to anyone.

n1ru4l · 2020-11-20T11:09:03Z

Having only contributed sparingly to definitely typed I am honestly not totally aware of this process. Anyway, I don't see an issue as the bot clearly mentions you can just dismiss it?

Honestly, I think this behavior of blaming is pretty toxic and will scare people away from making meaningful contributions...

eps1lon · 2020-11-20T11:11:21Z

His intentions were good

I never assume something else. What matters is the impact.

He could also not be fully aware of all the implications of his actions on the automated process.

Now he is. We'll see if this changes his actions.

bashing him like this is not helpful

If that was bashing then how is bashing me helpful?

Anyway, I don't see an issue as the bot clearly mentions you can just dismiss it?

Collaborators can which I'm not.

Honestly, I think this behaviour of blaming is pretty toxic and will scare people away from making meaningful contributions...

Considering you had no problem coming in and requesting changes I don't see how you're easily scared. Just open an issue, explain your problem and we go from there. But demanding a certain implementation is certainly the more toxic behavior.

Andarist · 2020-11-20T11:17:14Z

If that was bashing then how is bashing me helpful?

I was trying to stand up for a fellow OSS contributor - because I think he had more right here and I didn't want to stay silent about this. Just trying to bring my 2 cents here so you could maybe see an alternative perspective and reconsider if how you have handled this was appropriate or not.

If you have considered the words used by me as bashing to you, please take my sincere apologies. I'm not a native speaker so choosing the appropriate, polite, wording is not my strongest suit. My intention was not to bash you but to stand up for @n1ru4l .

typescript-bot · 2020-11-20T11:32:22Z

@Andarist, @n1ru4l, @maraisr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

eps1lon · 2020-11-20T11:38:38Z

I definitely assumed knowledge about the contribution workflow. It seemed patronizing to explain what "request changes" means in GitHub. I'll explain this the next time so that we're on the same level. Sorry about that @n1ru4l. I hope this doesn't stop you from opening issues or commenting on PRs in the future. In my particular github "cultural-bubble" it's generally considered rude to approve/reject PRs targeting code that you do not maintain. So if we accuse each other of toxicity we should consider these different backgrounds.

ferdaber

This looks good. We would need to merge in the latest changes in master to get jsx runtime running for the older versions so hopefully no big merge conflicts 🤞

typescript-bot · 2020-11-20T14:00:22Z

@eps1lon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

typescript-bot · 2020-11-20T15:08:11Z

@ferdaber, @Andarist, @n1ru4l, @maraisr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2020-11-20T22:02:04Z

I just published @types/react@17.0.0 to npm.

typescript-bot · 2020-11-20T22:02:14Z

I just published @types/react@16.14.1 to npm.

typescript-bot · 2020-11-20T22:02:37Z

I just published @types/react-dom@17.0.0 to npm.

typescript-bot · 2020-11-20T22:02:46Z

I just published @types/react-dom@16.9.10 to npm.

typescript-bot · 2020-11-20T22:03:05Z

I just published @types/react-is@17.0.0 to npm.

typescript-bot · 2020-11-20T22:03:12Z

I just published @types/react-is@16.7.2 to npm.

typescript-bot · 2020-11-20T22:03:32Z

I just published @types/react-test-renderer@17.0.0 to npm.

typescript-bot · 2020-11-20T22:03:41Z

I just published @types/react-test-renderer@16.9.4 to npm.

* feat(react): Update stable types for v17 * Fix new lint rules * Add v16 types * fix malformed json * fix baseUrl * Add globals to v16 * Remove experimental tests * add v16 shallow renderer * Add MVP for new jsx runtime * Just expose the namespace

eps1lon added 4 commits October 21, 2020 00:42

feat(react): Update stable types for v17

4e7a4bc

Fix new lint rules

4ca4dd8

Add v16 types

7d551f2

fix malformed json

c458161

eps1lon mentioned this pull request Oct 20, 2020

chore(react): Add v17 infra #46690

Closed

1 task

eps1lon added 4 commits October 21, 2020 01:04

fix baseUrl

bd76665

Add globals to v16

f3ae5a4

Remove experimental tests

25148a7

add v16 shallow renderer

3d3fb93

eps1lon marked this pull request as ready for review October 20, 2020 23:51

eps1lon requested review from Jessidhia and johnnyreilly as code owners October 20, 2020 23:51

typescript-bot added Critical package Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. labels Oct 20, 2020

eps1lon mentioned this pull request Oct 21, 2020

[@types/react] add enterkeyhint attribute to input and textarea #43985

Closed

4 tasks

maraisr reviewed Oct 24, 2020

View reviewed changes

types/react/experimental.d.ts Show resolved Hide resolved

Merge branch 'master' into feat/react-17

df6978a

eps1lon mentioned this pull request Oct 29, 2020

[core] Support React 17 mui/material-ui#23311

Merged

3 tasks

Just expose the namespace

87585b4

eps1lon mentioned this pull request Nov 20, 2020

feat(react): Support react-jsx and react-jsxdev #49701

Merged

9 tasks

ferdaber approved these changes Nov 20, 2020

View reviewed changes

typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 20, 2020

Merge branch 'master' into feat/react-17

ff3e81e

typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 20, 2020

collinbarrett mentioned this pull request Nov 20, 2020

build(deps): bump typescript from 4.0.5 to 4.1.2 in /web collinbarrett/FilterLists#2112

Merged

ferdaber approved these changes Nov 20, 2020

View reviewed changes

johnnyreilly merged commit 09d10b6 into DefinitelyTyped:master Nov 20, 2020

eps1lon deleted the feat/react-17 branch November 20, 2020 21:36

eps1lon mentioned this pull request Nov 21, 2020

fix(react): Add explicit dependency on csstype for v16 #49717

Merged

6 tasks

autarc mentioned this pull request Feb 23, 2023

[@types/react] Refer to string for the download attribute #64460

Closed

4 tasks

feat(react): Update stable types for v17 #48971

feat(react): Update stable types for v17 #48971

Uh oh!

Conversation

eps1lon commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Oct 20, 2020

Uh oh!

danger-public commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

react-dom (unpkg)

react-is (unpkg)

react-test-renderer (unpkg)

Uh oh!

eps1lon commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dispix commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Oct 27, 2020

Uh oh!

dispix commented Oct 27, 2020

Uh oh!

typescript-bot commented Oct 27, 2020

Uh oh!

alecmev commented Oct 27, 2020

Uh oh!

eps1lon commented Oct 27, 2020

Uh oh!

typescript-bot commented Oct 29, 2020

react-dom/v*

react-dom/v*

Uh oh!

eps1lon commented Nov 20, 2020

Uh oh!

Andarist commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n1ru4l commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Nov 20, 2020

Uh oh!

Andarist commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

eps1lon commented Nov 20, 2020

Uh oh!

ferdaber left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

Uh oh!

typescript-bot commented Nov 20, 2020

eps1lon commented Oct 20, 2020 •

edited

Loading

typescript-bot commented Oct 20, 2020 •

edited

Loading

danger-public commented Oct 20, 2020 •

edited

Loading

react-dom (`unpkg`)

react-is (`unpkg`)

react-test-renderer (`unpkg`)

eps1lon commented Oct 21, 2020 •

edited

Loading

dispix commented Oct 27, 2020 •

edited

Loading

Andarist commented Nov 20, 2020 •

edited

Loading

n1ru4l commented Nov 20, 2020 •

edited

Loading