update(terser-webpack-plugin): minimizerOptions option#47518
Conversation
- `minimizerOptions` added - test amended - cleanup webpack/terser-webpack-plugin#311 Thanks!
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47518,
"author": "peterblazejewicz",
"owners": [
"Danscho",
"peterblazejewicz"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "f84ac1c",
"headCommitOid": "f84ac1c637fe8578c5ea55c6b4bcdcc1658c5b91",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-09-11T21:01:50.000Z",
"lastCommentDate": "2020-09-15T07:06:07.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47518/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"newPackages": [],
"packages": [
"terser-webpack-plugin"
],
"files": [
{
"path": "types/terser-webpack-plugin/index.d.ts",
"kind": "definition",
"package": "terser-webpack-plugin"
},
{
"path": "types/terser-webpack-plugin/terser-webpack-plugin-tests.ts",
"kind": "test",
"package": "terser-webpack-plugin"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-09-15T07:04:44.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @Danscho — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. terser-webpack-plugin (unpkg)was missing the following properties:
as well as these 2 other properties...emitAsset, updateAsset |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Danscho: you can do this too.) |
|
Ready to merge |
…mizerOptions` option by @peterblazejewicz - `minimizerOptions` added - test amended - cleanup webpack/terser-webpack-plugin#311 Thanks!
minimizerOptionsaddedwebpack/terser-webpack-plugin#311
Thanks!
npm test.)npm run lint package-name(ortscif notslint.jsonis present).tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.