test(es‑abstract/GetIntrinsic): Use expectType function
#47049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ExE-Boss Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47049,
"author": "ExE-Boss",
"owners": [
"ljharb",
"ExE-Boss"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "cbd2e60",
"headCommitOid": "cbd2e60c69263f5ff2052d632d409bcb4d820f27",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-08-26T11:11:21.000Z",
"lastCommentDate": "2020-08-26T20:04:10.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47049/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"newPackages": [],
"packages": [
"es-abstract"
],
"files": [
{
"path": "types/es-abstract/test/GetIntrinsic.test.ts",
"kind": "test",
"package": "es-abstract"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-08-26T18:27:09.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
Contributor
|
🔔 @ljharb — please review this PR in the next few days. Be sure to explicitly select |
ljharb
approved these changes
Aug 26, 2020
Contributor
Contributor
Author
|
Ready to merge |
chivesrs
pushed a commit
to chivesrs/DefinitelyTyped
that referenced
this pull request
Sep 2, 2020
…`expectType` function by @ExE-Boss
danielrearden
pushed a commit
to danielrearden/DefinitelyTyped
that referenced
this pull request
Sep 22, 2020
…`expectType` function by @ExE-Boss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
GetIntrinsic.test.tsto use theexpectTypefunction where the expected type could change in the future (e.g.: microsoft/TypeScript#40231).Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.review?(@rbuckton)