@reubenrybnik Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 46585,
  "author": "reubenrybnik",
  "owners": [
    "borisyankov",
    "jbaldwin",
    "ccurrens",
    "confususs",
    "jgonggrijp",
    "ffflorian",
    "regevbr",
    "peterblazejewicz",
    "reubenrybnik"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "ea2b166",
  "headCommitOid": "ea2b166aa9b2bf8b82f2ed6983de7a703690df77",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-08-06T05:16:25.000Z",
  "lastCommentDate": "2020-08-06T21:34:08.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46585/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "underscore"
  ],
  "files": [
    {
      "path": "types/underscore/index.d.ts",
      "kind": "definition",
      "package": "underscore"
    },
    {
      "path": "types/underscore/underscore-tests.ts",
      "kind": "test",
      "package": "underscore"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-08-06T19:56:16.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

🔔 @borisyankov @jbaldwin @ccurrens @confususs @jgonggrijp @ffflorian @regevbr @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Thanks as always for the fast turnaround @jgonggrijp! Hope you're having or had a good time on your trip 😄

Ready to merge

I just published @types/underscore@1.10.19 to npm.

@reubenrybnik trip?

Sorry @jgonggrijp, I had assumed that when you left #46422 (comment) you were indicating that you were on a vacation or business trip that involved visiting Paris, which is why I had offered to slow down the pace of the PRs for a bit, but that may not have been a correct assumption.

Also I suppose it may have been inappropriate to comment further on it even if that was what was happening.

Oh, haha! No, I was not going on a trip but commenting on a typo in your commit message (pairs -> paris). I did that in a commit comment, but confusingly, it also appeared as a standalone comment in the PR, so I understand your reasoning.

Regardless, if I make a public comment that seems to suggest I'm going to make a trip, then of course you are free to comment on that in public as well. In my opinion, it would be a bit hypocritical of me to object to that.

Oh, lol, good catch! I see now the notation that that comment was on a commit, so I'll know to watch out for that in the future 😄