[@types/underscore] Collection and Array Tests - Union, Intersection, and Difference#46419
Conversation
|
@reubenrybnik Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46419,
"author": "reubenrybnik",
"owners": [
"borisyankov",
"jbaldwin",
"ccurrens",
"confususs",
"jgonggrijp",
"ffflorian",
"regevbr",
"peterblazejewicz",
"reubenrybnik"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "543cdae",
"headCommitOid": "543cdae2dd46399cdc70943038fd6fbd88cce111",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-07-29T16:56:27.000Z",
"lastCommentDate": "2020-07-29T19:44:09.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46419/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"underscore"
],
"files": [
{
"path": "types/underscore/index.d.ts",
"kind": "definition",
"package": "underscore"
},
{
"path": "types/underscore/underscore-tests.ts",
"kind": "test",
"package": "underscore"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-07-29T19:40:25.000Z",
"reviewersWithStaleReviews": [
{
"reviewedAbbrOid": "c1c07a1",
"reviewer": "w3bdesign",
"date": "2020-07-29T00:31:04Z"
}
],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @borisyankov @jbaldwin @ccurrens @confususs @jgonggrijp @ffflorian @regevbr @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
jgonggrijp
left a comment
There was a problem hiding this comment.
I'm fine with this as-is, though I made two minor comments that you may want to follow up on.
|
@w3bdesign Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@reubenrybnik Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@borisyankov, @jbaldwin, @ccurrens, @confususs, @jgonggrijp, @ffflorian, @regevbr, @peterblazejewicz: you can do this too.) |
|
Ready to merge |
|
I just published |
…rray Tests - Union, Intersection, and Difference by @reubenrybnik * Updating type definitions for union, intersection, and difference and adding tests. * Also testing mixes of arrays and lists. * Taking a stab at the documentation updates requested by @jgonggrijp.
…rray Tests - Union, Intersection, and Difference by @reubenrybnik * Updating type definitions for union, intersection, and difference and adding tests. * Also testing mixes of arrays and lists. * Taking a stab at the documentation updates requested by @jgonggrijp.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).This PR continues the planned set that will together add up to #45201 and includes the following changes:
union,intersection, anddifference._Chainversions of these functions to use the correct wrapped value typeVto partially fix @types/underscore error TS2322 for_.chainafter upgrade to v1.9 #36308.difference.