[@types/underscore] Collection and Array Tests - Every, Some, and Contains#46185
Conversation
|
@reubenrybnik Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46185,
"author": "reubenrybnik",
"owners": [
"borisyankov",
"jbaldwin",
"ccurrens",
"confususs",
"jgonggrijp",
"ffflorian",
"regevbr",
"peterblazejewicz",
"reubenrybnik"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "f75bf29",
"headCommitOid": "f75bf29eb2f3afa45f13a4de1eadf4a08106bac6",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-07-21T00:10:45.000Z",
"lastCommentDate": "2020-07-21T02:15:21.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46185/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"underscore"
],
"files": [
{
"path": "types/underscore/index.d.ts",
"kind": "definition",
"package": "underscore"
},
{
"path": "types/underscore/underscore-tests.ts",
"kind": "test",
"package": "underscore"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-07-21T00:54:06.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @borisyankov @jbaldwin @ccurrens @confususs @jgonggrijp @ffflorian @regevbr @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
jgonggrijp
left a comment
There was a problem hiding this comment.
The value parameter of contains is interesting.
|
@reubenrybnik One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can "dismiss" the review using GitHub's review UI. Thank you! |
|
@jgonggrijp Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
jgonggrijp
left a comment
There was a problem hiding this comment.
That's all, I suppose!
|
Don't worry @jgonggrijp, there's still a little more excitement coming in future PRs, just thought it would be nice to take a break and do a bit of the easier stuff in the middle here 😄 |
|
Ready to merge |
|
I just published |
…rray Tests - Every, Some, and Contains by @reubenrybnik * Updating type definitions for every, some, and contains and adding tests. * Adding a multi-call chain test that includes contains. * Taking any value in contains. * Fixing differentiation comments for contains.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).This PR continues the planned set that will together add up to #45201 and includes the following changes:
every,some, andcontains.UnderscoreStatic.everyandUnderscoreStatic.someby updating them to useCollectionIterator.Underscoreand_Chainversions ofeveryandsometo work with both Lists and Dictionaries to partially fix Underscore collections functions should take objects #20623.alloverloads with a reference toeveryoverloads, allanyoverloads with a reference tosomeoverloads, and allincludeandincludesoverloads with a reference tocontainsoverloads.