Skip to content

[@types/underscore] Collection and Array Tests - First, Initial, Last, and Rest#46184

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
reubenrybnik:underscore-tests-first-initial-last-rest
Jul 20, 2020
Merged

[@types/underscore] Collection and Array Tests - First, Initial, Last, and Rest#46184
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
reubenrybnik:underscore-tests-first-initial-last-rest

Conversation

@reubenrybnik
Copy link
Copy Markdown
Contributor

@reubenrybnik reubenrybnik commented Jul 19, 2020 •
edited
Loading

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://underscorejs.org/
  • Include tests for your changes

This PR continues the planned set that will together add up to #45201 and includes the following changes:

  • Adds tests for first, initial, last, and rest.
  • Updates the return type of _Chain overloads of these functions that return a wrapped array to use the correct wrapped value type V to partially fix @types/underscore error TS2322 for _.chain after upgrade to v1.9 #36308.
  • Replaces all head and take overloads with a reference to first overloads and all tail and drop overlaods with a reference to rest overloads.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels Jul 19, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 19, 2020 •
edited
Loading

@reubenrybnik Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 46184,
  "author": "reubenrybnik",
  "owners": [
    "borisyankov",
    "jbaldwin",
    "ccurrens",
    "confususs",
    "jgonggrijp",
    "ffflorian",
    "regevbr",
    "peterblazejewicz",
    "reubenrybnik"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "db3d6b8",
  "headCommitOid": "db3d6b8baa14b088c228953561ca5a745b4433a2",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-19T23:02:25.000Z",
  "lastCommentDate": "2020-07-20T01:15:59.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46184/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "underscore"
  ],
  "files": [
    {
      "path": "types/underscore/index.d.ts",
      "kind": "definition",
      "package": "underscore"
    },
    {
      "path": "types/underscore/underscore-tests.ts",
      "kind": "test",
      "package": "underscore"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-19T23:38:24.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 19, 2020

🔔 @borisyankov @jbaldwin @ccurrens @confususs @jgonggrijp @ffflorian @regevbr @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

jgonggrijp
jgonggrijp approved these changes Jul 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breeze!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 19, 2020
@reubenrybnik
Copy link
Copy Markdown
Contributor Author

reubenrybnik commented Jul 20, 2020

From my company's solution, this fixes an error for a usage of the first overload that takes a number since that now yields the correct wrapped type V and doesn't introduce any new errors.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 20, 2020

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #46184 diff
Batch compilation
Memory usage (MiB) 59.0 60.3 +2.1%
Type count 11111 11092 0%
Assignability cache size 1359 1351 -1%
Language service
Samples taken 5457 5657 +4%
Identifiers in tests 5457 5657 +4%
getCompletionsAtPosition
    Mean duration (ms) 175.6 179.0 +1.9%
    Mean CV 9.3% 9.2%
    Worst duration (ms) 311.1 347.9 +11.8%
    Worst identifier _ _
getQuickInfoAtPosition
    Mean duration (ms) 170.6 174.7 +2.4%
    Mean CV 9.6% 9.4% -1.8%
    Worst duration (ms) 359.7 377.9 +5.1%
    Worst identifier extractUnderscoreTypes _

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 20, 2020
@reubenrybnik
Copy link
Copy Markdown
Contributor Author

reubenrybnik commented Jul 20, 2020

Ready to merge

@typescript-bot typescript-bot merged commit 8c9eba5 into DefinitelyTyped:master Jul 20, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 20, 2020

I just published @types/underscore@1.10.11 to npm.

@reubenrybnik reubenrybnik mentioned this pull request Aug 6, 2020
Closed
10 tasks
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
@reubenrybnik @danielrearden
🤖 Merge PR DefinitelyTyped#46184 [@types/underscore] Collection and A…
fcb976a 
…rray Tests - First, Initial, Last, and Rest by @reubenrybnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisyankov borisyankov Awaiting requested review from borisyankov borisyankov is a code owner

1 more reviewer

@jgonggrijp jgonggrijp jgonggrijp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@types/underscore error TS2322 for _.chain after upgrade to v1.9

3 participants

@reubenrybnik @typescript-bot @jgonggrijp