Merged
Conversation
This reverts commit cbce1f5.
Contributor
|
@sandersn Thank you for submitting this PR! Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45076,
"author": "sandersn",
"owners": [],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "7fd2367",
"headCommitOid": "7fd236736e7452cb201de5e4ad897879ff6fbdc2",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-06-03T00:57:47.000Z",
"lastCommentDate": "2020-05-27T23:06:07.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45076/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": true,
"packages": [
"w3c-css-typed-object-model-level-1"
],
"files": [
{
"filePath": "types/w3c-css-typed-object-model-level-1/index.d.ts",
"kind": "definition",
"package": "w3c-css-typed-object-model-level-1"
},
{
"filePath": "types/w3c-css-typed-object-model-level-1/tsconfig.json",
"kind": "package-meta",
"package": "w3c-css-typed-object-model-level-1"
},
{
"filePath": "types/w3c-css-typed-object-model-level-1/tslint.json",
"kind": "package-meta",
"package": "w3c-css-typed-object-model-level-1"
},
{
"filePath": "types/w3c-css-typed-object-model-level-1/w3c-css-typed-object-model-level-1-tests.ts",
"kind": "test",
"package": "w3c-css-typed-object-model-level-1"
}
],
"hasDismissedReview": false,
"ciResult": "unknown",
"lastReviewDate": "2020-06-03T00:57:50.000Z",
"reviewersWithStaleReviews": [
{
"reviewedAbbrOid": "e73eea2",
"reviewer": "peterblazejewicz",
"date": "2020-05-27T23:06:08Z"
}
],
"approvalFlags": 4,
"isChangesRequested": false
} |
Contributor
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to w3c-css-typed-object-model-level-1 with its source on master. Comparison details 📊
|
peterblazejewicz
approved these changes
May 27, 2020
Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>
rbuckton
approved these changes
Jun 3, 2020
sandersn
added a commit
that referenced
this pull request
Jun 3, 2020
This was referenced Jun 3, 2020
Closed
jjballano-qatium
pushed a commit
to jjballano-qatium/DefinitelyTyped
that referenced
this pull request
Jun 16, 2020
* Revert "Remove CSSOM types" This reverts commit cbce1f5. * convert to namespace * Update types/w3c-css-typed-object-model-level-1/index.d.ts Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> Co-authored-by: Ron Buckton <ron.buckton@microsoft.com> Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>
jjballano-qatium
pushed a commit
to jjballano-qatium/DefinitelyTyped
that referenced
this pull request
Jun 16, 2020
ngbrown
pushed a commit
to ngbrown-forks/DefinitelyTyped
that referenced
this pull request
Jul 11, 2020
* Revert "Remove CSSOM types" This reverts commit cbce1f5. * convert to namespace * Update types/w3c-css-typed-object-model-level-1/index.d.ts Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> Co-authored-by: Ron Buckton <ron.buckton@microsoft.com> Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>
ngbrown
pushed a commit
to ngbrown-forks/DefinitelyTyped
that referenced
this pull request
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types now only work in 3.9 and above -- in 3.8 and before, the existing types are fine and don't need to be changed; for 3.9 and above,
CSSis now a namespace, so this package'sCSSneeds to be a namespace too.These types are so little used that I don't want to spend the effort to maintain pre-3.9 versions as well, although it would be possible to maintain them in a
v3.8directory if needed.