fix(mongodb): missing 'abort' method on GridFSBucketWriteStream#44391
fix(mongodb): missing 'abort' method on GridFSBucketWriteStream#44391typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
- add missing method from write stream - tests amended https://mongodb.github.io/node-mongodb-native/3.6/api/GridFSBucketWriteStream.html#abort /cc @alexy4744 Thanks! fixes DefinitelyTyped#44360
|
@peterblazejewicz Thank you for submitting this PR! Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44391,
"author": "peterblazejewicz",
"owners": [
"CaselIT",
"alanmarcell",
"dante-101",
"mcortesi",
"EnricoPicci",
"AJCStriker",
"julien-c",
"daprahamian",
"denys-bushulyak",
"BastienAr",
"sindbach",
"geraldinelemeur",
"various89",
"angela-1",
"lirbank",
"hector7",
"floric",
"erikc5000",
"Manc",
"jloveridge",
"ranguna",
"HosseinAgha",
"albertossilva",
"peterblazejewicz",
"LinusU",
"taxilian",
"xamgore",
"avaly"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "20d3dc1",
"headCommitOid": "20d3dc1405eddcea622a35b0e6bc0bb7c880f4e8",
"mergeIsRequested": true,
"stalenessInDays": 3,
"lastCommitDate": "2020-04-30T20:38:27.000Z",
"lastAuthorCommentDate": "2020-05-04T20:21:56.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44391/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"mongodb"
],
"files": [
{
"filePath": "types/mongodb/index.d.ts",
"kind": "definition",
"package": "mongodb"
},
{
"filePath": "types/mongodb/test/index.ts",
"kind": "test",
"package": "mongodb"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-01T08:17:19.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
🔔 @CaselIT @alanmarcell @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian @Denys-Bushulyak @bastienar @sindbach @geraldinelemeur @various89 @angela-1 @lirbank @hector7 @floric @erikc5000 @Manc @jloveridge @Ranguna @HosseinAgha @albertossilva @peterblazejewicz @LinusU @taxilian @xamgore @avaly - please review this PR in the next few days. Be sure to explicitly select |
|
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Let's go wild, shall we? |
|
Ready to merge |
|
I just published |
… on GridFSBucketWriteStream by @peterblazejewicz - add missing method from write stream - tests amended https://mongodb.github.io/node-mongodb-native/3.6/api/GridFSBucketWriteStream.html#abort /cc @alexy4744 Thanks! fixes DefinitelyTyped#44360
https://mongodb.github.io/node-mongodb-native/3.6/api/GridFSBucketWriteStream.html#abort
/cc @alexy4744
Thanks!
fixes #44360
npm test.)npm run lint package-name(ortscif notslint.jsonis present).