Skip to content

[picomatch] Add basic types.#44221

Merged
elibarzilay merged 3 commits intoDefinitelyTyped:masterfrom
p-kuen:master
Apr 27, 2020
Merged

[picomatch] Add basic types.#44221
elibarzilay merged 3 commits intoDefinitelyTyped:masterfrom
p-kuen:master

Conversation

@p-kuen
Copy link
Contributor

@p-kuen p-kuen commented Apr 25, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to picomatch with its source on master.

Comparison details 📊
Batch compilation
Type count 2232
Assignability cache size 127
Language service measurements
Samples taken 3
Identifiers in tests 3
getCompletionsAtPosition
    Mean duration (ms) 84.6
    Mean CV 29.0%
    Worst duration (ms) 98.6
    Worst identifier pm
getQuickInfoAtPosition
    Mean duration (ms) 90.1
    Mean CV 24.4%
    Worst duration (ms) 102.3
    Worst identifier pm
System information
Node version v12.16.1
CPU count 2
CPU speed 2.095 GHz
CPU model Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1077-azure

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 25, 2020

@Patcher56 Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@elibarzilay elibarzilay merged commit a29e36d into DefinitelyTyped:master Apr 27, 2020
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
* [picomatch] Add basic types.

* [picomatch] Fix some lint issues.

* Update github link for definition author.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants