Skip to content

[@types/node] Remove readonly from http.ClientRequest#41030

Closed
TooTallNate wants to merge 4 commits intoDefinitelyTyped:masterfrom
TooTallNate:update/node-req-path-not-readonly
Closed

[@types/node] Remove readonly from http.ClientRequest#41030
TooTallNate wants to merge 4 commits intoDefinitelyTyped:masterfrom
TooTallNate:update/node-req-path-not-readonly

Conversation

@TooTallNate
Copy link
Contributor

@TooTallNate TooTallNate commented Dec 13, 2019

There is nothing in the source code that prevents this property from being overwritten, and user code and/or modules may change this property before flushing the HTTP header.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@TooTallNate
[@types/node] Remove readonly from http.ClientRequest
52dbe22 
There is nothing in the source code that prevents this property
from being overwritten, and user code and/or modules may change
this property before flushing the HTTP header.
@TooTallNate
Add test
6788f94
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Dec 14, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 14, 2019 •
edited
Loading

@TooTallNate Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @tellnes @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @octo-sniffle @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @jeremiergz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 14, 2019

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

node/v12

Comparison details for node/v12 📊
master #41030 diff
Batch compilation
Memory usage (MiB) 123.3 122.9 -0.3%
Type count 21730 21730 0%
Assignability cache size 39469 39469 0%
Language service
Samples taken 1871 1871 0%
Identifiers in tests 11770 11772 0%
getCompletionsAtPosition
    Mean duration (ms) 641.6 652.3 +1.7%
    Mean CV 7.7% 7.5%
    Worst duration (ms) 869.1 936.3 +7.7%
    Worst identifier bind bind
getQuickInfoAtPosition
    Mean duration (ms) 635.5 646.9 +1.8%
    Mean CV 7.4% 7.6% +1.9%
    Worst duration (ms) 830.5 919.5 +10.7%
    Worst identifier _family bind

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

node/v10

Comparison details for node/v10 📊
master #41030 diff
Batch compilation
Memory usage (MiB) 123.4 122.4 -0.8%
Type count 18109 18109 0%
Assignability cache size 34683 34683 0%
Language service
Samples taken 5728 5683 -1%
Identifiers in tests 10200 10200 0%
getCompletionsAtPosition
    Mean duration (ms) 625.5 631.2 +0.9%
    Mean CV 0.0% 0.0%
    Worst duration (ms) 1242.5 1140.2 -8.2%
    Worst identifier close close
getQuickInfoAtPosition
    Mean duration (ms) 629.5 633.5 +0.6%
    Mean CV 0.0% 0.0%
    Worst duration (ms) 1091.2 1147.2 +5.1%
    Worst identifier inspectorUrl close

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Dec 14, 2019
@galkin galkin mentioned this pull request Dec 14, 2019
Merged
7 tasks
galkin
galkin suggested changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@galkin galkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. typing for node.js v10
  2. right splitting between your open pulls or close one and combine them into one.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Dec 14, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 14, 2019

@TooTallNate One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@TooTallNate
Copy link
Contributor Author

TooTallNate commented Dec 20, 2019

@galkin Closing in favor of #41029.

@TooTallNate TooTallNate deleted the update/node-req-path-not-readonly branch December 20, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@galkin galkin galkin requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate @typescript-bot @galkin