Fix bad types/v* references in tests#40575
Merged
Conversation
gulp-connect *apparently* works with gulp 3 or 4, but the examples on the homepage are written for gulp 3. I updated them minimally to work with gulp 4 -- its types at least. auth0.widget depends on auth0-js which now uses modules. I switched to import types and updated the type names.
Contributor
|
I just published |
Contributor
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? auth0.widget/v*Comparison details for auth0.widget/v* 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. gulp-connect/v5Comparison details for gulp-connect/v5 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes the tests for incorrect
'package/v7-style references, which I missed previously.gulp-connect apparently works with gulp 3 or 4, but the examples on
the homepage are written for gulp 3. I updated them minimally to work
with gulp 4 -- its types at least.
auth0.widget depends on auth0-js which now uses modules. I switched to
import types and updated the type names.