Node: URL: correct format/parse parameter types#40118
Node: URL: correct format/parse parameter types#40118PranavSenthilnathan merged 5 commits intoDefinitelyTyped:masterfrom OliverJAsh:oja/node/url-types
Conversation
|
@OliverJAsh Thank you for submitting this PR! 🔔 @SomaticIT @Raigen @DanielMSchmidt @jabreu610 @mrmlnc @steprescott @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @tellnes @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @octo-sniffle @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@OliverJAsh The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
galkin
left a comment
There was a problem hiding this comment.
@OliverJAsh, thank you for your work.
I highlight author of affected packages. I will approve your pull after feedback from them.
| // Definitions by: mrmlnc <https://github.com/mrmlnc> | ||
| // steprescott <https://github.com/steprescott> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
| // TypeScript Version: 2.1 |
There was a problem hiding this comment.
type of change should be reviewed by owner of http-proxy-agent
| // Daniel Schmidt <https://github.com/DanielMSchmidt> | ||
| // Jordan Abreu <https://github.com/jabreu610> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
| // TypeScript Version: 2.1 |
There was a problem hiding this comment.
⚠this type of change should be reviewed by owner of http-proxy ⚠
@SomaticIT, @Raigen, @DanielMSchmidt, @jabreu610, could you review this pull?
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? http-proxy-agent/v2Comparison details for http-proxy-agent/v2 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. http-proxy/v1Comparison details for http-proxy/v1 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. node/v12Comparison details for node/v12 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Co-Authored-By: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
|
@OliverJAsh, could you make squash for your commits? |
|
@galkin That's not necessary: #40118 (comment) |
|
Thank you i missed the comment above. |
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
|
I just published |
|
I just published |
|
I just published |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.