Skip to content

[@hapi/hapi] separate server/request/response app states#36361

Merged
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
mikejpeters:hapi-app
Jun 24, 2019
Merged

[@hapi/hapi] separate server/request/response app states#36361
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
mikejpeters:hapi-app

Conversation

@mikejpeters
Copy link
Copy Markdown
Contributor

@mikejpeters mikejpeters commented Jun 22, 2019 •
edited
Loading

Fixes #30465

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 22, 2019 •
edited
Loading

@mikejpeters Thank you for submitting this PR!

🔔 @rafaelsouzaf @jhsimms @SimonSchick @saboya @lenovouser - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 22, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36361 diff
Batch compilation
Memory usage 84673816.0 84140416.0 -0.6%
Type count 12461 12464 0.0%
Assignability cache size 3569 3569 0.0%
Subtype cache size 380 380 0.0%
Identity cache size 136 136 0.0%
Language service
Samples taken 1553 1553 0.0%
Identifiers in tests 2402 2402 0.0%
getCompletionsAtPosition
    Mean duration (ms) 469.5 467.9 -0.3%
    Median duration (ms) 467.2 464.7 -0.6%
    Mean CV 9.1% 9.4% +2.7%
    Worst duration (ms) 614.1 653.2 +6.4%
    Worst identifier name digest
getQuickInfoAtPosition
    Mean duration (ms) 481.6 479.1 -0.5%
    Median duration (ms) 480.5 477.0 -0.7%
    Mean CV 10.7% 10.7% -0.1%
    Worst duration (ms) 657.2 618.9 -5.8%
    Worst identifier once console

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 22, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 22, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit d882b1c into DefinitelyTyped:master Jun 24, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 24, 2019

I just published @types/hapi__hapi@18.2.5 to npm.

iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@mikejpeters
[@hapi/hapi] separate app states (DefinitelyTyped#36361)
ac49181
watson added a commit to watson/kibana that referenced this pull request Mar 31, 2020
@watson
TypeScript fix: Use correct ApplicationState interface
6f8ec28 
The `ApplicationState` interface has in the new version of
`@types/hapi__hapi` been split up into:

- `RequestApplicationState`
- `ResponeApplicationState`
- `ServerApplicationState`

See PR for more info:
DefinitelyTyped/DefinitelyTyped#36361

It looks like the one we want to use is `RequestApplicationState`.
watson added a commit to watson/kibana that referenced this pull request Oct 29, 2020
@watson
TypeScript fix: Use correct ApplicationState interface
d19511c 
The `ApplicationState` interface has in the new version of
`@types/hapi__hapi` been split up into:

- `RequestApplicationState`
- `ResponeApplicationState`
- `ServerApplicationState`

See PR for more info:
DefinitelyTyped/DefinitelyTyped#36361

It looks like the one we want to use is `RequestApplicationState`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@saboya saboya saboya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@types/hapi - request.app and server.app are not the same

4 participants

@mikejpeters @typescript-bot @saboya @DanielRosenwasser