Skip to content

Fix #36308 - underscore has bad chain typings#36319

Merged
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
regevbr:master
Jun 24, 2019
Merged

Fix #36308 - underscore has bad chain typings#36319
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
regevbr:master

Conversation

@regevbr
Copy link
Copy Markdown
Contributor

@regevbr regevbr commented Jun 20, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@regevbr regevbr requested a review from borisyankov as a code owner June 20, 2019 12:18
@regevbr
Copy link
Copy Markdown
Contributor Author

regevbr commented Jun 20, 2019

Fix #36308 - underscore has bad chain typings
@jgonggrijp can you please review?

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Jun 20, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 20, 2019 •
edited
Loading

@regevbr Thank you for submitting this PR!

🔔 @borisyankov @jbaldwin @ccurrens @confususs @jgonggrijp @ffflorian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 20, 2019

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 20, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36319 diff
Batch compilation
Memory usage 56075304.0 56502232.0 +0.8%
Type count 8851 8871 +0.2%
Assignability cache size 1380 1383 +0.2%
Subtype cache size 525 525 0.0%
Identity cache size 0 0
Language service
Samples taken 1730 1742 +0.7%
Identifiers in tests 1730 1742 +0.7%
getCompletionsAtPosition
    Mean duration (ms) 189.5 184.8 -2.5%
    Median duration (ms) 185.2 180.3 -2.6%
    Mean CV 17.4% 16.7% -3.8%
    Worst duration (ms) 283.4 296.5 +4.6%
    Worst identifier templateSettings templateSettings
getQuickInfoAtPosition
    Mean duration (ms) 176.3 171.5 -2.7%
    Median duration (ms) 174.7 169.0 -3.3%
    Mean CV 17.4% 16.9% -3.1%
    Worst duration (ms) 264.9 251.0 -5.2%
    Worst identifier size key

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@regevbr
Copy link
Copy Markdown
Contributor Author

regevbr commented Jun 23, 2019

@jgonggrijp @DanielRosenwasser can you please help get this PR merged?
Thanks!

@regevbr
Copy link
Copy Markdown
Contributor Author

regevbr commented Jun 24, 2019

any news?

@DanielRosenwasser DanielRosenwasser merged commit ac897dc into DefinitelyTyped:master Jun 24, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 24, 2019

I just published @types/underscore@1.9.1 to npm.

@jgonggrijp
Copy link
Copy Markdown
Contributor

jgonggrijp commented Jun 25, 2019

@regevbr I'm a bit late to the party, but it looks good to me. ;-)

@renjfk
Copy link
Copy Markdown
Contributor

renjfk commented Jun 25, 2019

This seems to resolve only without and union but what about other chain methods? They still seem to be broken such as filter, map etc.

@regevbr
Copy link
Copy Markdown
Contributor Author

regevbr commented Jun 25, 2019

@renjfk I'm working on a full blown solution but it will take time as it requires refactoring the entire library.
If you have something that requires a quick fix I can make it happen as another patch

@renjfk
Copy link
Copy Markdown
Contributor

renjfk commented Jun 25, 2019

Nah no need, for the time being I can stick to 1.8 line.

RyanCavanaugh pushed a commit that referenced this pull request Jul 1, 2019
@Radullus @RyanCavanaugh
[@types/underscore] Fix #36308 - underscore has bad chain typi… (#36510)
020e04a 
* [@types/underscore] Fix #36308 - underscore has bad chain typings fix only for function 'map' (#36319)

* [@types/underscore] Fix #36308 - underscore has bad chain typings fix only for function 'map' (#36319)
Add more test and applay changes form review

* [@types/underscore] Fix #36308 - underscore has bad chain typings fix only for function 'map' (#36319)
 - Add more test
 - revert part of typings for function

* Comment part of test with currently didn't pass
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@regevbr
Fix DefinitelyTyped#36308 - underscore has bad chain typings (Definit…
c62db68 
…elyTyped#36319)
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@Radullus
[@types/underscore] Fix DefinitelyTyped#36308 - underscore has bad ch…
59233af 
…ain typi… (DefinitelyTyped#36510)

* [@types/underscore] Fix DefinitelyTyped#36308 - underscore has bad chain typings fix only for function 'map' (DefinitelyTyped#36319)

* [@types/underscore] Fix DefinitelyTyped#36308 - underscore has bad chain typings fix only for function 'map' (DefinitelyTyped#36319)
Add more test and applay changes form review

* [@types/underscore] Fix DefinitelyTyped#36308 - underscore has bad chain typings fix only for function 'map' (DefinitelyTyped#36319)
 - Add more test
 - revert part of typings for function

* Comment part of test with currently didn't pass
@reubenrybnik reubenrybnik mentioned this pull request May 31, 2020
Closed
10 tasks
@reubenrybnik reubenrybnik mentioned this pull request Jun 12, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisyankov borisyankov Awaiting requested review from borisyankov borisyankov is a code owner

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@regevbr @typescript-bot @jgonggrijp @renjfk @DanielRosenwasser