Skip to content

Add agent function in additional place#36152

Merged
rbuckton merged 1 commit intoDefinitelyTyped:masterfrom
southpolesteve:master
Jun 16, 2019
Merged

Add agent function in additional place#36152
rbuckton merged 1 commit intoDefinitelyTyped:masterfrom
southpolesteve:master

Conversation

@southpolesteve
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

My first PR was incomplete. There is a second location that needs this type #36057

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36152 diff
Batch compilation
Memory usage 65550216.0 67438200.0 +2.9%
Type count 9114 9117 0.0%
Assignability cache size 2877 2877 0.0%
Subtype cache size 0 0
Identity cache size 12 12 0.0%
Language service
Samples taken 165 165 0.0%
Identifiers in tests 165 165 0.0%
getCompletionsAtPosition
    Mean duration (ms) 358.5 355.0 -1.0%
    Median duration (ms) 356.0 353.8 -0.6%
    Mean CV 12.9% 13.9% +7.5%
    Worst duration (ms) 454.5 424.3 -6.6%
    Worst identifier response timeout
getQuickInfoAtPosition
    Mean duration (ms) 372.9 378.9 +1.6%
    Median duration (ms) 370.9 374.8 +1.0%
    Mean CV 14.7% 14.2% -3.4%
    Worst duration (ms) 446.2 458.1 +2.7%
    Worst identifier append fetch

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 12, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2019

@southpolesteve Thank you for submitting this PR!

🔔 @torstenwerner @nikcorg @vinaybedre @kyranet @AndrewLeedham @JasonLi914 @wilsonianb - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 12, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@rbuckton rbuckton merged commit 7c9599e into DefinitelyTyped:master Jun 16, 2019
@typescript-bot
Copy link
Contributor

I just published @types/node-fetch@2.3.7 to npm.

iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants