Skip to content

Add types for commander-remaining-args#36148

Merged
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
ffflorian:commander-remaining-args
Jun 20, 2019
Merged

Add types for commander-remaining-args#36148
DanielRosenwasser merged 1 commit intoDefinitelyTyped:masterfrom
ffflorian:commander-remaining-args

Conversation

@ffflorian
Copy link
Copy Markdown
Collaborator

@ffflorian ffflorian commented Jun 12, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 12, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to commander-remaining-args with its source on master.

Comparison details 📊
Batch compilation
Type count 8749
Assignability cache size 2808
Subtype cache size 0
Identity cache size 1
Language service measurements
Samples taken 7
Identifiers in tests 7
getCompletionsAtPosition
    Mean duration (ms) 309.5
    Median duration (ms) 315.3
    Mean CV 11.3%
    Worst duration (ms) 340.0
    Worst identifier getRemainingArgs
getQuickInfoAtPosition
    Mean duration (ms) 343.6
    Median duration (ms) 339.5
    Mean CV 14.1%
    Worst duration (ms) 363.7
    Worst identifier getRemainingArgs
System information
Node version v10.15.3
CPU count 2
CPU speed 2.394 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1045-azure

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@ffflorian
Copy link
Copy Markdown
Collaborator Author

ffflorian commented Jun 12, 2019

@sandersn seems like dtslint broke when trying to parse commander's typings?

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. The Travis CI build failed labels Jun 12, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 12, 2019 •
edited
Loading

@ffflorian Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 12, 2019 •
edited
Loading

@ffflorian The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sandersn
Copy link
Copy Markdown
Contributor

sandersn commented Jun 12, 2019

@ffflorian that is a Typescript crash! I'll try to repro locally and figure out which version of typescript crashes and why. Then I'll try to find a workaround for this PR.

@sandersn
Copy link
Copy Markdown
Contributor

sandersn commented Jun 12, 2019

The crash is fixed in 2.2 onwards. Add the line // TypeScript Version: 2.2 below the rest of the header to fix this.

@sandersn
Copy link
Copy Markdown
Contributor

sandersn commented Jun 12, 2019

For the error that shows up afterward, you'll need a package.json that references commander since it ships its own types.

This was referenced Jun 12, 2019
Closed
Merged
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 12, 2019 •
edited
Loading

@ffflorian The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ffflorian
Copy link
Copy Markdown
Collaborator Author

ffflorian commented Jun 13, 2019

Thank you @sandersn, I created a PR for that:

microsoft/types-publisher#623

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 18, 2019

@ffflorian I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@ffflorian
Copy link
Copy Markdown
Collaborator Author

ffflorian commented Jun 19, 2019

@sandersn could you please approve or request changes on microsoft/types-publisher#623?

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 19, 2019

Updated numbers for you here from 1744bbf:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to commander-remaining-args with its source on master.

Comparison details 📊
Batch compilation
Type count 8749
Assignability cache size 2808
Subtype cache size 0
Identity cache size 1
Language service measurements
Samples taken 7
Identifiers in tests 7
getCompletionsAtPosition
    Mean duration (ms) 323.5
    Median duration (ms) 336.8
    Mean CV 12.8%
    Worst duration (ms) 353.4
    Worst identifier option
getQuickInfoAtPosition
    Mean duration (ms) 338.2
    Median duration (ms) 339.6
    Mean CV 13.6%
    Worst duration (ms) 359.1
    Worst identifier getRemainingArgs
System information
Node version v10.15.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1045-azure

@DanielRosenwasser DanielRosenwasser merged commit 8deb2a8 into DefinitelyTyped:master Jun 20, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 20, 2019

I just published @types/commander-remaining-args@1.2.0 to npm.

@ffflorian ffflorian deleted the commander-remaining-args branch June 21, 2019 07:58
@hlovdal hlovdal mentioned this pull request Jun 21, 2019
Closed
1 task
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@ffflorian
Add types for commander-remaining-args (DefinitelyTyped#36148)
86ff3ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ffflorian @typescript-bot @sandersn @DanielRosenwasser