Skip to content

[core-js] remove dropped core.log #36100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbuckton merged 1 commit into from
Jun 16, 2019
Merged

[core-js] remove dropped core.log #36100

rbuckton merged 1 commit into from
Jun 16, 2019

Conversation

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jun 11, 2019 •
edited
Loading

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@saschanaz saschanaz requested a review from rbuckton as a code owner June 11, 2019 05:54
@saschanaz saschanaz mentioned this pull request Jun 11, 2019
Closed
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 11, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 11, 2019 •
edited
Loading

@saschanaz Thank you for submitting this PR!

🔔 @rbuckton @mfdeveloper - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 11, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36100 diff
Batch compilation
Type count 10910 10907 0.0%
Assignability cache size 32835 32834 0.0%
Subtype cache size 98 98 0.0%
Identity cache size 4 4 0.0%
Language service
Samples taken 8955 1778 -80.1%
Identifiers in tests 1791 1778 -0.7%
getCompletionsAtPosition
    Mean duration (ms) 411.1 435.4 +5.9%
    Median duration (ms) 407.0 432.6 +6.3%
    Mean CV 13.5%
    Worst duration (ms) 540.6 575.3 +6.4%
    Worst identifier promiseLikeOfPoint3D i
getQuickInfoAtPosition
    Mean duration (ms) 386.9 409.8 +5.9%
    Median duration (ms) 380.3 408.6 +7.4%
    Mean CV 14.2%
    Worst duration (ms) 510.4 517.9 +1.5%
    Worst identifier dict promiseLikeOfPoint
System information
Node version v10.15.3 v10.15.3
CPU count 2 2
CPU speed 2.294 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1041-azure 4.15.0-1045-azure

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jun 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 16, 2019

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@rbuckton rbuckton merged commit b639fa5 into DefinitelyTyped:master Jun 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 16, 2019

I just published @types/core-js@2.5.2 to npm.

@saschanaz saschanaz deleted the core-log branch June 16, 2019 08:15
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@saschanaz
[core-js] remove dropped core.log (DefinitelyTyped#36100)
78c9526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton rbuckton is a code owner

Assignees

No one assigned

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschanaz @typescript-bot @rbuckton