Skip to content

declare SymbolConstructor.observable#26034

Merged
uniqueiniquity merged 1 commit intoDefinitelyTyped:masterfrom
phra:patch-1
May 31, 2018
Merged

declare SymbolConstructor.observable#26034
uniqueiniquity merged 1 commit intoDefinitelyTyped:masterfrom
phra:patch-1

Conversation

@phra
Copy link
Contributor

@phra phra commented May 25, 2018

if SymbolConstructor.observable symbol is not defined in the types, the inclusion of the latest rxjs (v6) breaks the compilation in a strict environment.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

if `SymbolConstructor.observable` symbol is not defined in the types, the inclusion of the latest rxjs (v6) breaks the compilation in a strict environment.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 25, 2018

@phra Thank you for submitting this PR!

🔔 @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @eps1lon @Hannes-Magnusson-CK @jkomyno @ajafff @hoo29 @n-e @BrunoScheufler @mohsen1 @KSXGitHub @a-tarasyuk @islishude - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@BrunoScheufler BrunoScheufler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels May 30, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@phra
Copy link
Contributor Author

phra commented May 30, 2018

🎉

@uniqueiniquity
Copy link
Contributor

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@uniqueiniquity uniqueiniquity merged commit cab291c into DefinitelyTyped:master May 31, 2018
@orgads orgads mentioned this pull request Oct 27, 2020
9 tasks
orgads added a commit to orgads/rxjs that referenced this pull request Oct 27, 2020
This was reported previously on ReactiveX#3674, but instead of adding
this import, it was fixed in @types/node: DefinitelyTyped/DefinitelyTyped#26034.

This was removed in v14 of @types/node.

Fix it properly this time.

Fixes ReactiveX#5861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants