Skip to content

[expo] Comment LinearGradient typings to unblock #25083#25148

Closed
brunolemos wants to merge 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-14
Closed

[expo] Comment LinearGradient typings to unblock #25083#25148
brunolemos wants to merge 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-14

Conversation

@brunolemos
Copy link
Copy Markdown
Contributor

This is a temporary solution to unblock #25083.
We can add this again after this gets merged and published: react-native-linear-gradient/react-native-linear-gradient#280

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: [react-native] Support Layout Props #25083 (comment) (Solution 3)
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@brunolemos
Copy link
Copy Markdown
Contributor Author

Closed in favor of #25149 which seems less harmful

@brunolemos brunolemos closed this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant