Rename start and end props to startPoint and endPoint#280
Closed
brunolemos wants to merge 2 commits intoreact-native-linear-gradient:masterfrom
Closed
Rename start and end props to startPoint and endPoint#280brunolemos wants to merge 2 commits intoreact-native-linear-gradient:masterfrom
brunolemos wants to merge 2 commits intoreact-native-linear-gradient:masterfrom
Conversation
Fix react-native-linear-gradient#279 Fix conflict with react native layout props Related: DefinitelyTyped/DefinitelyTyped#25083
This was referenced Apr 19, 2018
Closed
This was referenced May 10, 2018
ee5ff4c to
d9e3c8a
Compare
|
👍 Please accept-it, I need the new release to stop using a patch. |
Partially revert react-native-linear-gradient#278 Extend ViewProps instead of ViewProperties
Closed
|
are there plans to merge this change in? |
Contributor
|
Hey @benhughes this seems like a good idea. If you can resolve the issue in the TypeScript definition we can look at merging this |
Contributor
Author
|
Not necessary anymore since DefinitelyTyped/DefinitelyTyped#28217 was merged today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #235.
Fix #279: Fix conflict with react native layout props
Current typescript typing has errors since this was merged: DefinitelyTyped/DefinitelyTyped#25083
TODO: Make it backwards compatibleTODO: Make a major bump release