Skip to content

[react-native] Add missing layout props#25081

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-10
Apr 18, 2018
Merged

[react-native] Add missing layout props#25081
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-10

Conversation

@brunolemos
Copy link
Copy Markdown
Contributor

Add missing layout props: borderEndWidth, borderStartWidth, display, end, marginEnd, marginStart, paddingEnd, paddingStart and start.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/react-native/blob/master/Libraries/StyleSheet/LayoutPropTypes.js
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

borderEndWidth, borderStartWidth, display, end, marginEnd, marginStart, paddingEnd, paddingStart, start

https://github.com/facebook/react-native/blob/master/Libraries/StyleSheet/LayoutPropTypes.js
@brunolemos brunolemos requested a review from alloy as a code owner April 18, 2018 05:56
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 18, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 18, 2018

@brunolemos Thank you for submitting this PR!

🔔 @alloy @huhuanming @iRoachie @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@timwangdev timwangdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 18, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit a8de5cf into DefinitelyTyped:master Apr 18, 2018
agorshkov23 pushed a commit to agorshkov23/DefinitelyTyped that referenced this pull request Apr 19, 2018
borderEndWidth, borderStartWidth, display, end, marginEnd, marginStart, paddingEnd, paddingStart, start

https://github.com/facebook/react-native/blob/master/Libraries/StyleSheet/LayoutPropTypes.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants