Skip to content

Conversation

@jnizet
Copy link
Contributor

@jnizet jnizet commented Dec 24, 2017

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

Settings was defined as a type, making it impossible to modify the Settings: importing it and modifying it caused the following compilation error: "error TS2693: 'Settings' only refers to a type, but is being used as a value here.".

Note: I initially thought of defining it as a class, but the linter prevented me from doing so because all its members are static. That's why it's defined as a namespace.

Settings was defined as a type, making it impossible to modify the Settings: importing it and modifying it caused the following compilation error: "error TS2693: 'Settings' only refers to a type, but is being used as a value here.".

Note: I initially thought of defining it as a class, but the linter prevented me from doing so because all its members are static. That's why it's defined as a namespace.
jnizet added a commit to Ninja-Squad/globe42 that referenced this pull request Dec 24, 2017
Since they're all new, they have a bug, that I fixed by using our own typings. See DefinitelyTyped/DefinitelyTyped#22494
@jnizet jnizet mentioned this pull request Dec 24, 2017
8 tasks
@jnizet
Copy link
Contributor Author

jnizet commented Dec 24, 2017

Already being taken care of by #22463, so I'll delete this one.

@jnizet jnizet closed this Dec 24, 2017
@jnizet jnizet deleted the fix/luxon-settings branch December 24, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant