luxon: make Settings a namespace #22494
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
Settings was defined as a type, making it impossible to modify the Settings: importing it and modifying it caused the following compilation error: "error TS2693: 'Settings' only refers to a type, but is being used as a value here.".
Note: I initially thought of defining it as a class, but the linter prevented me from doing so because all its members are static. That's why it's defined as a namespace.