[node] Update async_hooks according to renaming done in 8.2.0 #18530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currentId() => executionAsyncId() - triggerId() => triggerAsyncId() see nodejs/node#13490
Member
|
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @robdesideri @tellnes @WilcoBakker @octo-sniffle @smac89 @mwiktorczyk @wwwy3y3 @Tyriar @DeividasBakanas Microsoft TypeScript (account can't be detected)). Could you review this PR? Checklist
|
Contributor
|
I'm thinking maybe we should just remove deprecated API? |
Contributor
Author
|
I have considered this but as the API was already there for a while it's maybe already in use. My plan was to remove it later to give users a chance to adapt first. |
Contributor
|
Considering |
Contributor
|
👍 |
Contributor
|
Approved by a listed owner. PR appears ready to merge pending express review by a maintainer. |
milosdanilov
pushed a commit
to milosdanilov/DefinitelyTyped
that referenced
this pull request
Aug 5, 2017
…telyTyped#18530) - currentId() => executionAsyncId() - triggerId() => triggerAsyncId() see nodejs/node#13490
KSXGitHub
pushed a commit
to KSXGitHub/DefinitelyTyped
that referenced
this pull request
May 12, 2018
…telyTyped#18530) - currentId() => executionAsyncId() - triggerId() => triggerAsyncId() see nodejs/node#13490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
async_hooks.executionAsyncId()andtriggerAsyncId(). DeprecatedcurrentId()andtriggerId()npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
https://nodejs.org/dist/latest-v8.x/docs/api/async_hooks.html#async_hooks_async_hooks_executionasyncid
https://nodejs.org/dist/latest-v8.x/docs/api/async_hooks.html#async_hooks_async_hooks_triggerasyncid
async_hooks: rename currentId to currentAsyncId nodejs/node#13490
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.