Conversation
t-aleksander
approved these changes
Aug 5, 2025
wojcik91
added a commit
that referenced
this pull request
Aug 6, 2025
* restore merging of ips * merge adjacent subnets for nft (#185) * merge adjacent elements * update new tests * linter fixes * linter fix * review fixes --------- Co-authored-by: Maciek <19913370+wojcik91@users.noreply.github.com> Co-authored-by: Maciej Wójcik <maciek@wjck.pl> Co-authored-by: Maciej Wójcik <maciej@defguard.net>
wojcik91
added a commit
that referenced
this pull request
Aug 6, 2025
* restore merging of ips * merge adjacent subnets for nft (#185) * merge adjacent elements * update new tests * linter fixes * linter fix * review fixes --------- Co-authored-by: Aleksander <170264518+t-aleksander@users.noreply.github.com>
wojcik91
added a commit
that referenced
this pull request
Sep 10, 2025
* Merge adjacent IP subnets into ranges for nftables (#182) * restore merging of ips * merge adjacent subnets for nft (#185) * merge adjacent elements * update new tests * linter fixes * linter fix * review fixes --------- Co-authored-by: Maciek <19913370+wojcik91@users.noreply.github.com> Co-authored-by: Maciej Wójcik <maciek@wjck.pl> Co-authored-by: Maciej Wójcik <maciej@defguard.net> * bump version (#188) * update dependencies * update protos * update core dependency --------- Co-authored-by: Aleksander <170264518+t-aleksander@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change approach to merging subnets to limit code duplication with core.
This leverages the fact that addresses coming from core are already sorted and non-overlapping.