style: make torch.nn imports more uniform#626
Merged
Conversation
Closed
gcroci2
approved these changes
Jul 11, 2024
Collaborator
gcroci2
left a comment
There was a problem hiding this comment.
For being sure that Sphinx is able to solve the reference, you should use the fully qualified name (:class:torch.nn.Module). But it may be able to solve it also with the short version - not entirely clear. You should see after #625 is merged (now the trainer module is not correctly rendered) by activating the branch on readthedocs. Maybe just revert it for simplicity.
This reverts commit fba9e56.
Collaborator
Author
I reverted it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from torch import nnand then usenn.<Class>throughout.Note that this was also changed in one docstring in fba9e56. Not sure if that messes up the rendering of the documents. That commit can easily be dropped if needed.
fix #269