Merged
Conversation
DaniBodor
requested changes
Jul 11, 2024
Collaborator
There was a problem hiding this comment.
Great updates, the docs are definitely much more complete now.
Were you planning on adding descriptions for the NNs (as per #608) in this PR or in a separate one?
I added a commit that adds empty lines at the end of a couple of files were that wasn't the case
DaniBodor
approved these changes
Jul 11, 2024
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can look at the new docs rendered here.
I suggest to not look at the commits for this PR, but directly to the files changes. Main changes:
from __future__ import annotationsfor making possible the rendering of modules that were not correctly rendered before (or not rendered at all). To fix the issue, alsoTYPE_CHECKINGis used. Briefly, there were problems with type hints that made sphinx build fail on some modules (an error in the type hints import caused the modules to not be rendered).Note for myself: