Fix trackpad canvas wheel ownership across idle hover gaps#219
Merged
DeadWaveWave merged 3 commits intomainfrom May 1, 2026
Merged
Fix trackpad canvas wheel ownership across idle hover gaps#219DeadWaveWave merged 3 commits intomainfrom
DeadWaveWave merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Fixes workspace-canvas trackpad wheel ownership so canvas panning does not get stolen by a terminal/node after the pointer happens to come to rest above that node.
The key behavior change is intentional:
This keeps canvas panning stable without turning the fix into a per-node patch.
🏗️ Large Change Spec (Required if "Large Change" is checked)
1. Context & Business Logic
The existing implementation only treated wheel ownership as a contiguous burst problem. Once the gesture-gap timeout elapsed, ownership fell back to hit-testing the current hover target, which meant a terminal could steal the next trackpad pan even if the user had done nothing except pause briefly.
This PR upgrades the wheel session model so the canvas keeps a settled owner preference after the active capture window ends. A later explicit pointer retarget is required before wheel ownership can move back into a hovered terminal/node.
2. State Ownership & Invariants
Owner: renderer
workspaceCanvaswheel-gesture session state (trackpadGestureLockRefplus the derived capture-active UI flag).Invariants:
3. Verification Plan & Regression Layer
Regression layers:
tests/unit/contexts/wheelGestures.spec.tssrc/contexts/workspace/presentation/renderer/components/workspaceCanvas/hooks/useTrackpadGestures.spec.tsxtests/e2e/workspace-canvas.trackpad-gestures.spec.tsVerification run:
pnpm pre-commitpnpm test -- --run tests/unit/contexts/wheelGestures.spec.ts src/contexts/workspace/presentation/renderer/components/workspaceCanvas/hooks/useTrackpadGestures.spec.tsxpnpm test:e2e tests/e2e/workspace-canvas.trackpad-gestures.spec.ts --project electron --reporter=line✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence
Not attached via CLI. The behavior is covered by the new E2E regression, and I can add a recording in the GitHub UI if needed.