Skip to content

fix: avoid fit view after archiving active space#217

Merged
DeadWaveWave merged 2 commits intomainfrom
fix/remove-fit-view-after-archive
May 1, 2026
Merged

fix: avoid fit view after archiving active space#217
DeadWaveWave merged 2 commits intomainfrom
fix/remove-fit-view-after-archive

Conversation

@DeadWaveWave
Copy link
Copy Markdown
Owner

@DeadWaveWave DeadWaveWave commented May 1, 2026

💡 Change Scope

  • Small Change: Fast feedback, localized UI/logic, low-risk.
  • Large Change: New feature, cross-boundary logic, runtime-risk (persistence, IPC, lifecycle, recovery).

📝 What Does This PR Do?

  • Prevents the workspace canvas from auto-running global Fit view when the currently active Space is archived.
  • Keeps the existing explicit "All spaces" behavior unchanged, so manual global navigation still fits the canvas.
  • Adds a regression test that distinguishes between an intentional clear-to-all action and archive-driven Space removal.
  • Adds the required CHANGELOG entry for this user-visible behavior fix. (#217)

🏗️ Large Change Spec (Required if "Large Change" is checked)

N/A. This is a Small Change.


✅ Delivery & Compliance Checklist

  • My code passes the ultimate gatekeeper: pnpm pre-commit is completely green.
  • I have signed the CLA if required (see CLA.md).
  • I have included new tests to lock down the behavior (or explicitly stated why it's untestable).
  • I have strictly adhered to the DEVELOPMENT.md architectural boundaries.
  • I have attached a screenshot or screen recording (if this touches the UI).
  • I have updated the documentation accordingly (if adding a feature or changing a contract).

Note: the main functional commit passed pnpm pre-commit. A second rerun triggered only for the changelog-only follow-up commit hit an unrelated recovery E2E failure in tests/e2e/recovery.agent-input-after-restart.spec.ts and one flaky retry in tests/e2e/recovery.agent-terminal-replies.spec.ts.

📸 Screenshots / Visual Evidence

Behavior-only viewport change. No screenshot was attached from CLI.

@DeadWaveWave DeadWaveWave merged commit 9d9cf79 into main May 1, 2026
7 checks passed
@DeadWaveWave DeadWaveWave deleted the fix/remove-fit-view-after-archive branch May 1, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant