Add system notifications for agent completion#198
Merged
DeadWaveWave merged 1 commit intoDeadWaveWave:mainfrom Apr 28, 2026
Merged
Add system notifications for agent completion#198DeadWaveWave merged 1 commit intoDeadWaveWave:mainfrom
DeadWaveWave merged 1 commit intoDeadWaveWave:mainfrom
Conversation
f69b6af to
a3706e3
Compare
5 tasks
Xinyuexyyyyy
added a commit
to Xinyuexyyyyy/opencove
that referenced
this pull request
Apr 29, 2026
When Electron's Notification.isSupported() returns false on Linux (e.g., missing notification daemon), fall back to using the system notify-send utility to ensure agent completion notifications are delivered. Fixes: DeadWaveWave#198
Xinyuexyyyyy
added a commit
to Xinyuexyyyyy/opencove
that referenced
this pull request
Apr 30, 2026
When Electron's Notification.isSupported() returns false on Linux (e.g., missing notification daemon), fall back to using the system notify-send utility to ensure agent completion notifications are delivered. Fixes: DeadWaveWave#198
DeadWaveWave
pushed a commit
that referenced
this pull request
Apr 30, 2026
* fix: add notify-send fallback for Linux system notifications When Electron's Notification.isSupported() returns false on Linux (e.g., missing notification daemon), fall back to using the system notify-send utility to ensure agent completion notifications are delivered. Fixes: #198 * test: stabilize command center space focus e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Adds native system notifications for agent completion/standby events while preserving the existing in-app banner behavior.
system:show-notificationIPC path and preload/browser API.Cross-platform behavior
This is intended to work on all three supported desktop platforms: macOS, Windows, and Linux.
Notification, which routes through the OS notification system on macOS, Windows, and Linux.{ shown: false }when Electron reports notifications are unsupported, so unsupported Linux desktop/session setups fail quietly instead of breaking agent completion handling.I validated the implementation locally on macOS and kept automated tests from emitting real system notifications. Windows/Linux runtime behavior should be checked in platform CI or by maintainers with those desktop environments because this PR does not add platform-specific Windows/Linux E2E notification assertions.
🏗️ Large Change Spec (Required if "Large Change" is checked)
Not applicable. This is a small, localized notification-path change. It does not modify durable state, recovery semantics, or persistence schema.
1. Context & Business Logic
Agent completion is already detected when a session transitions from
workingtostandby. This PR keeps that detection and adds an OS-native notification through Main process IPC.2. State Ownership & Invariants
3. Verification Plan & Regression Layer
✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence
Not attached. The native OS notification is suppressed in automated test mode; the existing in-app banner path was verified by E2E.
Verification
npx pnpm@9.6.0 test -- --run tests/unit/app/agentStandbySystemNotification.spec.ts tests/unit/contexts/agentConfig.spec.tsnpx pnpm@9.6.0 checknpx pnpm@9.6.0 lintnpx pnpm@9.6.0 buildnpx pnpm@9.6.0 exec playwright test tests/e2e/workspace-canvas.agent-status-watcher.spec.ts --grep "updates an active agent"