[lldp] Add check for hostname in lldpmgrd#68
Open
DavidZagury wants to merge 1 commit intomasterfrom
Open
Conversation
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
… automatically (sonic-net#886) #### Why I did it src/sonic-platform-common ``` * 3b780b0 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#68) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tomatically (sonic-net#1000) #### Why I did it src/sonic-swss ``` * 9e9442d - (HEAD -> 202412, origin/202412) [orchagent] Fix issue: typo in high BER (#68) (3 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Oct 15, 2025
…ly (sonic-net#23194) #### Why I did it src/sonic-ztp ``` * c20ba9c - (HEAD -> 202505, origin/202505) [ci] Upgrade agent pool from ubuntu 20.04 to latest. (#68) (24 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Mar 9, 2026
…sonic-net#25508) #### Why I did it src/dhcpmon ``` * d78974f - (HEAD -> master, origin/master, origin/HEAD) [dhcp_mon] Add missing #include <algorithm> for std::replace (#68) (31 hours ago) [rustiqly] * d4934fa - Add .github/copilot-instructions.md for AI-assisted development (#67) (31 hours ago) [rustiqly] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When a switch run with a config db that is missing the key hostname from the DEVICE_METADATA, exception is thrown, which isn't an user friendly.
Before:
After:
2025 Mar 26 09:36:58.109307 sonic-switch ERR lldp#lldpmgrd[733]: Hostname is not definedWork item tracking
How I did it
Added a check the make sure that hostname exists and if not, print a user friendly error instead of the traceback.
How to verify it
Remove the hostname configuration and start lldp docker.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)