Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
DavidHDev
approved these changes
Mar 7, 2025
Owner
|
Thanks! |
AthalarBlizz
pushed a commit
to EventHorizon-Forge/ehfcreact-bits
that referenced
this pull request
May 4, 2025
…pes-on-RotatingText-ts fix-types-on-RotatingText-ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I used the component RotatingText (TypeScript version) and deployed my project on Vercel, I was blocked in build due this error:
So I fixed and deploy went well (I just add the types from the lib, the same that the filed accept, so now the component prop reflects the lib types)
It is not a big deal, but can save 15 min of the next developer using this same component on Vercel
Note: It is only type related, so the Demo and tests will not got any changes, only linters 🙃