Adds system test that reports grpc status code in the stats#6483
Merged
bric3 merged 4 commits intoMar 18, 2026
Conversation
Contributor
|
|
ichinaski
approved these changes
Mar 13, 2026
b7577af to
5e94312
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: ab9a025 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
* Adds a parameteric test for the grpc status code * Replace parametric test by regular for the grpc status code
5e94312 to
a4048d8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4048d858b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cbeauchesne
reviewed
Mar 17, 2026
genesor
reviewed
Mar 17, 2026
| tests/serverless/span_pointers/aws/test_s3_span_pointers.py::Test_PutObject: missing_feature | ||
| tests/stats/test_stats.py: v1.54.0 | ||
| tests/stats/test_stats.py::Test_Client_Drop_P0s::test_client_drop_p0s_false: v2.6.0 | ||
| tests/stats/test_stats.py::Test_Client_Stats::test_grpc_status_code: irrelevant (variant has no gRPC endpoint) |
Member
There was a problem hiding this comment.
Two questions:
- Should we add grpc endpoints to our weblogs ?
- Should every tracer now report grpc status codes ?
Contributor
Author
There was a problem hiding this comment.
Should we add grpc endpoints to our weblogs ?
In my opinion, yes. Since this is an important part of the stats aggregation.
Should every tracer now report grpc status codes ?
Theoretically, they should since it's part of the CCS protocol.
annacai21
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The java agent didn't included the gRPC status code in the stats payload. It will do so in 1.61.0. So let's add a system test to verify that.