Add tests for service name process tags#6204
Merged
Merged
Conversation
Contributor
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 63dce1d | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
nccatoni
reviewed
Feb 4, 2026
nccatoni
left a comment
Collaborator
There was a problem hiding this comment.
Checks based on the library name/version outside of the manifests is problematic and should generally be avoided
raphaelgavache
approved these changes
Feb 4, 2026
b45de2b to
dd3d7a7
Compare
9bacf30 to
cfbbc83
Compare
cfbbc83 to
baa0956
Compare
nccatoni
approved these changes
Feb 6, 2026
vandonr
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Mar 19, 2026
…8106) ## Summary of changes Implements [Andrea's specification](https://docs.google.com/document/d/1c47iSTWxIOHMHfZTF2nT9xfyQaIBP9KJvI9sRn5SvpM/edit?tab=t.0#heading=h.uoivahvmuvbg). TLDR: We need to send in process tags whether the service used is the one set by the user or the default one. It was deemed acceptable not to handle the case where the service is set at the scope level when creating spans, so we focus on service set by the user through config. ## Reason for change Service renaming shouldn't rename a service if it's the one set by the customer but the backend doesn't know that today ## Implementation details - As the service can be changed in the settings, I moved the process tags in the `MutableSettings`. As a side effect it simplifies part of the code as we don't have to pass service tags anymore as they're in Settings. - The ProcessTags object is null when the PropagateServiceTag config key is false. We rely in the rest of the code on whether the tags are null or not. - Process tags are still lazily initialized. The `ProcessTags` class is merely a container of the information needed when you need to serialize them. ## Test coverage Utests mainly. There are system tests to update once merged: DataDog/system-tests#6204 ## Other details AI generated and polished by hand (and repolished again :p) APMLP-1000 --------- Signed-off-by: Pierre Bonet <pierre.bonet@datadoghq.com> Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com> Co-authored-by: Raphaël Vandon <raphael.vandon@datadoghq.com> Co-authored-by: Raphaël Vandon <raphael.vandon@datadog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements tests for Signaling service name source on the process tags (see https://docs.google.com/document/d/1c47iSTWxIOHMHfZTF2nT9xfyQaIBP9KJvI9sRn5SvpM)
The process tags have been improved by adding:
svc.user:truewhen DD_SERVICE is setsvc.auto:<svc_name>when DD_SERVICE is not set. The value<svc_name>is set to the default value calculated by the tracer according to each tracer algorithms (i.e. jar name, package.json field name, binary name, etc..)As a today is only implemented by dd-trace-java from
1.59.0Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present