Skip to content

[dotnet] Mark test test_metadata_content_with_process_tags as a missing feature for now#5664

Merged
dd-mergequeue[bot] merged 3 commits intomainfrom
gleocadie/disable-test-discovery-test-for-dotnet
Dec 12, 2025
Merged

[dotnet] Mark test test_metadata_content_with_process_tags as a missing feature for now#5664
dd-mergequeue[bot] merged 3 commits intomainfrom
gleocadie/disable-test-discovery-test-for-dotnet

Conversation

@gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Nov 5, 2025

Motivation

.NET tracer supports only config v1 protocol but the libdatadog library-config emits v2. This misalignment causes the system-tests to fails in CI.

Changes

Decorate the test test_metadata_content_with_process_tags as a missing feature. The goal being to detect when .NET library support v2 protocol and the test needs to be updated accordingly.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet

@gleocadie gleocadie force-pushed the gleocadie/disable-test-discovery-test-for-dotnet branch 3 times, most recently from f28a35a to f8f4deb Compare November 5, 2025 11:34
@gleocadie gleocadie changed the title [dotnet] Mark test test_metadata_content_with_process_tags as a bug for now [dotnet] Mark test test_metadata_content_with_process_tags as a missing feature for now Nov 5, 2025
@gleocadie gleocadie marked this pull request as ready for review December 10, 2025 13:46
@gleocadie gleocadie requested review from a team as code owners December 10, 2025 13:46
@gleocadie gleocadie requested review from mabdinur and removed request for a team December 10, 2025 13:46
@gleocadie gleocadie force-pushed the gleocadie/disable-test-discovery-test-for-dotnet branch from f8f4deb to cd8f0e2 Compare December 10, 2025 13:50
Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion. We can merge this PR when it is addressed

@gleocadie gleocadie force-pushed the gleocadie/disable-test-discovery-test-for-dotnet branch from cd8f0e2 to 82c72d2 Compare December 12, 2025 12:49
@gleocadie gleocadie requested review from a team as code owners December 12, 2025 12:49
@gleocadie gleocadie force-pushed the gleocadie/disable-test-discovery-test-for-dotnet branch from 82c72d2 to 439cedf Compare December 12, 2025 13:04
@gleocadie
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 12, 2025

View all feedbacks in Devflow UI.

2025-12-12 16:15:18 UTC ℹ️ Start processing command /merge


2025-12-12 16:15:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 6m (p90).


2025-12-12 16:24:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b305ca9 into main Dec 12, 2025
27 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gleocadie/disable-test-discovery-test-for-dotnet branch December 12, 2025 16:24
gleocadie added a commit to DataDog/dd-trace-dotnet that referenced this pull request Dec 17, 2025
## Summary of changes

Bump to libdatadog v24.0.2.

## Reason for change

This version provides fixes for crashtracker and new features for
config.

## Implementation details

Update vcpkg and cmake files.

## Test coverage

## Other details
<!-- Fixes #{issue} -->
https://datadoghq.atlassian.net/browse/PROF-12961

And wait for this
[PR](DataDog/system-tests#5664) to be merged
first.

---------

Co-authored-by: Damien MEHALA <damien.mehala@datadoghq.com>
Co-authored-by: Julio <julio.gonzalez@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants