Skip to content

[dotnet] Add APM_TRACING_MULTICONFIG capability for dotnet#5338

Merged
dudikeleti merged 3 commits intomainfrom
dotnet/dudi/add-multiconfig-capability
Sep 30, 2025
Merged

[dotnet] Add APM_TRACING_MULTICONFIG capability for dotnet#5338
dudikeleti merged 3 commits intomainfrom
dotnet/dudi/add-multiconfig-capability

Conversation

@dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Sep 25, 2025 •
edited
Loading

Add APM_TRACING_MULTICONFIG capability for dotnet

Motivation

Tracers should add this capability to support multi config

Changes

Capability added to the expected capabilities list

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@dudikeleti dudikeleti mentioned this pull request Sep 26, 2025
Merged
@dudikeleti dudikeleti changed the title Update test_dynamic_configuration.py [dotnet] Add APM_TRACING_MULTICONFIG capability for dotnet Sep 30, 2025
@dudikeleti dudikeleti force-pushed the dotnet/dudi/add-multiconfig-capability branch 2 times, most recently from fc7215a to 4901fab Compare September 30, 2025 13:21
@dudikeleti dudikeleti force-pushed the dotnet/dudi/add-multiconfig-capability branch from cc6e8c2 to bd0fdb9 Compare September 30, 2025 14:30
@dudikeleti dudikeleti marked this pull request as ready for review September 30, 2025 14:38
@dudikeleti dudikeleti requested review from a team and mabdinur as code owners September 30, 2025 14:38
@dudikeleti dudikeleti merged commit 22155f0 into main Sep 30, 2025
29 checks passed
@dudikeleti dudikeleti deleted the dotnet/dudi/add-multiconfig-capability branch September 30, 2025 14:40
dudikeleti added a commit to DataDog/dd-trace-dotnet that referenced this pull request Sep 30, 2025
@dudikeleti
[Debugger Default-On] DEBUG-4406 Support multi-config merging with pr…
a220a59 
…iorities (#7536)

## Summary of changes
Implements priority-based merging for APM_TRACING config with
determenistic order:
Priority Order: Service+Env (4) > Service (3) > Env (2) > Wildcard (1) >
Org (0)

## Reason for change
When multiple configs are sent, the "last one wins." This causes
non-deterministic behavior across tracers and inconsistent feature
enablement. internal
[RFC](https://docs.google.com/document/d/1J4azr17gJQipGhyWIWuBArkhe1UfStKx7XZRmjqjhqQ/edit?tab=t.b22x9owvguir)

## Test coverage
ApmTracingConfigMergerTests.cs
DataDog/system-tests#5338
chagui pushed a commit that referenced this pull request Oct 1, 2025
@dudikeleti @chagui
[dotnet] Add APM_TRACING_MULTICONFIG capability for dotnet (#5338)
2e3d960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anna-git anna-git anna-git approved these changes

@mabdinur mabdinur Awaiting requested review from mabdinur

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dudikeleti @anna-git