[NO-TICKET] Temporarily disable memory leak asan testing in CI#3915
Merged
Conversation
**What does this PR do?** This PR disables the memory leak asan testing job in CI. This job started failing because the upstream ruby-dev-builder has been failing to produce Ruby asan builds in the past few days. Hopefully this will be corrected soon, but for now the easiest thing for us is to disable this. I've also reached out to a few contacts to see if we can get this fixed :) **Motivation:** Disable non-working CI step for now. **Additional Notes:** N/A **How to test the change?** Validate that all CI jobs are green in this PR.
y9v
approved these changes
Sep 17, 2024
ivoanjo
added a commit
that referenced
this pull request
Oct 7, 2024
**What does this PR do?** This PR reverts #3915 where we temporarily disable memory leak testing using the asan tool because upstream builds were broken. Additionally, since ruby/setup-ruby#653 the setup-ruby action now fully supports the asan builds, so we no longer require our fork. **Motivation:** The asan tool does quite extensive checks in the profiler test suite, so having it running in CI helps catch issues that may otherwise slip by. **Additional Notes:** N/A **How to test the change?** Validate that the "Test for memory leaks -> test-asan" CI job is running and passing successfully.
ivoanjo
added a commit
that referenced
this pull request
Nov 7, 2024
**What does this PR do?** This PR re-enables the memory leak testing using the asan tool job in CI. For context, we added this testing in #3864 (more details about what asan is can be found in that PR), but had to disable it in #3915 as the upstream Ruby builds we were using were broken and unavailable for a while. This has since been fixed upstream, and so let's re-enable this CI job. In fact, upstream now officially allows these builds to be used, so we no longer even need our fork of `setup-ruby` to enable them. **Motivation:** Improve our testing for native memory leaks. **Additional Notes:** N/A **How to test the change?** Validate that the "test-asan" is now running in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables the memory leak asan testing job in CI. This job started failing because the upstream ruby-dev-builder has been failing to produce Ruby asan builds in the past few days.
Hopefully this will be corrected soon, but for now the easiest thing for us is to disable this. I've also reached out to a few contacts to see if we can get this fixed :)
Motivation:
Disable non-working CI step for now.
Additional Notes:
N/A
How to test the change?
Validate that all CI jobs are green in this PR.