fix(kafka): fix crash from `_get_cluster_id` by KowalskiThomas · Pull Request #18236 · DataDog/dd-trace-py

KowalskiThomas · 2026-05-22T11:13:46Z

Description

This fixes a crash that would occur when using the Kafka integration.

Python stacks

Thread 0x00007f2e5affd6c0 (most recent call first):
  File "/usr/lib/python3.12/threading.py", line 355 in wait
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/_queue.py", line 242 in get
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/worker.py", line 120 in _target
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2e797fa6c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2e7bfff6c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2ed9ffb6c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2ef0d016c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2ed97fa6c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Thread 0x00007f2edbfff6c0 (most recent call first):
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume
  File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume
  File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages
  File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run
  File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper
  File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run
  File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread
  File "/usr/lib/python3.12/threading.py", line 1012 in run
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func
  File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run
  File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner
  File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap

Native stack

Error UnixSignal: Process terminated with SEGV_MAPERR (SIGSEGV)
#0   0x00007f3058686017 rd_kafka_q_serve_rkmessages
#1   0x00007f30586480bc rd_kafka_consume_batch_queue
#2   0x00007f306d783cda cfunction_call
#3   0x00007f306d796f02 _PyObject_Call.localalias
#4   0x00007f306d76804a _PyEval_EvalFrameDefault.localalias
#5   0x00007f306d783a43 object_vacall
#6   0x00007f306d827040 PyObject_CallFunctionObjArgs
#7   0x00007f306d757ccc _PyObject_MakeTpCall.localalias
#8   0x00007f306d762ec4 _PyEval_EvalFrameDefault.localalias
#9   0x00007f306d7b220e _PyObject_VectorcallTstate.lto_priv.14
#10  0x00007f306d7b1d6f method_vectorcall
#11  0x00007f306d8a3afd thread_run
#12  0x00007f306d89018c pythread_wrapper
#13  0x00007f306d3e73c6 start_thread
#14  0x00007f306d46c1cc __clone3

datadog-prod-us1-3 · 2026-05-22T11:23:26Z

Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]

🔄 Retry job. This looks flaky and may succeed on retry.
Failed to create pod sandbox due to insufficient IP addresses available for allocation. Cilium plugin error: no IPs currently available on the node.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64, 1]

🔄 Retry job. This looks flaky and may succeed on retry.
Unable to allocate IP via local Cilium agent: no IPs currently available on the node.

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64]

🔄 Retry job. This looks flaky and may succeed on retry.
Containers not ready: emmissary build helper not initialized.

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 6252665 | Docs | Datadog PR Page | Give us feedback!}

pr-commenter · 2026-05-22T11:42:30Z

Benchmarks

Benchmark execution time: 2026-05-22 11:42:28

Comparing candidate commit 7c03fe2 in PR branch kowalski/fix-kafka-fix-crash-from-_get_cluster_id with baseline commit ff51b32 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 559 metrics, 9 unstable metrics.

scenario:iastaspects-lstrip_aspect

🟥 execution_time [+71.944µs; +79.570µs] or [+25.654%; +28.373%]

scenario:iastaspectsospath-ospathbasename_aspect

🟥 execution_time [+96.403µs; +104.727µs] or [+22.164%; +24.077%]

scenario:telemetryaddmetric-1-count-metric-1-times

🟥 execution_time [+166.605ns; +206.601ns] or [+8.051%; +9.984%]

cit-pr-commenter-54b7da · 2026-05-26T07:42:49Z

Codeowners resolved as

ddtrace/contrib/internal/kafka/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
releasenotes/notes/tracing-kafka-fix-crash-cluster-id-f15e0626ac764bd2.yaml  @DataDog/apm-python
tests/contrib/kafka/test_kafka_patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55ba2b7886

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

quinna-h

LGTM, do we need to add a small unit test?
i.e. something in tests/contrib/kafka/test_kafka that calls _get_cluster_id and asserts that 1) result is "", 2) list_topics is never invoked

## Description This fixes a crash that would occur when using the Kafka integration. **Python stacks** ``` Thread 0x00007f2e5affd6c0 (most recent call first): File "/usr/lib/python3.12/threading.py", line 355 in wait File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/_queue.py", line 242 in get File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/worker.py", line 120 in _target File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2e797fa6c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2e7bfff6c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2ed9ffb6c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2ef0d016c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2ed97fa6c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap Thread 0x00007f2edbfff6c0 (most recent call first): File "/opt/venv/lib/python3.12/site-packages/ddtrace/contrib/internal/kafka/patch.py", line 232 in traced_poll_or_consume File "/opt/app/pkgs/extensions/kafka/confluent_kafka_consumer.py", line 136 in consume File "/opt/app/suma/kafka/consumer/runner.py", line 158 in consume_messages File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 245 in poll_messages File "/opt/app/suma/kafka/consumer/runner.py", line 333 in _run File "/opt/venv/lib/python3.12/site-packages/ddtrace/_trace/tracer.py", line 860 in func_wrapper File "/opt/app/suma/kafka/consumer/runner.py", line 325 in run File "/opt/app/suma/kafka/consumer_cmd.py", line 156 in run_consumer_thread File "/usr/lib/python3.12/threading.py", line 1012 in run File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 133 in _run_old_run_func File "/opt/venv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 140 in run File "/usr/lib/python3.12/threading.py", line 1075 in _bootstrap_inner File "/usr/lib/python3.12/threading.py", line 1032 in _bootstrap ``` **Native stack** ``` Error UnixSignal: Process terminated with SEGV_MAPERR (SIGSEGV) #0 0x00007f3058686017 rd_kafka_q_serve_rkmessages #1 0x00007f30586480bc rd_kafka_consume_batch_queue #2 0x00007f306d783cda cfunction_call #3 0x00007f306d796f02 _PyObject_Call.localalias #4 0x00007f306d76804a _PyEval_EvalFrameDefault.localalias #5 0x00007f306d783a43 object_vacall #6 0x00007f306d827040 PyObject_CallFunctionObjArgs #7 0x00007f306d757ccc _PyObject_MakeTpCall.localalias #8 0x00007f306d762ec4 _PyEval_EvalFrameDefault.localalias #9 0x00007f306d7b220e _PyObject_VectorcallTstate.lto_priv.14 #10 0x00007f306d7b1d6f method_vectorcall #11 0x00007f306d8a3afd thread_run #12 0x00007f306d89018c pythread_wrapper #13 0x00007f306d3e73c6 start_thread #14 0x00007f306d46c1cc __clone3 ``` Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>

fix(kafka): fix crash from _get_cluster_id

55ba2b7

KowalskiThomas force-pushed the kowalski/fix-kafka-fix-crash-from-_get_cluster_id branch from 7c03fe2 to 55ba2b7 Compare May 26, 2026 07:41

taegyunkim approved these changes May 26, 2026

View reviewed changes

KowalskiThomas marked this pull request as ready for review May 26, 2026 15:48

KowalskiThomas requested review from a team as code owners May 26, 2026 15:48

KowalskiThomas requested review from Kyle-Verhoog, brettlangdon and wconti27 May 26, 2026 15:48

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread ddtrace/contrib/internal/kafka/patch.py

quinna-h approved these changes May 26, 2026

View reviewed changes

KowalskiThomas added 2 commits May 27, 2026 09:15

review: add tests

9825bfa

fix: cache results to share between producer and consumer

6252665

gh-worker-dd-mergequeue-cf854d Bot merged commit 4c051a5 into main May 27, 2026
391 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the kowalski/fix-kafka-fix-crash-from-_get_cluster_id branch May 27, 2026 08:59

KowalskiThomas mentioned this pull request May 28, 2026

fix(kafka): avoid crashes from reentrant calls #17734

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(kafka): fix crash from `_get_cluster_id`#18236

fix(kafka): fix crash from `_get_cluster_id`#18236
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
kowalski/fix-kafka-fix-crash-from-_get_cluster_id

KowalskiThomas commented May 22, 2026

Uh oh!

datadog-prod-us1-3 Bot commented May 22, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

pr-commenter Bot commented May 22, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented May 26, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

quinna-h left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

KowalskiThomas commented May 22, 2026

Description

Uh oh!

datadog-prod-us1-3 Bot commented May 22, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

pr-commenter Bot commented May 22, 2026

Benchmarks

scenario:iastaspects-lstrip_aspect

scenario:iastaspectsospath-ospathbasename_aspect

scenario:telemetryaddmetric-1-count-metric-1-times

Uh oh!

cit-pr-commenter-54b7da Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codeowners resolved as

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

quinna-h left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-prod-us1-3 Bot commented May 22, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

cit-pr-commenter-54b7da Bot commented May 26, 2026 •

edited

Loading