Skip to content

chore(ci): exclude FEATURE_FLAGGING_AND_EXPERIMENTATION from CI on push#18163

Closed
cbeauchesne wants to merge 1 commit into
mainfrom
cbeauchesne/exclude-FEATURE_FLAGGING_AND_EXPERIMENTATION
Closed

chore(ci): exclude FEATURE_FLAGGING_AND_EXPERIMENTATION from CI on push#18163
cbeauchesne wants to merge 1 commit into
mainfrom
cbeauchesne/exclude-FEATURE_FLAGGING_AND_EXPERIMENTATION

Conversation

@cbeauchesne

@cbeauchesne cbeauchesne commented May 19, 2026

Copy link
Copy Markdown
Contributor

Description

Testing

Risks

Additional Notes

@cbeauchesne cbeauchesne requested review from a team as code owners May 19, 2026 13:23
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pipelines  Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Changelog | Validate changelog   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Release note not found during changelog validation.

pr-name | pr_name_lint   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. PR title linting failed due to subject casing rules violation: subject must not be sentence-case, start-case, pascal-case, upper-case.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fd4e587 | Docs | Datadog PR Page | Give us feedback!

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 19, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd4e5878a2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/system-tests.yml
@brettlangdon brettlangdon changed the title chore(ci): Exclude FEATURE_FLAGGING_AND_EXPERIMENTATION from CI on push chore(ci): exclude FEATURE_FLAGGING_AND_EXPERIMENTATION from CI on push May 19, 2026
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 19, 2026
@pr-commenter

pr-commenter Bot commented May 19, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-19 13:50:59

Comparing candidate commit fd4e587 in PR branch cbeauchesne/exclude-FEATURE_FLAGGING_AND_EXPERIMENTATION with baseline commit f383d81 in branch main.

Found 0 performance improvements and 10 performance regressions! Performance is the same for 604 metrics, 10 unstable metrics.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.616µs; +1.752µs] or [+8.209%; +8.903%]

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+251.076µs; +283.583µs] or [+7.235%; +8.171%]

scenario:iastaspects-index_aspect

  • 🟥 execution_time [+9.080µs; +12.055µs] or [+7.492%; +9.947%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+605.266µs; +642.022µs] or [+15.732%; +16.688%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+101.815µs; +110.125µs] or [+23.960%; +25.916%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+12.666µs; +16.092µs] or [+8.660%; +11.002%]

scenario:iastaspectssplit-split_noaspect

  • 🟥 execution_time [+11.320µs; +14.897µs] or [+7.459%; +9.817%]

scenario:span-start

  • 🟥 execution_time [+1.573ms; +1.718ms] or [+10.186%; +11.124%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+255.704ns; +284.458ns] or [+12.486%; +13.890%]

scenario:tracer-small

  • 🟥 execution_time [+24.244µs; +26.424µs] or [+7.162%; +7.806%]

@cbeauchesne

cbeauchesne commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-19 14:59:12 UTC ℹ️ Start processing command /merge

2026-05-19 14:59:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 53m (p90).

2026-05-19 16:01:35 UTC ⚠️ MergeQueue: This merge request build was cancelled

brett.langdon@datadoghq.com cancelled this merge request build

@leoromanovsky leoromanovsky mentioned this pull request May 19, 2026
Closed
@dd-oleksii dd-oleksii mentioned this pull request May 19, 2026
Merged
@brettlangdon

brettlangdon commented May 19, 2026

Copy link
Copy Markdown
Member

Closing in favor of #18160 which also does this and is in the MQ

@leoromanovsky leoromanovsky mentioned this pull request May 19, 2026
Merged
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request May 20, 2026
@leoromanovsky @dd-oleksii
chore(ci): restore ffe system-tests coverage (#18172)
fe9ac39 
## Motivation

#18163 was closed in favor of #18160, which also excludes the FEATURE_FLAGGING_AND_EXPERIMENTATION scenario from the tracer-release system-tests group. That exclusion is no longer the desired rollback path because it hides the FFE coverage we need while validating the Python startup issue.

## Changes

Remove the `excluded_scenarios: FEATURE_FLAGGING_AND_EXPERIMENTATION` override from the #18160 system-tests workflow migration so the tracer-release group includes the FFE scenario again.

## Decisions

This PR is stacked on #18160 instead of #18163 because #18163 was closed unmerged. It keeps the official system-tests workflow migration intact and only reverts the FFE scenario exclusion.

Co-authored-by: oleksii.shmalko <oleksii.shmalko@datadoghq.com>
vlad-scherbich pushed a commit that referenced this pull request May 20, 2026
@leoromanovsky @dd-oleksii @vlad-scherbich
chore(ci): restore ffe system-tests coverage (#18172)
a170efd 
## Motivation

#18163 was closed in favor of #18160, which also excludes the FEATURE_FLAGGING_AND_EXPERIMENTATION scenario from the tracer-release system-tests group. That exclusion is no longer the desired rollback path because it hides the FFE coverage we need while validating the Python startup issue.

## Changes

Remove the `excluded_scenarios: FEATURE_FLAGGING_AND_EXPERIMENTATION` override from the #18160 system-tests workflow migration so the tracer-release group includes the FFE scenario again.

## Decisions

This PR is stacked on #18160 instead of #18163 because #18163 was closed unmerged. It keeps the official system-tests workflow migration intact and only reverts the FFE scenario exclusion.

Co-authored-by: oleksii.shmalko <oleksii.shmalko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@brettlangdon brettlangdon brettlangdon approved these changes

@RamyElkest RamyElkest Awaiting requested review from RamyElkest RamyElkest is a code owner automatically assigned from DataDog/python-guild

@emmettbutler emmettbutler Awaiting requested review from emmettbutler emmettbutler is a code owner automatically assigned from DataDog/apm-core-python

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbeauchesne @brettlangdon