refactor: remove crash in MetricNamespace#17706
refactor: remove crash in MetricNamespace#17706gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
MetricNamespace#17706Conversation
Codeowners resolved as |
feb890c to
7318b97
Compare
MetricNamespaceMetricNamespace
brettlangdon
left a comment
There was a problem hiding this comment.
keep an eye on the performance for the benchmarks for telemetry
Noted. I have checked on the current run and compared to main, things seem to be fine. I'll send a heads-up in the guild channel. |
Performance SLOsComparing candidate kowalski/fix-fix-crash-in-metricnamespace (9f711e9) with baseline main (8f2af64) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.551µs (SLO: <130.000µs 📉 -20.3%) vs baseline: +0.3% Memory: ✅ 44.017MB (SLO: <46.000MB -4.3%) vs baseline: +5.4% ✅ add_inplace_aspectTime: ✅ 101.503µs (SLO: <130.000µs 📉 -21.9%) vs baseline: -3.0% Memory: ✅ 43.964MB (SLO: <46.000MB -4.4%) vs baseline: +5.4% ✅ add_inplace_noaspectTime: ✅ 28.122µs (SLO: <40.000µs 📉 -29.7%) vs baseline: -1.5% Memory: ✅ 43.928MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 49.390µs (SLO: <70.000µs 📉 -29.4%) vs baseline: -0.6% Memory: ✅ 43.911MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 264.995µs (SLO: <400.000µs 📉 -33.8%) vs baseline: +0.5% Memory: ✅ 43.873MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ bytearray_extend_aspectTime: ✅ 654.043µs (SLO: <800.000µs 📉 -18.2%) vs baseline: +0.5% Memory: ✅ 43.920MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 271.636µs (SLO: <400.000µs 📉 -32.1%) vs baseline: +0.4% Memory: ✅ 43.864MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ bytearray_noaspectTime: ✅ 146.214µs (SLO: <300.000µs 📉 -51.3%) vs baseline: -1.7% Memory: ✅ 43.939MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ bytes_aspectTime: ✅ 228.523µs (SLO: <300.000µs 📉 -23.8%) vs baseline: -1.4% Memory: ✅ 43.894MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 140.052µs (SLO: <200.000µs 📉 -30.0%) vs baseline: +1.4% Memory: ✅ 43.923MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 3.817ms (SLO: <5.000ms 📉 -23.7%) vs baseline: -2.1% Memory: ✅ 43.938MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 322.968µs (SLO: <420.000µs 📉 -23.1%) vs baseline: +1.1% Memory: ✅ 43.874MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 89.596µs (SLO: <300.000µs 📉 -70.1%) vs baseline: +0.3% Memory: ✅ 43.953MB (SLO: <46.000MB -4.4%) vs baseline: +5.2% ✅ capitalize_noaspectTime: ✅ 277.643µs (SLO: <300.000µs -7.5%) vs baseline: +7.0% Memory: ✅ 43.847MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 88.924µs (SLO: <500.000µs 📉 -82.2%) vs baseline: -1.3% Memory: ✅ 44.035MB (SLO: <46.000MB -4.3%) vs baseline: +5.3% ✅ casefold_noaspectTime: ✅ 306.042µs (SLO: <500.000µs 📉 -38.8%) vs baseline: -1.0% Memory: ✅ 43.972MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ decode_aspectTime: ✅ 87.304µs (SLO: <100.000µs 📉 -12.7%) vs baseline: +0.3% Memory: ✅ 43.905MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ decode_noaspectTime: ✅ 156.727µs (SLO: <210.000µs 📉 -25.4%) vs baseline: +0.5% Memory: ✅ 43.914MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 84.678µs (SLO: <200.000µs 📉 -57.7%) vs baseline: -0.4% Memory: ✅ 43.875MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ encode_noaspectTime: ✅ 145.988µs (SLO: <200.000µs 📉 -27.0%) vs baseline: +1.0% Memory: ✅ 43.998MB (SLO: <46.000MB -4.4%) vs baseline: +5.5% ✅ format_aspectTime: ✅ 14.617ms (SLO: <19.200ms 📉 -23.9%) vs baseline: +0.2% Memory: ✅ 44.090MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 16.343ms (SLO: <21.500ms 📉 -24.0%) vs baseline: -0.5% Memory: ✅ 43.943MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 358.130µs (SLO: <500.000µs 📉 -28.4%) vs baseline: -5.1% Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 309.303µs (SLO: <500.000µs 📉 -38.1%) vs baseline: -3.6% Memory: ✅ 43.992MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ index_aspectTime: ✅ 128.995µs (SLO: <300.000µs 📉 -57.0%) vs baseline: +0.2% Memory: ✅ 43.832MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 41.010µs (SLO: <300.000µs 📉 -86.3%) vs baseline: +0.3% Memory: ✅ 43.815MB (SLO: <46.000MB -4.8%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 214.320µs (SLO: <300.000µs 📉 -28.6%) vs baseline: -2.9% Memory: ✅ 43.931MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 142.087µs (SLO: <300.000µs 📉 -52.6%) vs baseline: -4.1% Memory: ✅ 43.847MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 504.605µs (SLO: <700.000µs 📉 -27.9%) vs baseline: -2.3% Memory: ✅ 43.835MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 278.892µs (SLO: <300.000µs -7.0%) vs baseline: +5.1% Memory: ✅ 43.891MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ lower_aspectTime: ✅ 311.406µs (SLO: <500.000µs 📉 -37.7%) vs baseline: -0.7% Memory: ✅ 43.920MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ lower_noaspectTime: ✅ 240.705µs (SLO: <300.000µs 📉 -19.8%) vs baseline: -1.9% Memory: ✅ 43.996MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ lstrip_aspectTime: ✅ 0.274ms (SLO: <3.000ms 📉 -90.9%) vs baseline: +1.5% Memory: ✅ 43.939MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ lstrip_noaspectTime: ✅ 0.176ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.7% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 14.255ms (SLO: <18.750ms 📉 -24.0%) vs baseline: +0.2% Memory: ✅ 44.038MB (SLO: <46.000MB -4.3%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.741ms (SLO: <19.350ms 📉 -23.8%) vs baseline: +0.2% Memory: ✅ 44.080MB (SLO: <46.000MB -4.2%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 14.379ms (SLO: <18.900ms 📉 -23.9%) vs baseline: +0.4% Memory: ✅ 44.121MB (SLO: <46.000MB -4.1%) vs baseline: +5.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.607ms (SLO: <19.150ms 📉 -23.7%) vs baseline: +0.4% Memory: ✅ 43.973MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.363ms (SLO: <3.000ms 📉 -87.9%) vs baseline: -1.8% Memory: ✅ 43.912MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 18.376ms (SLO: <24.000ms 📉 -23.4%) vs baseline: -0.2% Memory: ✅ 43.869MB (SLO: <46.000MB -4.6%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 288.898µs (SLO: <400.000µs 📉 -27.8%) vs baseline: +1.2% Memory: ✅ 43.888MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 322.592µs (SLO: <420.000µs 📉 -23.2%) vs baseline: -1.8% Memory: ✅ 43.995MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ repr_noaspectTime: ✅ 46.821µs (SLO: <90.000µs 📉 -48.0%) vs baseline: -1.1% Memory: ✅ 43.941MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 387.827µs (SLO: <500.000µs 📉 -22.4%) vs baseline: -0.4% Memory: ✅ 43.853MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 185.232µs (SLO: <300.000µs 📉 -38.3%) vs baseline: -0.5% Memory: ✅ 44.036MB (SLO: <46.000MB -4.3%) vs baseline: +5.4% ✅ slice_aspectTime: ✅ 182.616µs (SLO: <300.000µs 📉 -39.1%) vs baseline: -2.1% Memory: ✅ 43.972MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ slice_noaspectTime: ✅ 54.255µs (SLO: <90.000µs 📉 -39.7%) vs baseline: -0.7% Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +5.5% ✅ stringio_aspectTime: ✅ 4.615ms (SLO: <5.000ms -7.7%) vs baseline: 📈 +18.0% Memory: ✅ 43.878MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 354.988µs (SLO: <500.000µs 📉 -29.0%) vs baseline: +0.1% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ strip_aspectTime: ✅ 274.797µs (SLO: <350.000µs 📉 -21.5%) vs baseline: +1.6% Memory: ✅ 43.990MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ strip_noaspectTime: ✅ 177.658µs (SLO: <240.000µs 📉 -26.0%) vs baseline: +0.4% Memory: ✅ 43.987MB (SLO: <46.000MB -4.4%) vs baseline: +5.6% ✅ swapcase_aspectTime: ✅ 346.883µs (SLO: <500.000µs 📉 -30.6%) vs baseline: -0.6% Memory: ✅ 43.854MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 274.832µs (SLO: <400.000µs 📉 -31.3%) vs baseline: -1.0% Memory: ✅ 43.888MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 333.920µs (SLO: <500.000µs 📉 -33.2%) vs baseline: -0.4% Memory: ✅ 43.842MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 261.472µs (SLO: <400.000µs 📉 -34.6%) vs baseline: -2.8% Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 508.143µs (SLO: <700.000µs 📉 -27.4%) vs baseline: +0.3% Memory: ✅ 43.895MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ translate_noaspectTime: ✅ 428.839µs (SLO: <500.000µs 📉 -14.2%) vs baseline: -0.9% Memory: ✅ 43.957MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 311.359µs (SLO: <500.000µs 📉 -37.7%) vs baseline: -1.3% Memory: ✅ 43.864MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 238.962µs (SLO: <400.000µs 📉 -40.3%) vs baseline: -2.1% Memory: ✅ 43.963MB (SLO: <46.000MB -4.4%) vs baseline: +5.4% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 525.029µs (SLO: <700.000µs 📉 -25.0%) vs baseline: 📈 +20.0% Memory: ✅ 43.828MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 428.026µs (SLO: <700.000µs 📉 -38.9%) vs baseline: -3.7% Memory: ✅ 43.960MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ ospathjoin_aspectTime: ✅ 632.826µs (SLO: <700.000µs -9.6%) vs baseline: -1.9% Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 637.843µs (SLO: <700.000µs -8.9%) vs baseline: -2.3% Memory: ✅ 43.815MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ ospathnormcase_aspectTime: ✅ 354.375µs (SLO: <700.000µs 📉 -49.4%) vs baseline: -3.9% Memory: ✅ 44.007MB (SLO: <46.000MB -4.3%) vs baseline: +5.5% ✅ ospathnormcase_noaspectTime: ✅ 359.230µs (SLO: <700.000µs 📉 -48.7%) vs baseline: -2.6% Memory: ✅ 43.987MB (SLO: <46.000MB -4.4%) vs baseline: +5.5% ✅ ospathsplit_aspectTime: ✅ 481.979µs (SLO: <700.000µs 📉 -31.1%) vs baseline: -4.9% Memory: ✅ 43.858MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 491.902µs (SLO: <700.000µs 📉 -29.7%) vs baseline: -2.7% Memory: ✅ 43.947MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 371.146µs (SLO: <700.000µs 📉 -47.0%) vs baseline: -4.5% Memory: ✅ 43.871MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 73.076µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.4% Memory: ✅ 43.918MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ ospathsplitext_aspectTime: ✅ 456.673µs (SLO: <700.000µs 📉 -34.8%) vs baseline: -4.8% Memory: ✅ 43.933MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ ospathsplitext_noaspectTime: ✅ 464.907µs (SLO: <700.000µs 📉 -33.6%) vs baseline: -4.3% Memory: ✅ 43.791MB (SLO: <46.000MB -4.8%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.344µs (SLO: <20.000µs 📉 -88.3%) vs baseline: 📈 +13.8% Memory: ✅ 36.569MB (SLO: <38.000MB -3.8%) vs baseline: +5.9% ✅ 1-count-metrics-100-timesTime: ✅ 156.317µs (SLO: <220.000µs 📉 -28.9%) vs baseline: +4.6% Memory: ✅ 36.589MB (SLO: <38.000MB -3.7%) vs baseline: +5.8% ✅ 1-distribution-metric-1-timesTime: ✅ 2.468µs (SLO: <20.000µs 📉 -87.7%) vs baseline: +1.3% Memory: ✅ 36.490MB (SLO: <38.000MB -4.0%) vs baseline: +5.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 170.747µs (SLO: <230.000µs 📉 -25.8%) vs baseline: +3.8% Memory: ✅ 36.510MB (SLO: <38.000MB -3.9%) vs baseline: +5.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.368µs (SLO: <20.000µs 📉 -88.2%) vs baseline: 📈 +20.0% Memory: ✅ 36.589MB (SLO: <38.000MB -3.7%) vs baseline: +6.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 170.146µs (SLO: <190.000µs 📉 -10.4%) vs baseline: 📈 +23.7% Memory: ✅ 36.589MB (SLO: <38.000MB -3.7%) vs baseline: +5.8% ✅ 1-rate-metric-1-timesTime: ✅ 2.265µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +1.0% Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +6.3% ✅ 1-rate-metrics-100-timesTime: ✅ 169.394µs (SLO: <250.000µs 📉 -32.2%) vs baseline: +4.1% Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%) vs baseline: +5.9% ✅ 100-count-metrics-100-timesTime: ✅ 15.670ms (SLO: <22.000ms 📉 -28.8%) vs baseline: +5.0% Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.779ms (SLO: <2.550ms 📉 -30.2%) vs baseline: +3.7% Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +6.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.737ms (SLO: <1.850ms -6.1%) vs baseline: 📈 +22.7% Memory: ✅ 36.176MB (SLO: <38.000MB -4.8%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 1.743ms (SLO: <2.550ms 📉 -31.7%) vs baseline: +4.2% Memory: ✅ 36.078MB (SLO: <38.000MB -5.1%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 3.566µs (SLO: <20.000µs 📉 -82.2%) vs baseline: +1.6% Memory: ✅ 36.608MB (SLO: <38.000MB -3.7%) vs baseline: +5.3% ✅ flush-100-metricsTime: ✅ 174.482µs (SLO: <250.000µs 📉 -30.2%) vs baseline: +0.4% Memory: ✅ 36.589MB (SLO: <38.000MB -3.7%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.184ms (SLO: <2.500ms 📉 -12.6%) vs baseline: +0.1% Memory: ✅ 37.336MB (SLO: <38.750MB -3.6%) vs baseline: +4.7% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 19.677ms (SLO: <22.300ms 📉 -11.8%) vs baseline: +0.2% Memory: ✅ 71.428MB (SLO: <73.500MB -2.8%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.366ms (SLO: <1.450ms -5.8%) vs baseline: -0.2% Memory: ✅ 69.580MB (SLO: <71.500MB -2.7%) vs baseline: +4.9% ✅ iastTime: ✅ 19.670ms (SLO: <22.250ms 📉 -11.6%) vs baseline: -0.1% Memory: ✅ 71.378MB (SLO: <75.000MB -4.8%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.115ms (SLO: <16.550ms -8.7%) vs baseline: -0.6% Memory: ✅ 60.351MB (SLO: <61.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 19.549ms (SLO: <21.750ms 📉 -10.1%) vs baseline: +0.2% Memory: ✅ 71.610MB (SLO: <73.500MB -2.6%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 20.061ms (SLO: <28.200ms 📉 -28.9%) vs baseline: +1.3% Memory: ✅ 71.841MB (SLO: <75.000MB -4.2%) vs baseline: +5.5% ✅ tracerTime: ✅ 19.645ms (SLO: <21.750ms -9.7%) vs baseline: -0.3% Memory: ✅ 71.470MB (SLO: <75.000MB -4.7%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 20.967ms (SLO: <23.500ms 📉 -10.8%) vs baseline: -0.3% Memory: ✅ 73.472MB (SLO: <75.000MB -2.0%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.702ms (SLO: <21.500ms -8.4%) vs baseline: +0.1% Memory: ✅ 71.515MB (SLO: <75.000MB -4.6%) vs baseline: +5.2% ✅ tracer-minimalTime: ✅ 17.833ms (SLO: <18.500ms -3.6%) vs baseline: -0.2% Memory: ✅ 71.424MB (SLO: <75.000MB -4.8%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.842ms (SLO: <19.650ms -4.1%) vs baseline: +0.1% Memory: ✅ 71.415MB (SLO: <75.000MB -4.8%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 20.661ms (SLO: <21.100ms -2.1%) vs baseline: +0.2% Memory: ✅ 71.598MB (SLO: <75.000MB -4.5%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.750ms (SLO: <21.500ms -3.5%) vs baseline: +0.2% Memory: ✅ 71.438MB (SLO: <75.000MB -4.7%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 19.688ms (SLO: <22.000ms 📉 -10.5%) vs baseline: +1.6% Memory: ✅ 71.467MB (SLO: <73.500MB -2.8%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 41.548ms (SLO: <47.150ms 📉 -11.9%) vs baseline: +0.5% Memory: ✅ 41.526MB (SLO: <47.000MB 📉 -11.6%) vs baseline: +5.3% ✅ add-metricsTime: ✅ 233.727ms (SLO: <344.800ms 📉 -32.2%) vs baseline: -0.6% Memory: ✅ 45.365MB (SLO: <47.500MB -4.5%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 264.497ms (SLO: <330.000ms 📉 -19.8%) vs baseline: +0.3% Memory: ✅ 45.488MB (SLO: <47.500MB -4.2%) vs baseline: +5.1% ✅ get-contextTime: ✅ 81.099ms (SLO: <92.350ms 📉 -12.2%) vs baseline: +0.6% Memory: ✅ 41.032MB (SLO: <46.500MB 📉 -11.8%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 37.896ms (SLO: <44.500ms 📉 -14.8%) vs baseline: +0.3% Memory: ✅ 41.055MB (SLO: <47.500MB 📉 -13.6%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 62.666ms (SLO: <67.650ms -7.4%) vs baseline: ~same Memory: ✅ 41.826MB (SLO: <47.000MB 📉 -11.0%) vs baseline: +5.2% ✅ set-statusTime: ✅ 43.483ms (SLO: <50.400ms 📉 -13.7%) vs baseline: ~same Memory: ✅ 40.961MB (SLO: <47.000MB 📉 -12.8%) vs baseline: +5.3% ✅ startTime: ✅ 38.847ms (SLO: <44.500ms 📉 -12.7%) vs baseline: +4.0% Memory: ✅ 40.774MB (SLO: <47.000MB 📉 -13.2%) vs baseline: +4.7% ✅ start-finishTime: ✅ 89.907ms (SLO: <92.000ms -2.3%) vs baseline: ~same Memory: ✅ 38.909MB (SLO: <46.500MB 📉 -16.3%) vs baseline: +5.6% ✅ start-finish-telemetryTime: ✅ 91.639ms (SLO: <93.000ms 🟡 -1.5%) vs baseline: ~same Memory: ✅ 38.909MB (SLO: <46.500MB 📉 -16.3%) vs baseline: +5.7% ✅ update-nameTime: ✅ 39.087ms (SLO: <45.150ms 📉 -13.4%) vs baseline: +0.9% Memory: ✅ 41.069MB (SLO: <47.000MB 📉 -12.6%) vs baseline: +5.6% 🟡 packagesupdateimporteddependencies - 24/24 (1 unstable)✅ import_manyTime: ✅ 168.396µs (SLO: <170.000µs 🟡 -0.9%) vs baseline: -0.6% Memory: ✅ 41.321MB (SLO: <46.000MB 📉 -10.2%) vs baseline: +5.0% ✅ import_many_cachedTime: ✅ 131.599µs (SLO: <170.000µs 📉 -22.6%) vs baseline: -0.2% Memory: ✅ 41.370MB (SLO: <46.000MB 📉 -10.1%) vs baseline: +5.4% ✅ import_many_stdlibTime: ✅ 1.254ms (SLO: <1.750ms 📉 -28.4%) vs baseline: +0.3% Memory: ✅ 41.248MB (SLO: <46.000MB 📉 -10.3%) vs baseline: +5.2%
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
## Description This PR fixes the following crash. ``` Error UnixSignal: Process terminated with SEGV_MAPERR (SIGSEGV) #0 0x00005a87adf31055 dictkeys_get_index (/usr/src/python/Objects/dictobject.c:344:13) #1 0x00005a87adf31055 unicodekeys_lookup_generic (/usr/src/python/Objects/dictobject.c:876:14) #2 0x00005a87adf31055 _Py_dict_lookup (/usr/src/python/Objects/dictobject.c:1056:18) #3 0x00005a87adf31055 PyDict_GetItemWithError (/usr/src/python/Objects/dictobject.c:1789:10) #4 0x00007b2e6fc1a8e0 __pyx_pw_7ddtrace_8internal_9telemetry_18metrics_namespaces_15MetricNamespace_5add_metric #5 0x00005a87ae00c955 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #6 0x00005a87ae00c955 PyObject_Vectorcall (/usr/src/python/Objects/call.c:299:12) #7 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #8 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #9 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #10 0x00005a87ae00d587 PyObject_Call #11 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #12 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #13 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #14 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #15 0x00005a87ae00e0ba _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #16 0x00005a87ae00e0ba method_vectorcall (/usr/src/python/Objects/classobject.c:59:18) #17 0x00005a87ae00c955 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #18 0x00005a87ae00c955 PyObject_Vectorcall (/usr/src/python/Objects/call.c:299:12) #19 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #20 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #21 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #22 0x00005a87ae00d02f _PyFunction_Vectorcall (/usr/src/python/Objects/call.c:393:16) #23 0x00005a87ae00d02f _PyObject_FastCallDictTstate (/usr/src/python/Objects/call.c:141:15) #24 0x00005a87ae00d02f _PyObject_Call_Prepend (/usr/src/python/Objects/call.c:482:24) #25 0x00005a87ae0bafd9 slot_tp_call (/usr/src/python/Objects/typeobject.c:7623:15) #26 0x00005a87ae00c4d9 _PyObject_MakeTpCall (/usr/src/python/Objects/call.c:214:18) #27 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #28 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #29 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #30 0x00005a87ae00d02f _PyFunction_Vectorcall (/usr/src/python/Objects/call.c:393:16) #31 0x00005a87ae00d02f _PyObject_FastCallDictTstate (/usr/src/python/Objects/call.c:141:15) #32 0x00005a87ae00d02f _PyObject_Call_Prepend (/usr/src/python/Objects/call.c:482:24) #33 0x00005a87ae041f7b slot_tp_init (/usr/src/python/Objects/typeobject.c:7854:15) #34 0x00005a87ae040731 type_call (/usr/src/python/Objects/typeobject.c:1103:19) #35 0x00005a87ae00c4d9 _PyObject_MakeTpCall (/usr/src/python/Objects/call.c:214:18) #36 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #37 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #38 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #39 0x00005a87ae00e134 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #40 0x00005a87ae00e134 method_vectorcall (/usr/src/python/Objects/classobject.c:89:18) #41 0x00005a87ae00d587 PyObject_Call #42 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #43 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #44 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #45 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #46 0x00005a87ae00d587 PyObject_Call #47 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #48 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #49 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #50 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #51 0x00005a87ae00e04b _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #52 0x00005a87ae00e04b method_vectorcall (/usr/src/python/Objects/classobject.c:67:20) #53 0x00005a87ae00d587 PyObject_Call #54 0x00005a87ae10e9b3 thread_run (/usr/src/python/./Modules/_threadmodule.c:1124:21) #55 0x00005a87ae0f1098 pythread_wrapper (/usr/src/python/Python/thread_pthread.h:241:5) #56 0x00007b2e71c49609 start_thread #57 0x00007b2e71a14353 clone ``` Co-authored-by: brettlangdon <brett.langdon@datadoghq.com>
## Description This PR fixes the following crash. ``` Error UnixSignal: Process terminated with SEGV_MAPERR (SIGSEGV) #0 0x00005a87adf31055 dictkeys_get_index (/usr/src/python/Objects/dictobject.c:344:13) #1 0x00005a87adf31055 unicodekeys_lookup_generic (/usr/src/python/Objects/dictobject.c:876:14) #2 0x00005a87adf31055 _Py_dict_lookup (/usr/src/python/Objects/dictobject.c:1056:18) #3 0x00005a87adf31055 PyDict_GetItemWithError (/usr/src/python/Objects/dictobject.c:1789:10) #4 0x00007b2e6fc1a8e0 __pyx_pw_7ddtrace_8internal_9telemetry_18metrics_namespaces_15MetricNamespace_5add_metric #5 0x00005a87ae00c955 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #6 0x00005a87ae00c955 PyObject_Vectorcall (/usr/src/python/Objects/call.c:299:12) #7 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #8 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #9 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #10 0x00005a87ae00d587 PyObject_Call #11 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #12 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #13 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #14 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #15 0x00005a87ae00e0ba _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #16 0x00005a87ae00e0ba method_vectorcall (/usr/src/python/Objects/classobject.c:59:18) #17 0x00005a87ae00c955 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #18 0x00005a87ae00c955 PyObject_Vectorcall (/usr/src/python/Objects/call.c:299:12) #19 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #20 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #21 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #22 0x00005a87ae00d02f _PyFunction_Vectorcall (/usr/src/python/Objects/call.c:393:16) #23 0x00005a87ae00d02f _PyObject_FastCallDictTstate (/usr/src/python/Objects/call.c:141:15) #24 0x00005a87ae00d02f _PyObject_Call_Prepend (/usr/src/python/Objects/call.c:482:24) #25 0x00005a87ae0bafd9 slot_tp_call (/usr/src/python/Objects/typeobject.c:7623:15) #26 0x00005a87ae00c4d9 _PyObject_MakeTpCall (/usr/src/python/Objects/call.c:214:18) #27 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #28 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #29 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #30 0x00005a87ae00d02f _PyFunction_Vectorcall (/usr/src/python/Objects/call.c:393:16) #31 0x00005a87ae00d02f _PyObject_FastCallDictTstate (/usr/src/python/Objects/call.c:141:15) #32 0x00005a87ae00d02f _PyObject_Call_Prepend (/usr/src/python/Objects/call.c:482:24) #33 0x00005a87ae041f7b slot_tp_init (/usr/src/python/Objects/typeobject.c:7854:15) #34 0x00005a87ae040731 type_call (/usr/src/python/Objects/typeobject.c:1103:19) #35 0x00005a87ae00c4d9 _PyObject_MakeTpCall (/usr/src/python/Objects/call.c:214:18) #36 0x00005a87ae05ee1d _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:4760:23) #37 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #38 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #39 0x00005a87ae00e134 _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #40 0x00005a87ae00e134 method_vectorcall (/usr/src/python/Objects/classobject.c:89:18) #41 0x00005a87ae00d587 PyObject_Call #42 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #43 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #44 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #45 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #46 0x00005a87ae00d587 PyObject_Call #47 0x00005a87ae061fd8 do_call_core (/usr/src/python/Python/ceval.c:7343:12) #48 0x00005a87ae061fd8 _PyEval_EvalFrameDefault (/usr/src/python/Python/ceval.c:5367:22) #49 0x00005a87ae05e060 _PyEval_EvalFrame (/usr/src/python/./Include/internal/pycore_ceval.h:73:16) #50 0x00005a87ae05e060 _PyEval_Vector (/usr/src/python/Python/ceval.c:6425:24) #51 0x00005a87ae00e04b _PyObject_VectorcallTstate (/usr/src/python/./Include/internal/pycore_call.h:92:11) #52 0x00005a87ae00e04b method_vectorcall (/usr/src/python/Objects/classobject.c:67:20) #53 0x00005a87ae00d587 PyObject_Call #54 0x00005a87ae10e9b3 thread_run (/usr/src/python/./Modules/_threadmodule.c:1124:21) #55 0x00005a87ae0f1098 pythread_wrapper (/usr/src/python/Python/thread_pthread.h:241:5) #56 0x00007b2e71c49609 start_thread #57 0x00007b2e71a14353 clone ``` Co-authored-by: brettlangdon <brett.langdon@datadoghq.com>
Description
This PR fixes the following crash.