fix(internal): do not restart any ThreadRestartTimer threads by brettlangdon · Pull Request #17312 · DataDog/dd-trace-py

brettlangdon · 2026-04-03T17:57:53Z

Description

We have a possible situation where we can end up with orphaned ThreadRestartTimer threads in fork-heavy applications.

If a fork occurs while the current ThreadRestartTimer thread is in the stopping state (after cls._instance = None has already been called) then it will appear in periodic_threads and be added to _threads_to_restart_after_fork and then force restarted.

Testing

Risks

Additional Notes

This bug is really really hard to reproduce and technically shouldn't be possible because the GIL should be held throughout the whole os.fork() call, but this is a code path which could cause some of the crashes we've seen in a fork-heavy application and is an easy defensive guard to add.

pr-commenter · 2026-04-03T18:28:06Z

Performance SLOs

Comparing candidate brettlangdon/fix-potential-thread-leak (0ee1f8e) with baseline main (48788ce)

📈 Performance Regressions (2 suites)

📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 104.976µs (SLO: <130.000µs 📉 -19.2%) vs baseline: +3.3%

Memory: ✅ 43.977MB (SLO: <46.000MB -4.4%) vs baseline: +4.9%

✅ add_inplace_aspect

Time: ✅ 102.016µs (SLO: <130.000µs 📉 -21.5%) vs baseline: -0.6%

Memory: ✅ 43.960MB (SLO: <46.000MB -4.4%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 28.058µs (SLO: <40.000µs 📉 -29.9%) vs baseline: -0.8%

Memory: ✅ 43.895MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

✅ add_noaspect

Time: ✅ 49.413µs (SLO: <70.000µs 📉 -29.4%) vs baseline: -0.4%

Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

✅ bytearray_aspect

Time: ✅ 257.057µs (SLO: <400.000µs 📉 -35.7%) vs baseline: +1.1%

Memory: ✅ 43.932MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%

✅ bytearray_extend_aspect

Time: ✅ 659.487µs (SLO: <800.000µs 📉 -17.6%) vs baseline: -2.1%

Memory: ✅ 44.358MB (SLO: <46.000MB -3.6%) vs baseline: +5.9%

✅ bytearray_extend_noaspect

Time: ✅ 270.402µs (SLO: <400.000µs 📉 -32.4%) vs baseline: +0.3%

Memory: ✅ 44.029MB (SLO: <46.000MB -4.3%) vs baseline: +5.2%

✅ bytearray_noaspect

Time: ✅ 140.878µs (SLO: <300.000µs 📉 -53.0%) vs baseline: -0.6%

Memory: ✅ 43.967MB (SLO: <46.000MB -4.4%) vs baseline: +4.8%

✅ bytes_aspect

Time: ✅ 221.443µs (SLO: <300.000µs 📉 -26.2%) vs baseline: -0.9%

Memory: ✅ 44.189MB (SLO: <46.000MB -3.9%) vs baseline: +5.6%

✅ bytes_noaspect

Time: ✅ 134.217µs (SLO: <200.000µs 📉 -32.9%) vs baseline: +0.7%

Memory: ✅ 43.541MB (SLO: <46.000MB -5.3%) vs baseline: +3.8%

✅ bytesio_aspect

Time: ✅ 3.790ms (SLO: <5.000ms 📉 -24.2%) vs baseline: -0.6%

Memory: ✅ 43.969MB (SLO: <46.000MB -4.4%) vs baseline: +4.6%

✅ bytesio_noaspect

Time: ✅ 316.863µs (SLO: <420.000µs 📉 -24.6%) vs baseline: ~same

Memory: ✅ 43.692MB (SLO: <46.000MB -5.0%) vs baseline: +4.3%

✅ capitalize_aspect

Time: ✅ 89.949µs (SLO: <300.000µs 📉 -70.0%) vs baseline: -0.4%

Memory: ✅ 43.690MB (SLO: <46.000MB -5.0%) vs baseline: +4.1%

✅ capitalize_noaspect

Time: ✅ 249.102µs (SLO: <300.000µs 📉 -17.0%) vs baseline: -0.2%

Memory: ✅ 43.993MB (SLO: <46.000MB -4.4%) vs baseline: +5.1%

✅ casefold_aspect

Time: ✅ 93.848µs (SLO: <500.000µs 📉 -81.2%) vs baseline: +4.3%

Memory: ✅ 44.018MB (SLO: <46.000MB -4.3%) vs baseline: +4.6%

✅ casefold_noaspect

Time: ✅ 309.937µs (SLO: <500.000µs 📉 -38.0%) vs baseline: +1.9%

Memory: ✅ 43.631MB (SLO: <46.000MB -5.1%) vs baseline: +4.4%

✅ decode_aspect

Time: ✅ 86.391µs (SLO: <100.000µs 📉 -13.6%) vs baseline: -0.4%

Memory: ✅ 43.868MB (SLO: <46.000MB -4.6%) vs baseline: +5.1%

✅ decode_noaspect

Time: ✅ 152.999µs (SLO: <210.000µs 📉 -27.1%) vs baseline: +0.3%

Memory: ✅ 43.791MB (SLO: <46.000MB -4.8%) vs baseline: +4.4%

✅ encode_aspect

Time: ✅ 84.365µs (SLO: <200.000µs 📉 -57.8%) vs baseline: -0.7%

Memory: ✅ 43.972MB (SLO: <46.000MB -4.4%) vs baseline: +5.6%

✅ encode_noaspect

Time: ✅ 142.689µs (SLO: <200.000µs 📉 -28.7%) vs baseline: +0.7%

Memory: ✅ 43.759MB (SLO: <46.000MB -4.9%) vs baseline: +4.7%

✅ format_aspect

Time: ✅ 14.635ms (SLO: <19.200ms 📉 -23.8%) vs baseline: +0.3%

Memory: ✅ 43.984MB (SLO: <46.000MB -4.4%) vs baseline: +5.1%

✅ format_map_aspect

Time: ✅ 16.412ms (SLO: <21.500ms 📉 -23.7%) vs baseline: ~same

Memory: ✅ 43.732MB (SLO: <46.000MB -4.9%) vs baseline: +3.9%

✅ format_map_noaspect

Time: ✅ 376.238µs (SLO: <500.000µs 📉 -24.8%) vs baseline: -1.7%

Memory: ✅ 43.935MB (SLO: <46.000MB -4.5%) vs baseline: +4.9%

✅ format_noaspect

Time: ✅ 313.550µs (SLO: <500.000µs 📉 -37.3%) vs baseline: +1.0%

Memory: ✅ 43.676MB (SLO: <46.000MB -5.1%) vs baseline: +4.1%

✅ index_aspect

Time: ✅ 125.624µs (SLO: <300.000µs 📉 -58.1%) vs baseline: ~same

Memory: ✅ 44.152MB (SLO: <46.000MB -4.0%) vs baseline: +5.4%

✅ index_noaspect

Time: ✅ 40.146µs (SLO: <300.000µs 📉 -86.6%) vs baseline: -0.7%

Memory: ✅ 43.818MB (SLO: <46.000MB -4.7%) vs baseline: +4.6%

✅ join_aspect

Time: ✅ 214.336µs (SLO: <300.000µs 📉 -28.6%) vs baseline: -1.6%

Memory: ✅ 44.027MB (SLO: <46.000MB -4.3%) vs baseline: +5.0%

✅ join_noaspect

Time: ✅ 144.460µs (SLO: <300.000µs 📉 -51.8%) vs baseline: +0.2%

Memory: ✅ 43.866MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

✅ ljust_aspect

Time: ✅ 504.435µs (SLO: <700.000µs 📉 -27.9%) vs baseline: -0.7%

Memory: ✅ 44.072MB (SLO: <46.000MB -4.2%) vs baseline: +5.3%

✅ ljust_noaspect

Time: ✅ 259.688µs (SLO: <300.000µs 📉 -13.4%) vs baseline: -0.5%

Memory: ✅ 43.699MB (SLO: <46.000MB -5.0%) vs baseline: +4.2%

✅ lower_aspect

Time: ✅ 294.927µs (SLO: <500.000µs 📉 -41.0%) vs baseline: -2.8%

Memory: ✅ 44.088MB (SLO: <46.000MB -4.2%) vs baseline: +5.2%

✅ lower_noaspect

Time: ✅ 235.947µs (SLO: <300.000µs 📉 -21.4%) vs baseline: +0.1%

Memory: ✅ 43.703MB (SLO: <46.000MB -5.0%) vs baseline: +4.5%

✅ lstrip_aspect

Time: ✅ 0.357ms (SLO: <3.000ms 📉 -88.1%) vs baseline: 📈 +28.6%

Memory: ✅ 43.810MB (SLO: <46.000MB -4.8%) vs baseline: +5.4%

✅ lstrip_noaspect

Time: ✅ 0.176ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.9%

Memory: ✅ 43.728MB (SLO: <46.000MB -4.9%) vs baseline: +4.2%

✅ modulo_aspect

Time: ✅ 14.345ms (SLO: <18.750ms 📉 -23.5%) vs baseline: +0.1%

Memory: ✅ 43.999MB (SLO: <46.000MB -4.3%) vs baseline: +4.9%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 14.840ms (SLO: <19.350ms 📉 -23.3%) vs baseline: +0.3%

Memory: ✅ 43.973MB (SLO: <46.000MB -4.4%) vs baseline: +4.4%

✅ modulo_aspect_for_bytes

Time: ✅ 14.351ms (SLO: <18.900ms 📉 -24.1%) vs baseline: -0.4%

Memory: ✅ 43.975MB (SLO: <46.000MB -4.4%) vs baseline: +5.0%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 14.603ms (SLO: <19.150ms 📉 -23.7%) vs baseline: -0.1%

Memory: ✅ 44.103MB (SLO: <46.000MB -4.1%) vs baseline: +5.5%

✅ modulo_noaspect

Time: ✅ 0.361ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -1.0%

Memory: ✅ 43.667MB (SLO: <46.000MB -5.1%) vs baseline: +4.2%

✅ replace_aspect

Time: ✅ 18.421ms (SLO: <24.000ms 📉 -23.2%) vs baseline: +0.3%

Memory: ✅ 43.998MB (SLO: <46.000MB -4.4%) vs baseline: +4.6%

✅ replace_noaspect

Time: ✅ 279.967µs (SLO: <400.000µs 📉 -30.0%) vs baseline: +0.4%

Memory: ✅ 43.821MB (SLO: <46.000MB -4.7%) vs baseline: +4.5%

✅ repr_aspect

Time: ✅ 322.812µs (SLO: <420.000µs 📉 -23.1%) vs baseline: +1.2%

Memory: ✅ 44.080MB (SLO: <46.000MB -4.2%) vs baseline: +5.1%

✅ repr_noaspect

Time: ✅ 46.752µs (SLO: <90.000µs 📉 -48.1%) vs baseline: ~same

Memory: ✅ 43.826MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%

✅ rstrip_aspect

Time: ✅ 385.849µs (SLO: <500.000µs 📉 -22.8%) vs baseline: -1.4%

Memory: ✅ 43.881MB (SLO: <46.000MB -4.6%) vs baseline: +5.2%

✅ rstrip_noaspect

Time: ✅ 185.058µs (SLO: <300.000µs 📉 -38.3%) vs baseline: -0.2%

Memory: ✅ 43.754MB (SLO: <46.000MB -4.9%) vs baseline: +4.4%

✅ slice_aspect

Time: ✅ 184.221µs (SLO: <300.000µs 📉 -38.6%) vs baseline: -0.2%

Memory: ✅ 44.041MB (SLO: <46.000MB -4.3%) vs baseline: +5.0%

✅ slice_noaspect

Time: ✅ 53.894µs (SLO: <90.000µs 📉 -40.1%) vs baseline: -0.2%

Memory: ✅ 43.680MB (SLO: <46.000MB -5.0%) vs baseline: +4.1%

✅ stringio_aspect

Time: ✅ 3.824ms (SLO: <5.000ms 📉 -23.5%) vs baseline: -0.7%

Memory: ✅ 44.039MB (SLO: <46.000MB -4.3%) vs baseline: +5.1%

✅ stringio_noaspect

Time: ✅ 350.680µs (SLO: <500.000µs 📉 -29.9%) vs baseline: -0.5%

Memory: ✅ 43.684MB (SLO: <46.000MB -5.0%) vs baseline: +4.2%

✅ strip_aspect

Time: ✅ 277.423µs (SLO: <350.000µs 📉 -20.7%) vs baseline: -1.2%

Memory: ✅ 44.138MB (SLO: <46.000MB -4.0%) vs baseline: +5.0%

✅ strip_noaspect

Time: ✅ 179.453µs (SLO: <240.000µs 📉 -25.2%) vs baseline: +0.8%

Memory: ✅ 43.683MB (SLO: <46.000MB -5.0%) vs baseline: +3.9%

✅ swapcase_aspect

Time: ✅ 333.168µs (SLO: <500.000µs 📉 -33.4%) vs baseline: -0.6%

Memory: ✅ 44.001MB (SLO: <46.000MB -4.3%) vs baseline: +4.7%

✅ swapcase_noaspect

Time: ✅ 271.171µs (SLO: <400.000µs 📉 -32.2%) vs baseline: +1.0%

Memory: ✅ 43.702MB (SLO: <46.000MB -5.0%) vs baseline: +4.4%

✅ title_aspect

Time: ✅ 319.164µs (SLO: <500.000µs 📉 -36.2%) vs baseline: -0.5%

Memory: ✅ 44.093MB (SLO: <46.000MB -4.1%) vs baseline: +5.3%

✅ title_noaspect

Time: ✅ 258.108µs (SLO: <400.000µs 📉 -35.5%) vs baseline: +0.6%

Memory: ✅ 43.791MB (SLO: <46.000MB -4.8%) vs baseline: +4.4%

✅ translate_aspect

Time: ✅ 496.600µs (SLO: <700.000µs 📉 -29.1%) vs baseline: -1.4%

Memory: ✅ 43.912MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%

✅ translate_noaspect

Time: ✅ 426.180µs (SLO: <500.000µs 📉 -14.8%) vs baseline: -1.9%

Memory: ✅ 43.978MB (SLO: <46.000MB -4.4%) vs baseline: +4.9%

✅ upper_aspect

Time: ✅ 296.411µs (SLO: <500.000µs 📉 -40.7%) vs baseline: -0.4%

Memory: ✅ 44.117MB (SLO: <46.000MB -4.1%) vs baseline: +5.1%

✅ upper_noaspect

Time: ✅ 237.082µs (SLO: <400.000µs 📉 -40.7%) vs baseline: +0.5%

Memory: ✅ 43.752MB (SLO: <46.000MB -4.9%) vs baseline: +4.5%

📈 iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 519.304µs (SLO: <700.000µs 📉 -25.8%) vs baseline: 📈 +23.5%

Memory: ✅ 43.794MB (SLO: <46.000MB -4.8%) vs baseline: +4.7%

✅ ospathbasename_noaspect

Time: ✅ 426.423µs (SLO: <700.000µs 📉 -39.1%) vs baseline: ~same

Memory: ✅ 44.029MB (SLO: <46.000MB -4.3%) vs baseline: +5.1%

✅ ospathjoin_aspect

Time: ✅ 626.692µs (SLO: <700.000µs 📉 -10.5%) vs baseline: +0.4%

Memory: ✅ 43.940MB (SLO: <46.000MB -4.5%) vs baseline: +4.9%

✅ ospathjoin_noaspect

Time: ✅ 631.470µs (SLO: <700.000µs -9.8%) vs baseline: ~same

Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +5.2%

✅ ospathnormcase_aspect

Time: ✅ 350.738µs (SLO: <700.000µs 📉 -49.9%) vs baseline: -0.6%

Memory: ✅ 43.973MB (SLO: <46.000MB -4.4%) vs baseline: +5.2%

✅ ospathnormcase_noaspect

Time: ✅ 357.104µs (SLO: <700.000µs 📉 -49.0%) vs baseline: -0.5%

Memory: ✅ 43.913MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%

✅ ospathsplit_aspect

Time: ✅ 486.307µs (SLO: <700.000µs 📉 -30.5%) vs baseline: -0.1%

Memory: ✅ 43.965MB (SLO: <46.000MB -4.4%) vs baseline: +5.5%

✅ ospathsplit_noaspect

Time: ✅ 499.336µs (SLO: <700.000µs 📉 -28.7%) vs baseline: +0.9%

Memory: ✅ 43.925MB (SLO: <46.000MB -4.5%) vs baseline: +5.1%

✅ ospathsplitdrive_aspect

Time: ✅ 374.393µs (SLO: <700.000µs 📉 -46.5%) vs baseline: +0.5%

Memory: ✅ 43.884MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

✅ ospathsplitdrive_noaspect

Time: ✅ 73.446µs (SLO: <700.000µs 📉 -89.5%) vs baseline: +0.9%

Memory: ✅ 43.743MB (SLO: <46.000MB -4.9%) vs baseline: +4.6%

✅ ospathsplitext_aspect

Time: ✅ 456.369µs (SLO: <700.000µs 📉 -34.8%) vs baseline: +0.4%

Memory: ✅ 43.881MB (SLO: <46.000MB -4.6%) vs baseline: +4.5%

✅ ospathsplitext_noaspect

Time: ✅ 464.274µs (SLO: <700.000µs 📉 -33.7%) vs baseline: +0.7%

Memory: ✅ 43.917MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%

🟡 Near SLO Breach (2 suites)

🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 19.712ms (SLO: <22.300ms 📉 -11.6%) vs baseline: ~same

Memory: ✅ 69.560MB (SLO: <73.500MB -5.4%) vs baseline: +5.0%

✅ exception-replay-enabled

Time: ✅ 1.327ms (SLO: <1.450ms -8.5%) vs baseline: -0.2%

Memory: ✅ 67.692MB (SLO: <71.500MB -5.3%) vs baseline: +4.9%

✅ iast

Time: ✅ 19.653ms (SLO: <22.250ms 📉 -11.7%) vs baseline: -0.4%

Memory: ✅ 69.442MB (SLO: <75.000MB -7.4%) vs baseline: +4.7%

✅ profiler

Time: ✅ 15.155ms (SLO: <16.550ms -8.4%) vs baseline: +1.0%

Memory: ✅ 60.490MB (SLO: <61.000MB 🟡 -0.8%) vs baseline: +4.8%

✅ resource-renaming

Time: ✅ 19.640ms (SLO: <21.750ms -9.7%) vs baseline: -0.1%

Memory: ✅ 69.501MB (SLO: <73.500MB -5.4%) vs baseline: +4.8%

✅ span-code-origin

Time: ✅ 20.320ms (SLO: <28.200ms 📉 -27.9%) vs baseline: +1.9%

Memory: ✅ 69.511MB (SLO: <75.000MB -7.3%) vs baseline: +4.8%

✅ tracer

Time: ✅ 19.711ms (SLO: <21.750ms -9.4%) vs baseline: ~same

Memory: ✅ 69.580MB (SLO: <75.000MB -7.2%) vs baseline: +4.9%

✅ tracer-and-profiler

Time: ✅ 21.163ms (SLO: <23.500ms -9.9%) vs baseline: +0.6%

Memory: ✅ 71.457MB (SLO: <75.000MB -4.7%) vs baseline: +4.8%

✅ tracer-dont-create-db-spans

Time: ✅ 19.917ms (SLO: <21.500ms -7.4%) vs baseline: +0.5%

Memory: ✅ 69.521MB (SLO: <75.000MB -7.3%) vs baseline: +4.8%

✅ tracer-minimal

Time: ✅ 16.857ms (SLO: <17.500ms -3.7%) vs baseline: -0.1%

Memory: ✅ 69.560MB (SLO: <75.000MB -7.3%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 19.715ms (SLO: <21.750ms -9.4%) vs baseline: ~same

Memory: ✅ 69.511MB (SLO: <72.500MB -4.1%) vs baseline: +4.8%

✅ tracer-no-caches

Time: ✅ 17.680ms (SLO: <19.650ms 📉 -10.0%) vs baseline: ~same

Memory: ✅ 69.521MB (SLO: <75.000MB -7.3%) vs baseline: +4.9%

✅ tracer-no-databases

Time: ✅ 19.268ms (SLO: <20.100ms -4.1%) vs baseline: -0.5%

Memory: ✅ 69.560MB (SLO: <75.000MB -7.3%) vs baseline: +4.9%

✅ tracer-no-middleware

Time: ✅ 19.455ms (SLO: <21.500ms -9.5%) vs baseline: -0.2%

Memory: ✅ 69.491MB (SLO: <75.000MB -7.3%) vs baseline: +4.9%

✅ tracer-no-templates

Time: ✅ 19.734ms (SLO: <22.000ms 📉 -10.3%) vs baseline: +0.4%

Memory: ✅ 69.493MB (SLO: <73.500MB -5.5%) vs baseline: +4.8%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 3.391ms (SLO: <4.750ms 📉 -28.6%) vs baseline: +0.5%

Memory: ✅ 56.649MB (SLO: <66.500MB 📉 -14.8%) vs baseline: +4.9%

✅ appsec-post

Time: ✅ 2.874ms (SLO: <6.750ms 📉 -57.4%) vs baseline: ~same

Memory: ✅ 56.588MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +4.8%

✅ appsec-telemetry

Time: ✅ 3.370ms (SLO: <4.750ms 📉 -29.0%) vs baseline: ~same

Memory: ✅ 56.631MB (SLO: <66.500MB 📉 -14.8%) vs baseline: +5.0%

✅ debugger

Time: ✅ 1.881ms (SLO: <2.000ms -5.9%) vs baseline: ~same

Memory: ✅ 49.352MB (SLO: <51.500MB -4.2%) vs baseline: +4.9%

✅ iast-get

Time: ✅ 1.871ms (SLO: <2.000ms -6.5%) vs baseline: ~same

Memory: ✅ 46.109MB (SLO: <49.000MB -5.9%) vs baseline: +4.9%

✅ profiler

Time: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: -0.2%

Memory: ✅ 52.439MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.9%

✅ resource-renaming

Time: ✅ 3.344ms (SLO: <3.650ms -8.4%) vs baseline: -0.6%

Memory: ✅ 56.630MB (SLO: <60.000MB -5.6%) vs baseline: +4.9%

✅ tracer

Time: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: +0.3%

Memory: ✅ 56.588MB (SLO: <60.000MB -5.7%) vs baseline: +4.8%

✅ tracer-native

Time: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: -0.1%

Memory: ✅ 56.686MB (SLO: <60.000MB -5.5%) vs baseline: +4.9%

⚠️ Unstable Tests (2 suites)

⚠️

coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.643µs (SLO: <20.000µs 📉 -31.8%) vs baseline: ~same

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.8%

✅ context_with_data_no_listeners

Time: ✅ 3.643µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +0.6%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.1%

✅ get_item_exists

Time: ✅ 0.588µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.4%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.5%

✅ get_item_missing

Time: ✅ 0.646µs (SLO: <10.000µs 📉 -93.5%) vs baseline: +0.7%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.8%

✅ set_item

Time: ✅ 24.440µs (SLO: <30.000µs 📉 -18.5%) vs baseline: -0.5%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.6%

⚠️

packagesupdateimporteddependencies - 24/24 (1 unstable)

✅ import_many

Time: ✅ 156.397µs (SLO: <170.000µs -8.0%) vs baseline: +0.6%

Memory: ✅ 41.311MB (SLO: <46.000MB 📉 -10.2%) vs baseline: +5.2%

✅ import_many_cached

Time: ✅ 121.427µs (SLO: <130.000µs -6.6%) vs baseline: +0.2%

Memory: ✅ 41.367MB (SLO: <46.000MB 📉 -10.1%) vs baseline: +4.9%

✅ import_many_stdlib

Time: ✅ 0.807ms (SLO: <1.750ms 📉 -53.9%) vs baseline: +1.2%

Memory: ✅ 41.212MB (SLO: <46.000MB 📉 -10.4%) vs baseline: +5.0%

⚠️ import_many_stdlib_cached

Time: ⚠️ 0.186ms (SLO: <1.100ms 📉 -83.0%) vs baseline: ~same

Memory: ✅ 40.941MB (SLO: <46.000MB 📉 -11.0%) vs baseline: +4.6%

✅ import_many_unknown

Time: ✅ 828.107µs (SLO: <890.000µs -7.0%) vs baseline: -0.8%

Memory: ✅ 41.337MB (SLO: <46.000MB 📉 -10.1%) vs baseline: +4.8%

✅ import_many_unknown_cached

Time: ✅ 792.326µs (SLO: <870.000µs -8.9%) vs baseline: -0.6%

Memory: ✅ 41.388MB (SLO: <46.000MB 📉 -10.0%) vs baseline: +4.8%

✅ import_one

Time: ✅ 19.985µs (SLO: <30.000µs 📉 -33.4%) vs baseline: +1.2%

Memory: ✅ 41.113MB (SLO: <46.000MB 📉 -10.6%) vs baseline: +4.4%

✅ import_one_cache

Time: ✅ 6.280µs (SLO: <10.000µs 📉 -37.2%) vs baseline: -0.2%

Memory: ✅ 41.166MB (SLO: <46.000MB 📉 -10.5%) vs baseline: +5.4%

✅ import_one_stdlib

Time: ✅ 18.767µs (SLO: <20.000µs -6.2%) vs baseline: ~same

Memory: ✅ 41.275MB (SLO: <46.000MB 📉 -10.3%) vs baseline: +5.4%

✅ import_one_stdlib_cache

Time: ✅ 6.315µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.7%

Memory: ✅ 41.230MB (SLO: <46.000MB 📉 -10.4%) vs baseline: +5.3%

✅ import_one_unknown

Time: ✅ 45.382µs (SLO: <50.000µs -9.2%) vs baseline: -0.4%

Memory: ✅ 41.159MB (SLO: <46.000MB 📉 -10.5%) vs baseline: +4.6%

✅ import_one_unknown_cache

Time: ✅ 6.349µs (SLO: <10.000µs 📉 -36.5%) vs baseline: +1.4%

Memory: ✅ 41.112MB (SLO: <43.000MB -4.4%) vs baseline: +4.3%

✅ All Tests Passing (20 suites)

✅ codeprovenancefork - 2/2

✅ fork-10

Time: ✅ 2.176s (SLO: <2.300s -5.4%) vs baseline: +1.9%

Memory: ✅ 17.439MB (SLO: <20.000MB 📉 -12.8%) vs baseline: +5.1%

✅ errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 16.466ms (SLO: <19.850ms 📉 -17.0%) vs baseline: +0.2%

Memory: ✅ 69.127MB (SLO: <75.000MB -7.8%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 16.432ms (SLO: <19.400ms 📉 -15.3%) vs baseline: ~same

Memory: ✅ 69.088MB (SLO: <75.000MB -7.9%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 16.419ms (SLO: <19.450ms 📉 -15.6%) vs baseline: -0.2%

Memory: ✅ 69.145MB (SLO: <75.000MB -7.8%) vs baseline: +4.9%

✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.094ms (SLO: <2.300ms -9.0%) vs baseline: -0.1%

Memory: ✅ 56.374MB (SLO: <60.000MB -6.0%) vs baseline: +4.9%

✅ errortracking-enabled-user

Time: ✅ 2.100ms (SLO: <2.250ms -6.7%) vs baseline: -0.2%

Memory: ✅ 56.227MB (SLO: <60.000MB -6.3%) vs baseline: +4.7%

✅ tracer-enabled

Time: ✅ 2.094ms (SLO: <2.300ms -9.0%) vs baseline: ~same

Memory: ✅ 56.233MB (SLO: <60.000MB -6.3%) vs baseline: +4.7%

✅ flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 2.090ms (SLO: <4.200ms 📉 -50.2%) vs baseline: +0.2%

Memory: ✅ 56.419MB (SLO: <66.000MB 📉 -14.5%) vs baseline: +4.8%

✅ iast-enabled

Time: ✅ 2.102ms (SLO: <2.800ms 📉 -24.9%) vs baseline: +0.5%

Memory: ✅ 56.445MB (SLO: <62.500MB -9.7%) vs baseline: +5.0%

✅ tracer-enabled

Time: ✅ 2.087ms (SLO: <2.250ms -7.3%) vs baseline: ~same

Memory: ✅ 56.451MB (SLO: <60.000MB -5.9%) vs baseline: +4.8%

✅ forktime - 4/4

✅ baseline

Time: ✅ 1.938ms (SLO: <3.000ms 📉 -35.4%) vs baseline: +4.5%

Memory: ✅ 29.236MB (SLO: <33.000MB 📉 -11.4%) vs baseline: +4.9%

✅ configured

Time: ✅ 8.782ms (SLO: <13.000ms 📉 -32.4%) vs baseline: -0.3%

Memory: ✅ 56.530MB (SLO: <60.000MB -5.8%) vs baseline: +4.7%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 80.427µs (SLO: <100.000µs 📉 -19.6%) vs baseline: +4.9%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.1%

✅ b3_headers

Time: ✅ 12.727µs (SLO: <20.000µs 📉 -36.4%) vs baseline: -0.9%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%

✅ b3_single_headers

Time: ✅ 11.872µs (SLO: <20.000µs 📉 -40.6%) vs baseline: -0.8%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.1%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 60.561µs (SLO: <80.000µs 📉 -24.3%) vs baseline: +0.4%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.7%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 63.506µs (SLO: <80.000µs 📉 -20.6%) vs baseline: ~same

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ empty_headers

Time: ✅ 1.311µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.2%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%

✅ full_t_id_datadog_headers

Time: ✅ 21.590µs (SLO: <30.000µs 📉 -28.0%) vs baseline: -0.2%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +5.0%

✅ invalid_priority_header

Time: ✅ 5.917µs (SLO: <10.000µs 📉 -40.8%) vs baseline: +0.1%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%

✅ invalid_span_id_header

Time: ✅ 5.898µs (SLO: <10.000µs 📉 -41.0%) vs baseline: -0.1%

Memory: ✅ 36.431MB (SLO: <38.000MB -4.1%) vs baseline: +5.0%

✅ invalid_tags_header

Time: ✅ 5.899µs (SLO: <10.000µs 📉 -41.0%) vs baseline: -0.2%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ invalid_trace_id_header

Time: ✅ 5.860µs (SLO: <10.000µs 📉 -41.4%) vs baseline: -1.1%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.8%

✅ large_header_no_matches

Time: ✅ 27.379µs (SLO: <30.000µs -8.7%) vs baseline: +0.3%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +5.0%

✅ large_valid_headers_all

Time: ✅ 28.481µs (SLO: <40.000µs 📉 -28.8%) vs baseline: -0.2%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.7%

✅ medium_header_no_matches

Time: ✅ 9.230µs (SLO: <20.000µs 📉 -53.8%) vs baseline: +0.3%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%

✅ medium_valid_headers_all

Time: ✅ 10.817µs (SLO: <20.000µs 📉 -45.9%) vs baseline: +0.2%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.7%

✅ none_propagation_style

Time: ✅ 1.396µs (SLO: <10.000µs 📉 -86.0%) vs baseline: -0.5%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.9%

✅ tracecontext_headers

Time: ✅ 32.499µs (SLO: <40.000µs 📉 -18.8%) vs baseline: -0.6%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.9%

✅ valid_headers_all

Time: ✅ 5.919µs (SLO: <10.000µs 📉 -40.8%) vs baseline: +0.1%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.1%

✅ valid_headers_basic

Time: ✅ 5.517µs (SLO: <10.000µs 📉 -44.8%) vs baseline: ~same

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.3%

✅ wsgi_empty_headers

Time: ✅ 1.312µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.7%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%

✅ wsgi_invalid_priority_header

Time: ✅ 5.965µs (SLO: <10.000µs 📉 -40.4%) vs baseline: -0.5%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.310µs (SLO: <10.000µs 📉 -86.9%) vs baseline: ~same

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%

✅ wsgi_invalid_tags_header

Time: ✅ 5.951µs (SLO: <10.000µs 📉 -40.5%) vs baseline: +0.3%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +5.1%

✅ wsgi_invalid_trace_id_header

Time: ✅ 5.932µs (SLO: <10.000µs 📉 -40.7%) vs baseline: +0.1%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ wsgi_large_header_no_matches

Time: ✅ 28.689µs (SLO: <40.000µs 📉 -28.3%) vs baseline: +0.8%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +5.0%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.780µs (SLO: <40.000µs 📉 -25.6%) vs baseline: +0.4%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.4%

✅ wsgi_medium_header_no_matches

Time: ✅ 9.511µs (SLO: <20.000µs 📉 -52.4%) vs baseline: +0.5%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.5%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.034µs (SLO: <20.000µs 📉 -44.8%) vs baseline: +1.0%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.1%

✅ wsgi_valid_headers_all

Time: ✅ 5.927µs (SLO: <10.000µs 📉 -40.7%) vs baseline: -0.4%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.0%

✅ wsgi_valid_headers_basic

Time: ✅ 5.517µs (SLO: <10.000µs 📉 -44.8%) vs baseline: +0.5%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.8%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.111µs (SLO: <30.000µs 📉 -29.6%) vs baseline: +4.4%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%

✅ with_all

Time: ✅ 27.076µs (SLO: <40.000µs 📉 -32.3%) vs baseline: ~same

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.7%

✅ with_dd_origin

Time: ✅ 24.062µs (SLO: <30.000µs 📉 -19.8%) vs baseline: ~same

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.0%

✅ with_priority_and_origin

Time: ✅ 23.577µs (SLO: <40.000µs 📉 -41.1%) vs baseline: +0.8%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.7%

✅ with_sampling_priority

Time: ✅ 20.206µs (SLO: <30.000µs 📉 -32.6%) vs baseline: +0.2%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%

✅ with_tags

Time: ✅ 25.321µs (SLO: <40.000µs 📉 -36.7%) vs baseline: +0.3%

Memory: ✅ 36.412MB (SLO: <38.000MB -4.2%) vs baseline: +4.8%

✅ with_tags_invalid

Time: ✅ 26.533µs (SLO: <40.000µs 📉 -33.7%) vs baseline: -0.3%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ with_tags_max_size

Time: ✅ 25.827µs (SLO: <40.000µs 📉 -35.4%) vs baseline: +1.3%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.9%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 168.302µs (SLO: <250.000µs 📉 -32.7%) vs baseline: +9.8%

Memory: ✅ 44.031MB (SLO: <46.000MB -4.3%) vs baseline: +5.2%

✅ rsplit_noaspect

Time: ✅ 157.131µs (SLO: <250.000µs 📉 -37.1%) vs baseline: -1.0%

Memory: ✅ 43.882MB (SLO: <46.000MB -4.6%) vs baseline: +4.6%

✅ split_aspect

Time: ✅ 152.438µs (SLO: <250.000µs 📉 -39.0%) vs baseline: -0.2%

Memory: ✅ 43.896MB (SLO: <46.000MB -4.6%) vs baseline: +4.7%

✅ split_noaspect

Time: ✅ 158.483µs (SLO: <250.000µs 📉 -36.6%) vs baseline: +0.2%

Memory: ✅ 43.884MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

✅ splitlines_aspect

Time: ✅ 152.833µs (SLO: <250.000µs 📉 -38.9%) vs baseline: +0.5%

Memory: ✅ 43.981MB (SLO: <46.000MB -4.4%) vs baseline: +5.1%

✅ splitlines_noaspect

Time: ✅ 155.800µs (SLO: <250.000µs 📉 -37.7%) vs baseline: -1.4%

Memory: ✅ 43.854MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%

✅ iastpropagation - 8/8

✅ no-propagation

Time: ✅ 48.166µs (SLO: <60.000µs 📉 -19.7%) vs baseline: -0.8%

Memory: ✅ 40.128MB (SLO: <42.000MB -4.5%) vs baseline: +4.9%

✅ propagation_enabled

Time: ✅ 136.371µs (SLO: <190.000µs 📉 -28.2%) vs baseline: ~same

Memory: ✅ 40.128MB (SLO: <42.000MB -4.5%) vs baseline: +4.6%

✅ propagation_enabled_100

Time: ✅ 1.569ms (SLO: <2.300ms 📉 -31.8%) vs baseline: -0.2%

Memory: ✅ 40.128MB (SLO: <42.000MB -4.5%) vs baseline: +4.7%

✅ propagation_enabled_1000

Time: ✅ 29.357ms (SLO: <34.550ms 📉 -15.0%) vs baseline: -0.4%

Memory: ✅ 40.108MB (SLO: <42.000MB -4.5%) vs baseline: +4.6%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.455ms (SLO: <42.000ms -3.7%) vs baseline: +0.1%

Memory: ✅ 39.046MB (SLO: <40.750MB -4.2%) vs baseline: +4.6%

✅ add-link

Time: ✅ 36.525ms (SLO: <38.550ms -5.3%) vs baseline: +0.5%

Memory: ✅ 39.105MB (SLO: <40.750MB -4.0%) vs baseline: +4.8%

✅ add-metrics

Time: ✅ 219.519ms (SLO: <232.000ms -5.4%) vs baseline: +0.8%

Memory: ✅ 39.282MB (SLO: <40.750MB -3.6%) vs baseline: +5.3%

✅ add-tags

Time: ✅ 211.533ms (SLO: <221.600ms -4.5%) vs baseline: ~same

Memory: ✅ 39.086MB (SLO: <40.750MB -4.1%) vs baseline: +4.7%

✅ get-context

Time: ✅ 29.070ms (SLO: <31.300ms -7.1%) vs baseline: -0.8%

Memory: ✅ 39.164MB (SLO: <40.750MB -3.9%) vs baseline: +4.8%

✅ is-recording

Time: ✅ 29.252ms (SLO: <31.000ms -5.6%) vs baseline: +0.2%

Memory: ✅ 38.830MB (SLO: <40.750MB -4.7%) vs baseline: +4.0%

✅ record-exception

Time: ✅ 63.348ms (SLO: <65.850ms -3.8%) vs baseline: -0.3%

Memory: ✅ 39.145MB (SLO: <40.750MB -3.9%) vs baseline: +5.0%

✅ set-status

Time: ✅ 32.229ms (SLO: <34.150ms -5.6%) vs baseline: +0.7%

Memory: ✅ 39.145MB (SLO: <40.750MB -3.9%) vs baseline: +4.9%

✅ start

Time: ✅ 29.273ms (SLO: <30.150ms -2.9%) vs baseline: +1.3%

Memory: ✅ 38.909MB (SLO: <40.750MB -4.5%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 33.814ms (SLO: <35.350ms -4.3%) vs baseline: -0.7%

Memory: ✅ 39.164MB (SLO: <40.750MB -3.9%) vs baseline: +5.0%

✅ start-finish-telemetry

Time: ✅ 33.970ms (SLO: <35.450ms -4.2%) vs baseline: -0.6%

Memory: ✅ 39.184MB (SLO: <40.750MB -3.8%) vs baseline: +5.2%

✅ update-name

Time: ✅ 31.209ms (SLO: <33.400ms -6.6%) vs baseline: ~same

Memory: ✅ 39.204MB (SLO: <40.750MB -3.8%) vs baseline: +5.2%

✅ otelspan - 22/22

✅ add-event

Time: ✅ 38.011ms (SLO: <47.150ms 📉 -19.4%) vs baseline: -0.5%

Memory: ✅ 41.465MB (SLO: <47.000MB 📉 -11.8%) vs baseline: +5.4%

✅ add-metrics

Time: ✅ 234.047ms (SLO: <344.800ms 📉 -32.1%) vs baseline: +0.3%

Memory: ✅ 45.668MB (SLO: <47.500MB -3.9%) vs baseline: +4.6%

✅ add-tags

Time: ✅ 273.493ms (SLO: <330.000ms 📉 -17.1%) vs baseline: +1.6%

Memory: ✅ 45.767MB (SLO: <47.500MB -3.6%) vs baseline: +4.7%

✅ get-context

Time: ✅ 80.742ms (SLO: <92.350ms 📉 -12.6%) vs baseline: -0.2%

Memory: ✅ 41.701MB (SLO: <46.500MB 📉 -10.3%) vs baseline: +5.1%

✅ is-recording

Time: ✅ 36.506ms (SLO: <44.500ms 📉 -18.0%) vs baseline: ~same

Memory: ✅ 41.158MB (SLO: <47.500MB 📉 -13.4%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 56.725ms (SLO: <67.650ms 📉 -16.1%) vs baseline: -0.1%

Memory: ✅ 41.688MB (SLO: <47.000MB 📉 -11.3%) vs baseline: +4.9%

✅ set-status

Time: ✅ 42.555ms (SLO: <50.400ms 📉 -15.6%) vs baseline: -0.5%

Memory: ✅ 41.151MB (SLO: <47.000MB 📉 -12.4%) vs baseline: +4.8%

✅ start

Time: ✅ 37.092ms (SLO: <43.450ms 📉 -14.6%) vs baseline: +2.6%

Memory: ✅ 41.264MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +5.0%

✅ start-finish

Time: ✅ 85.486ms (SLO: <90.000ms -5.0%) vs baseline: ~same

Memory: ✅ 38.791MB (SLO: <46.500MB 📉 -16.6%) vs baseline: +4.5%

✅ start-finish-telemetry

Time: ✅ 87.148ms (SLO: <91.000ms -4.2%) vs baseline: ~same

Memory: ✅ 38.850MB (SLO: <46.500MB 📉 -16.5%) vs baseline: +4.9%

✅ update-name

Time: ✅ 37.624ms (SLO: <45.150ms 📉 -16.7%) vs baseline: -0.3%

Memory: ✅ 41.426MB (SLO: <47.000MB 📉 -11.9%) vs baseline: +5.2%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 344.604ms (SLO: <354.300ms -2.7%) vs baseline: ~same

Memory: ✅ 41.998MB (SLO: <46.000MB -8.7%) vs baseline: +5.1%

✅ cache_on

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6%

Memory: ✅ 40.593MB (SLO: <46.000MB 📉 -11.8%) vs baseline: +4.8%

✅ rand - 2/2

✅ rand128bits

Time: ✅ 0.184µs (SLO: <21.000µs 📉 -99.1%) vs baseline: -0.1%

✅ rand64bits

Time: ✅ 0.124µs (SLO: <15.000µs 📉 -99.2%) vs baseline: -0.1%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.348µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.2%

Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +4.9%

✅ high_rate_limit

Time: ✅ 2.398µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.2%

Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +5.0%

✅ long_window

Time: ✅ 2.345µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -1.2%

Memory: ✅ 36.608MB (SLO: <38.000MB -3.7%) vs baseline: +4.9%

✅ low_rate_limit

Time: ✅ 2.353µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.7%

Memory: ✅ 36.608MB (SLO: <38.000MB -3.7%) vs baseline: +4.7%

✅ no_rate_limit

Time: ✅ 0.827µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.6%

Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +5.0%

✅ short_window

Time: ✅ 2.454µs (SLO: <10.000µs 📉 -75.5%) vs baseline: -1.8%

Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +4.9%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 311.251ms (SLO: <320.950ms -3.0%) vs baseline: ~same

Memory: ✅ 37.493MB (SLO: <38.750MB -3.2%) vs baseline: +4.8%

✅ deep-profiled

Time: ✅ 326.893ms (SLO: <359.150ms -9.0%) vs baseline: -0.3%

Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +4.7%

✅ medium

Time: ✅ 7.215ms (SLO: <7.400ms -2.5%) vs baseline: -0.2%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ shallow

Time: ✅ 1.006ms (SLO: <1.050ms -4.2%) vs baseline: +1.8%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.6%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 148.760µs (SLO: <290.000µs 📉 -48.7%) vs baseline: -0.2%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.5%

✅ high_match

Time: ✅ 201.536µs (SLO: <480.000µs 📉 -58.0%) vs baseline: +2.6%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.6%

✅ low_match

Time: ✅ 99.368µs (SLO: <120.000µs 📉 -17.2%) vs baseline: -1.0%

Memory: ✅ 701.720MB (SLO: <780.000MB 📉 -10.0%) vs baseline: +4.8%

✅ very_low_match

Time: ✅ 2.926ms (SLO: <8.500ms 📉 -65.6%) vs baseline: -0.4%

Memory: ✅ 78.981MB (SLO: <85.000MB -7.1%) vs baseline: +5.0%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.667µs (SLO: <20.000µs 📉 -46.7%) vs baseline: +1.0%

Memory: ✅ 37.120MB (SLO: <38.750MB -4.2%) vs baseline: +4.7%

✅ all-enabled

Time: ✅ 39.752µs (SLO: <50.000µs 📉 -20.5%) vs baseline: +2.0%

Memory: ✅ 37.179MB (SLO: <38.750MB -4.1%) vs baseline: +5.1%

✅ collectipvariant_exists

Time: ✅ 39.829µs (SLO: <50.000µs 📉 -20.3%) vs baseline: -0.3%

Memory: ✅ 37.179MB (SLO: <38.750MB -4.1%) vs baseline: +4.9%

✅ no-collectipvariant

Time: ✅ 39.174µs (SLO: <50.000µs 📉 -21.7%) vs baseline: -0.2%

Memory: ✅ 37.179MB (SLO: <38.750MB -4.1%) vs baseline: +4.7%

✅ no-useragentvariant

Time: ✅ 37.793µs (SLO: <50.000µs 📉 -24.4%) vs baseline: -0.8%

Memory: ✅ 37.198MB (SLO: <38.750MB -4.0%) vs baseline: +5.0%

✅ obfuscation-no-query

Time: ✅ 39.588µs (SLO: <50.000µs 📉 -20.8%) vs baseline: ~same

Memory: ✅ 37.120MB (SLO: <38.750MB -4.2%) vs baseline: +4.7%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.669µs (SLO: <90.000µs 📉 -15.9%) vs baseline: -0.7%

Memory: ✅ 37.591MB (SLO: <38.750MB -3.0%) vs baseline: +4.9%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.477µs (SLO: <90.000µs 📉 -15.0%) vs baseline: +0.1%

Memory: ✅ 37.572MB (SLO: <38.750MB -3.0%) vs baseline: +5.3%

✅ obfuscation-send-querystring-disabled

Time: ✅ 154.708µs (SLO: <170.000µs -9.0%) vs baseline: +0.4%

Memory: ✅ 37.572MB (SLO: <38.750MB -3.0%) vs baseline: +4.8%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 149.009µs (SLO: <160.000µs -6.9%) vs baseline: -0.2%

Memory: ✅ 37.611MB (SLO: <38.750MB -2.9%) vs baseline: +5.1%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.953µs (SLO: <170.000µs -8.9%) vs baseline: +0.1%

Memory: ✅ 37.493MB (SLO: <38.750MB -3.2%) vs baseline: +4.6%

✅ useragentvariant_exists_1

Time: ✅ 38.478µs (SLO: <50.000µs 📉 -23.0%) vs baseline: -1.7%

Memory: ✅ 37.159MB (SLO: <38.750MB -4.1%) vs baseline: +4.7%

✅ useragentvariant_exists_2

Time: ✅ 39.710µs (SLO: <50.000µs 📉 -20.6%) vs baseline: +0.3%

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +4.4%

✅ useragentvariant_exists_3

Time: ✅ 39.153µs (SLO: <50.000µs 📉 -21.7%) vs baseline: +0.1%

Memory: ✅ 37.100MB (SLO: <38.750MB -4.3%) vs baseline: +4.9%

✅ useragentvariant_not_exists_1

Time: ✅ 38.611µs (SLO: <50.000µs 📉 -22.8%) vs baseline: ~same

Memory: ✅ 37.179MB (SLO: <38.750MB -4.1%) vs baseline: +4.9%

✅ useragentvariant_not_exists_2

Time: ✅ 38.531µs (SLO: <50.000µs 📉 -22.9%) vs baseline: -0.2%

Memory: ✅ 37.100MB (SLO: <38.750MB -4.3%) vs baseline: +5.0%

✅ span - 26/26

✅ add-event

Time: ✅ 17.595ms (SLO: <22.500ms 📉 -21.8%) vs baseline: -0.2%

Memory: ✅ 38.495MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 87.153ms (SLO: <93.500ms -6.8%) vs baseline: +0.4%

Memory: ✅ 42.997MB (SLO: <53.000MB 📉 -18.9%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 145.122ms (SLO: <155.000ms -6.4%) vs baseline: -0.4%

Memory: ✅ 42.962MB (SLO: <53.000MB 📉 -18.9%) vs baseline: +4.8%

✅ get-context

Time: ✅ 16.892ms (SLO: <20.500ms 📉 -17.6%) vs baseline: -0.5%

Memory: ✅ 38.360MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +4.6%

✅ is-recording

Time: ✅ 16.924ms (SLO: <20.500ms 📉 -17.4%) vs baseline: -0.3%

Memory: ✅ 38.400MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +4.5%

✅ record-exception

Time: ✅ 36.137ms (SLO: <41.000ms 📉 -11.9%) vs baseline: ~same

Memory: ✅ 38.975MB (SLO: <53.000MB 📉 -26.5%) vs baseline: +4.8%

✅ set-status

Time: ✅ 18.561ms (SLO: <22.000ms 📉 -15.6%) vs baseline: -1.2%

Memory: ✅ 38.460MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +4.9%

✅ start

Time: ✅ 17.578ms (SLO: <20.500ms 📉 -14.3%) vs baseline: +4.5%

Memory: ✅ 38.377MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +4.5%

✅ start-finish

Time: ✅ 54.183ms (SLO: <56.000ms -3.2%) vs baseline: -0.1%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.7%

✅ start-finish-telemetry

Time: ✅ 55.631ms (SLO: <58.000ms -4.1%) vs baseline: +0.5%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.8%

✅ start-finish-traceid128

Time: ✅ 56.607ms (SLO: <60.000ms -5.7%) vs baseline: -0.3%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%

✅ start-traceid128

Time: ✅ 16.821ms (SLO: <22.500ms 📉 -25.2%) vs baseline: -0.8%

Memory: ✅ 38.432MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +4.8%

✅ update-name

Time: ✅ 17.378ms (SLO: <22.000ms 📉 -21.0%) vs baseline: -0.7%

Memory: ✅ 38.501MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +4.7%

✅ telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 2.354µs (SLO: <20.000µs 📉 -88.2%) vs baseline: +7.6%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%

✅ 1-count-metrics-100-times

Time: ✅ 155.665µs (SLO: <220.000µs 📉 -29.2%) vs baseline: +0.2%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.1%

✅ 1-distribution-metric-1-times

Time: ✅ 2.447µs (SLO: <20.000µs 📉 -87.8%) vs baseline: -1.5%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.6%

✅ 1-distribution-metrics-100-times

Time: ✅ 164.831µs (SLO: <230.000µs 📉 -28.3%) vs baseline: -0.8%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.6%

✅ 1-gauge-metric-1-times

Time: ✅ 2.021µs (SLO: <20.000µs 📉 -89.9%) vs baseline: -0.9%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +4.9%

✅ 1-gauge-metrics-100-times

Time: ✅ 138.418µs (SLO: <150.000µs -7.7%) vs baseline: +0.4%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.9%

✅ 1-rate-metric-1-times

Time: ✅ 2.333µs (SLO: <20.000µs 📉 -88.3%) vs baseline: ~same

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%

✅ 1-rate-metrics-100-times

Time: ✅ 169.118µs (SLO: <250.000µs 📉 -32.4%) vs baseline: -0.5%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%

✅ 100-count-metrics-100-times

Time: ✅ 15.226ms (SLO: <22.000ms 📉 -30.8%) vs baseline: -1.6%

Memory: ✅ 36.117MB (SLO: <38.000MB -5.0%) vs baseline: +4.4%

✅ 100-distribution-metrics-100-times

Time: ✅ 1.742ms (SLO: <2.550ms 📉 -31.7%) vs baseline: +0.5%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.8%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.420ms (SLO: <1.550ms -8.4%) vs baseline: +0.5%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.6%

✅ 100-rate-metrics-100-times

Time: ✅ 1.731ms (SLO: <2.550ms 📉 -32.1%) vs baseline: -1.6%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%

✅ flush-1-metric

Time: ✅ 3.628µs (SLO: <20.000µs 📉 -81.9%) vs baseline: -1.4%

Memory: ✅ 36.648MB (SLO: <38.000MB -3.6%) vs baseline: +5.0%

✅ flush-100-metrics

Time: ✅ 176.279µs (SLO: <250.000µs 📉 -29.5%) vs baseline: -0.2%

Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +5.0%

✅ flush-1000-metrics

Time: ✅ 2.227ms (SLO: <2.500ms 📉 -10.9%) vs baseline: -0.1%

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +4.9%

✅ tracer - 6/6

✅ large

Time: ✅ 31.292ms (SLO: <32.950ms -5.0%) vs baseline: -0.2%

Memory: ✅ 37.906MB (SLO: <39.250MB -3.4%) vs baseline: +4.7%

✅ medium

Time: ✅ 3.123ms (SLO: <3.200ms -2.4%) vs baseline: ~same

Memory: ✅ 36.353MB (SLO: <38.750MB -6.2%) vs baseline: +5.1%

✅ small

Time: ✅ 361.004µs (SLO: <370.000µs -2.4%) vs baseline: +2.4%

Memory: ✅ 36.294MB (SLO: <38.750MB -6.3%) vs baseline: +4.9%

ℹ️ Scenarios Missing SLO Configuration (46 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

coreapiscenario-core_dispatch_listeners
coreapiscenario-core_dispatch_no_listeners
coreapiscenario-core_dispatch_with_results_listeners
coreapiscenario-core_dispatch_with_results_no_listeners
djangosimple-baseline
errortrackingdjangosimple-baseline
errortrackingflasksqli-baseline
flasksimple-baseline
flasksqli-baseline
iast_aspects-re_expand_aspect
iast_aspects-re_expand_noaspect
iast_aspects-re_findall_aspect
iast_aspects-re_findall_noaspect
iast_aspects-re_finditer_aspect
iast_aspects-re_finditer_noaspect
iast_aspects-re_fullmatch_aspect
iast_aspects-re_fullmatch_noaspect
iast_aspects-re_group_aspect
iast_aspects-re_group_noaspect
iast_aspects-re_groups_aspect
iast_aspects-re_groups_noaspect
iast_aspects-re_match_aspect
iast_aspects-re_match_noaspect
iast_aspects-re_search_aspect
iast_aspects-re_search_noaspect
iast_aspects-re_sub_aspect
iast_aspects-re_sub_noaspect
iast_aspects-re_subn_aspect
iast_aspects-re_subn_noaspect
sethttpmeta-obfuscation-disabled
startup-baseline
startup-baseline_django
startup-baseline_flask
startup-ddtrace_run
startup-ddtrace_run_appsec
startup-ddtrace_run_profiling
startup-ddtrace_run_runtime_metrics
startup-ddtrace_run_send_span
startup-ddtrace_run_telemetry_disabled
startup-ddtrace_run_telemetry_enabled
startup-import_ddtrace
startup-import_ddtrace_auto
startup-import_ddtrace_auto_django
startup-import_ddtrace_auto_flask
startup-import_ddtrace_django
startup-import_ddtrace_flask

datadog-official · 2026-04-03T19:13:34Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 4e9012d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

vlad-scherbich

cit-pr-commenter-54b7da · 2026-04-03T20:54:31Z

Codeowners resolved as

ddtrace/internal/threads.py                                             @DataDog/apm-core-python
releasenotes/notes/fix-potential-thread-restart-timer-leak-6ba9eaa0cc4ca49a.yaml  @DataDog/apm-python

github-actions · 2026-04-06T09:20:19Z

This change is marked for backport to 4.5 and it does not conflict with that branch.
The command used to test backporting was

git checkout 4.5 && git cherry-pick -x --mainline 1 96352ec542766449b5adebf2e39d2fa3ee3b9d00

github-actions · 2026-04-06T09:20:21Z

This change is marked for backport to 4.6 and it does not conflict with that branch.
The command used to test backporting was

git checkout 4.6 && git cherry-pick -x --mainline 1 96352ec542766449b5adebf2e39d2fa3ee3b9d00

## Description We have a possible situation where we can end up with orphaned `ThreadRestartTimer` threads in fork-heavy applications. If a fork occurs while the current `ThreadRestartTimer` thread is in the stopping state (after `cls._instance = None` has already been called) then it will appear in `periodic_threads` and be added to `_threads_to_restart_after_fork` and then force restarted. ## Testing  ## Risks  ## Additional Notes This bug is really really hard to reproduce and technically shouldn't be possible because the GIL should be held throughout the whole `os.fork()` call, but this is a code path which could cause some of the crashes we've seen in a fork-heavy application and is an easy defensive guard to add. Co-authored-by: juanjux <juanjo.alvarezmartinez@datadoghq.com> (cherry picked from commit 96352ec)

P403n1x87 · 2026-04-06T12:03:58Z

the only reason to keep the ThreadRestartTimer contraption is for cases where fork happens very frequently, and the threads are always restarted for no reason in the parent process. Things would be much easier without it, so if we could somehow declare the worst-case scenario rare, we could just get rid of it altogether 🤔

…t 4.6] (#17326) ## Description Backport of #17312 Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

…t 4.5] (#17325) ## Description Backport of #17312 Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

## Description We have a possible situation where we can end up with orphaned `ThreadRestartTimer` threads in fork-heavy applications. If a fork occurs while the current `ThreadRestartTimer` thread is in the stopping state (after `cls._instance = None` has already been called) then it will appear in `periodic_threads` and be added to `_threads_to_restart_after_fork` and then force restarted. ## Testing  ## Risks  ## Additional Notes This bug is really really hard to reproduce and technically shouldn't be possible because the GIL should be held throughout the whole `os.fork()` call, but this is a code path which could cause some of the crashes we've seen in a fork-heavy application and is an easy defensive guard to add. Co-authored-by: juanjux <juanjo.alvarezmartinez@datadoghq.com>

fix(internal): do not restart any ThreadRestartTimer threads

0ee1f8e

brettlangdon requested review from a team as code owners April 3, 2026 17:57

brettlangdon requested review from christophe-papazian, emmettbutler and vlad-scherbich April 3, 2026 17:57

Merge branch 'main' into brettlangdon/fix-potential-thread-leak

2685572

wantsui approved these changes Apr 3, 2026

View reviewed changes

vlad-scherbich approved these changes Apr 3, 2026

View reviewed changes

Comment thread ddtrace/internal/threads.py Outdated

Apply suggestion from @brettlangdon

d7bf585

juanjux approved these changes Apr 6, 2026

View reviewed changes

Merge branch 'main' into brettlangdon/fix-potential-thread-leak

4e9012d

juanjux enabled auto-merge (squash) April 6, 2026 07:39

juanjux disabled auto-merge April 6, 2026 08:15

gh-worker-dd-mergequeue-cf854d Bot merged commit 96352ec into main Apr 6, 2026
389 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the brettlangdon/fix-potential-thread-leak branch April 6, 2026 08:54

juanjux added backport 4.5 backport 4.6 labels Apr 6, 2026

juanjux mentioned this pull request Apr 6, 2026

fix(internal): do not restart any ThreadRestartTimer threads [backport 4.5] #17325

Merged

juanjux mentioned this pull request Apr 6, 2026

fix(internal): do not restart any ThreadRestartTimer threads [backport 4.6] #17326

Merged

brettlangdon added a commit that referenced this pull request Apr 6, 2026

fix(internal): do not restart any ThreadRestartTimer threads [backpor…

906ceb5

…t 4.6] (#17326) ## Description Backport of #17312 Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

KowalskiThomas pushed a commit that referenced this pull request Apr 7, 2026

fix(internal): do not restart any ThreadRestartTimer threads [backpor…

46d947b

…t 4.5] (#17325) ## Description Backport of #17312 Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

Conversation

brettlangdon commented Apr 3, 2026

Description

Testing

Risks

Additional Notes

Uh oh!

pr-commenter Bot commented Apr 3, 2026

Performance SLOs

✅ add_aspect

✅ add_inplace_aspect

✅ add_inplace_noaspect

✅ add_noaspect

✅ bytearray_aspect

✅ bytearray_extend_aspect

✅ bytearray_extend_noaspect

✅ bytearray_noaspect

✅ bytes_aspect

✅ bytes_noaspect

✅ bytesio_aspect

✅ bytesio_noaspect

✅ capitalize_aspect

✅ capitalize_noaspect

✅ casefold_aspect

✅ casefold_noaspect

✅ decode_aspect

✅ decode_noaspect

✅ encode_aspect

✅ encode_noaspect

✅ format_aspect

✅ format_map_aspect

✅ format_map_noaspect

✅ format_noaspect

✅ index_aspect

✅ index_noaspect

✅ join_aspect

✅ join_noaspect

✅ ljust_aspect

✅ ljust_noaspect

✅ lower_aspect

✅ lower_noaspect

✅ lstrip_aspect

✅ lstrip_noaspect

✅ modulo_aspect

✅ modulo_aspect_for_bytearray_bytearray

✅ modulo_aspect_for_bytes

✅ modulo_aspect_for_bytes_bytearray

✅ modulo_noaspect

✅ replace_aspect

✅ replace_noaspect

✅ repr_aspect

✅ repr_noaspect

✅ rstrip_aspect

✅ rstrip_noaspect

✅ slice_aspect

✅ slice_noaspect

✅ stringio_aspect

✅ stringio_noaspect

✅ strip_aspect

✅ strip_noaspect

✅ swapcase_aspect

✅ swapcase_noaspect

✅ title_aspect

✅ title_noaspect

✅ translate_aspect

✅ translate_noaspect

✅ upper_aspect

✅ upper_noaspect

✅ ospathbasename_aspect

✅ ospathbasename_noaspect

✅ ospathjoin_aspect

✅ ospathjoin_noaspect

✅ ospathnormcase_aspect

✅ ospathnormcase_noaspect

✅ ospathsplit_aspect

✅ ospathsplit_noaspect

✅ ospathsplitdrive_aspect

✅ ospathsplitdrive_noaspect

✅ ospathsplitext_aspect

✅ ospathsplitext_noaspect