Skip to content

chore(telemetry): extend process tracking to spawned processes#16842

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 18 commits into
mainfrom
munir/send-app-start-closed-on-root
Apr 14, 2026
Merged

chore(telemetry): extend process tracking to spawned processes#16842
gh-worker-dd-mergequeue-cf854d[bot] merged 18 commits into
mainfrom
munir/send-app-start-closed-on-root

Conversation

@mabdinur

Copy link
Copy Markdown
Contributor

Description

Extends process lineage tracking to exec-based child processes (subprocess, multiprocessing spawn). Fork support was added in a previous PR; this covers the remaining spawning mechanism.

subprocess.Popen.__init__ is now patched unconditionally (independent of ASM) to inject _DD_ROOT_PY_SESSION_ID and _DD_PARENT_PY_SESSION_ID into the child's environment. The child reads these at module load
time to seed get_ancestor_runtime_id() and get_parent_runtime_id(). Disable via DD_TRACE_SUBPROCESS_ENABLED=false.

Key changes:

  • runtime/__init__.py — adds env var name constants, seeds module state from them at import, exposes get_session_env_vars()
  • subprocess/patch.py — moves Popen.__init__/Popen.wait wrapping before the ASM gate; injects lineage env vars unconditionally in _traced_subprocess_init
  • telemetry/writer.py — replaces forksafe.is_fork_child() with get_parent_runtime_id() is not None, which now correctly identifies both forked and exec-spawned children

Testing

test_subprocess_session_lineage_env_vars — parametrized over DD_TRACE_SUBPROCESS_ENABLED=true/false/unset, runs under ddtrace-run, spawns a ddtrace-run child, and verifies the child's
get_parent_runtime_id() / get_ancestor_runtime_id() match the parent's runtime ID when enabled and are None when disabled.

Risks

Popen.__init__ is now patched whenever ddtrace is loaded, not only when ASM is enabled. Spawned processes will receive two extra _DD_-prefixed env vars. These are ignored by non-ddtrace processes so the blast
radius is minimal.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Mar 10, 2026

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a02f32e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter

pr-commenter Bot commented Mar 10, 2026

Copy link
Copy Markdown

Performance SLOs

Comparing candidate munir/send-app-start-closed-on-root (a02f32e) with baseline main (c076c6a)

🟡 Near SLO Breach (5 suites)
🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 21.036ms (SLO: <22.300ms -5.7%) vs baseline: -0.2%

Memory: ✅ 71.378MB (SLO: <73.500MB -2.9%) vs baseline: +5.3%


✅ exception-replay-enabled

Time: ✅ 1.369ms (SLO: <1.450ms -5.6%) vs baseline: ~same

Memory: ✅ 69.600MB (SLO: <71.500MB -2.7%) vs baseline: +5.2%


✅ iast

Time: ✅ 21.070ms (SLO: <22.250ms -5.3%) vs baseline: -0.3%

Memory: ✅ 71.335MB (SLO: <75.000MB -4.9%) vs baseline: +5.3%


✅ profiler

Time: ✅ 15.280ms (SLO: <16.550ms -7.7%) vs baseline: +0.9%

Memory: ✅ 60.155MB (SLO: <61.000MB 🟡 -1.4%) vs baseline: +5.7%


✅ resource-renaming

Time: ✅ 20.746ms (SLO: <21.750ms -4.6%) vs baseline: -0.4%

Memory: ✅ 71.370MB (SLO: <73.500MB -2.9%) vs baseline: +5.2%


✅ span-code-origin

Time: ✅ 21.439ms (SLO: <28.200ms 📉 -24.0%) vs baseline: +0.9%

Memory: ✅ 71.429MB (SLO: <75.000MB -4.8%) vs baseline: +5.3%


✅ tracer

Time: ✅ 21.020ms (SLO: <21.750ms -3.4%) vs baseline: -0.4%

Memory: ✅ 71.255MB (SLO: <75.000MB -5.0%) vs baseline: +5.1%


✅ tracer-and-profiler

Time: ✅ 21.124ms (SLO: <23.500ms 📉 -10.1%) vs baseline: +0.5%

Memory: ✅ 73.305MB (SLO: <75.000MB -2.3%) vs baseline: +5.4%


✅ tracer-dont-create-db-spans

Time: ✅ 21.161ms (SLO: <21.500ms 🟡 -1.6%) vs baseline: +0.5%

Memory: ✅ 71.357MB (SLO: <75.000MB -4.9%) vs baseline: +5.2%


✅ tracer-minimal

Time: ✅ 17.878ms (SLO: <18.500ms -3.4%) vs baseline: -0.5%

Memory: ✅ 71.283MB (SLO: <75.000MB -5.0%) vs baseline: +5.1%


✅ tracer-native

Time: ✅ 20.930ms (SLO: <21.750ms -3.8%) vs baseline: +0.1%

Memory: ✅ 71.298MB (SLO: <72.500MB 🟡 -1.7%) vs baseline: +5.2%


✅ tracer-no-caches

Time: ✅ 18.909ms (SLO: <19.650ms -3.8%) vs baseline: +0.6%

Memory: ✅ 71.333MB (SLO: <75.000MB -4.9%) vs baseline: +5.2%


✅ tracer-no-databases

Time: ✅ 20.690ms (SLO: <21.100ms 🟡 -1.9%) vs baseline: +0.2%

Memory: ✅ 71.333MB (SLO: <75.000MB -4.9%) vs baseline: +5.3%


✅ tracer-no-middleware

Time: ✅ 20.734ms (SLO: <21.500ms -3.6%) vs baseline: +0.1%

Memory: ✅ 71.296MB (SLO: <75.000MB -4.9%) vs baseline: +5.1%


✅ tracer-no-templates

Time: ✅ 20.918ms (SLO: <22.000ms -4.9%) vs baseline: +1.0%

Memory: ✅ 71.355MB (SLO: <73.500MB -2.9%) vs baseline: +5.3%


🟡 otelspan - 22/22

✅ add-event

Time: ✅ 40.764ms (SLO: <47.150ms 📉 -13.5%) vs baseline: -0.8%

Memory: ✅ 41.284MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +5.5%


✅ add-metrics

Time: ✅ 236.380ms (SLO: <344.800ms 📉 -31.4%) vs baseline: ~same

Memory: ✅ 45.689MB (SLO: <47.500MB -3.8%) vs baseline: +5.0%


✅ add-tags

Time: ✅ 278.378ms (SLO: <330.000ms 📉 -15.6%) vs baseline: +2.2%

Memory: ✅ 45.798MB (SLO: <47.500MB -3.6%) vs baseline: +5.6%


✅ get-context

Time: ✅ 83.988ms (SLO: <92.350ms -9.1%) vs baseline: +0.2%

Memory: ✅ 41.406MB (SLO: <46.500MB 📉 -11.0%) vs baseline: +5.2%


✅ is-recording

Time: ✅ 39.099ms (SLO: <44.500ms 📉 -12.1%) vs baseline: -1.3%

Memory: ✅ 41.053MB (SLO: <47.500MB 📉 -13.6%) vs baseline: +5.4%


✅ record-exception

Time: ✅ 61.030ms (SLO: <67.650ms -9.8%) vs baseline: ~same

Memory: ✅ 41.727MB (SLO: <47.000MB 📉 -11.2%) vs baseline: +5.3%


✅ set-status

Time: ✅ 45.164ms (SLO: <50.400ms 📉 -10.4%) vs baseline: ~same

Memory: ✅ 41.110MB (SLO: <47.000MB 📉 -12.5%) vs baseline: +5.5%


✅ start

Time: ✅ 40.133ms (SLO: <44.500ms -9.8%) vs baseline: +3.7%

Memory: ✅ 41.206MB (SLO: <47.000MB 📉 -12.3%) vs baseline: +5.7%


✅ start-finish

Time: ✅ 90.215ms (SLO: <91.000ms 🟡 -0.9%) vs baseline: ~same

Memory: ✅ 38.732MB (SLO: <46.500MB 📉 -16.7%) vs baseline: +5.2%


✅ start-finish-telemetry

Time: ✅ 91.586ms (SLO: <92.000ms 🟡 -0.4%) vs baseline: -0.4%

Memory: ✅ 38.712MB (SLO: <46.500MB 📉 -16.7%) vs baseline: +5.1%


✅ update-name

Time: ✅ 40.055ms (SLO: <45.150ms 📉 -11.3%) vs baseline: -1.3%

Memory: ✅ 41.245MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +5.3%


🟡 recursivecomputation - 8/8

✅ deep

Time: ✅ 312.191ms (SLO: <320.950ms -2.7%) vs baseline: ~same

Memory: ✅ 37.336MB (SLO: <38.750MB -3.6%) vs baseline: +5.1%


✅ deep-profiled

Time: ✅ 329.372ms (SLO: <359.150ms -8.3%) vs baseline: -0.1%

Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +5.6%


✅ medium

Time: ✅ 7.412ms (SLO: <7.450ms 🟡 -0.5%) vs baseline: -0.3%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.5%


✅ shallow

Time: ✅ 1.050ms (SLO: <1.050ms 🟡 ~same) vs baseline: +1.5%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


🟡 span - 26/26

✅ add-event

Time: ✅ 19.585ms (SLO: <22.500ms 📉 -13.0%) vs baseline: -1.4%

Memory: ✅ 38.456MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +5.6%


✅ add-metrics

Time: ✅ 89.420ms (SLO: <93.500ms -4.4%) vs baseline: +0.7%

Memory: ✅ 42.900MB (SLO: <53.000MB 📉 -19.1%) vs baseline: +5.3%


✅ add-tags

Time: ✅ 148.016ms (SLO: <155.000ms -4.5%) vs baseline: +0.2%

Memory: ✅ 42.953MB (SLO: <53.000MB 📉 -19.0%) vs baseline: +5.4%


✅ get-context

Time: ✅ 18.748ms (SLO: <20.500ms -8.5%) vs baseline: -1.0%

Memory: ✅ 38.341MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +5.5%


✅ is-recording

Time: ✅ 18.938ms (SLO: <20.500ms -7.6%) vs baseline: -1.8%

Memory: ✅ 38.303MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +5.6%


✅ record-exception

Time: ✅ 38.569ms (SLO: <41.000ms -5.9%) vs baseline: -0.5%

Memory: ✅ 38.787MB (SLO: <53.000MB 📉 -26.8%) vs baseline: +5.3%


✅ set-status

Time: ✅ 20.646ms (SLO: <22.000ms -6.2%) vs baseline: -1.0%

Memory: ✅ 38.433MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +6.0%


✅ start

Time: ✅ 19.732ms (SLO: <20.500ms -3.7%) vs baseline: +3.8%

Memory: ✅ 38.249MB (SLO: <53.000MB 📉 -27.8%) vs baseline: +5.2%


✅ start-finish

Time: ✅ 58.048ms (SLO: <58.500ms 🟡 -0.8%) vs baseline: -0.4%

Memory: ✅ 36.156MB (SLO: <38.000MB -4.9%) vs baseline: +5.1%


✅ start-finish-telemetry

Time: ✅ 59.239ms (SLO: <60.000ms 🟡 -1.3%) vs baseline: -0.6%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.3%


✅ start-finish-traceid128

Time: ✅ 60.602ms (SLO: <62.000ms -2.3%) vs baseline: -0.3%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.5%


✅ start-traceid128

Time: ✅ 18.686ms (SLO: <22.500ms 📉 -16.9%) vs baseline: -2.4%

Memory: ✅ 38.319MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +5.5%


✅ update-name

Time: ✅ 19.309ms (SLO: <22.000ms 📉 -12.2%) vs baseline: -1.4%

Memory: ✅ 38.329MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +5.1%


🟡 tracer - 6/6

✅ large

Time: ✅ 33.089ms (SLO: <32.950ms +0.4%) vs baseline: -0.4%

Memory: ✅ 37.827MB (SLO: <39.250MB -3.6%) vs baseline: +6.4%


✅ medium

Time: ✅ 3.336ms (SLO: <3.500ms -4.7%) vs baseline: ~same

Memory: ✅ 36.255MB (SLO: <38.750MB -6.4%) vs baseline: +5.6%


✅ small

Time: ✅ 385.864µs (SLO: <390.000µs 🟡 -1.1%) vs baseline: +3.5%

Memory: ✅ 36.156MB (SLO: <38.750MB -6.7%) vs baseline: +5.3%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.654µs (SLO: <20.000µs 📉 -31.7%) vs baseline: +0.4%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.0%


✅ context_with_data_no_listeners

Time: ✅ 3.614µs (SLO: <10.000µs 📉 -63.9%) vs baseline: +0.7%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.6%


✅ get_item_exists

Time: ✅ 0.585µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.6%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.5%


✅ get_item_missing

Time: ✅ 0.640µs (SLO: <10.000µs 📉 -93.6%) vs baseline: ~same

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +5.5%


✅ set_item

Time: ✅ 24.546µs (SLO: <30.000µs 📉 -18.2%) vs baseline: +1.1%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.4%

✅ All Tests Passing (12 suites)
errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 17.541ms (SLO: <19.850ms 📉 -11.6%) vs baseline: +0.1%

Memory: ✅ 70.809MB (SLO: <75.000MB -5.6%) vs baseline: +5.1%


✅ errortracking-enabled-user

Time: ✅ 17.522ms (SLO: <19.400ms -9.7%) vs baseline: ~same

Memory: ✅ 70.930MB (SLO: <75.000MB -5.4%) vs baseline: +5.1%


✅ tracer-enabled

Time: ✅ 17.597ms (SLO: <19.450ms -9.5%) vs baseline: +0.8%

Memory: ✅ 70.634MB (SLO: <75.000MB -5.8%) vs baseline: +4.6%


errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.123ms (SLO: <2.300ms -7.7%) vs baseline: +0.2%

Memory: ✅ 58.105MB (SLO: <60.000MB -3.2%) vs baseline: +4.7%


✅ errortracking-enabled-user

Time: ✅ 2.133ms (SLO: <2.250ms -5.2%) vs baseline: +0.3%

Memory: ✅ 58.144MB (SLO: <60.000MB -3.1%) vs baseline: +4.8%


✅ tracer-enabled

Time: ✅ 2.125ms (SLO: <2.300ms -7.6%) vs baseline: +0.3%

Memory: ✅ 58.157MB (SLO: <60.000MB -3.1%) vs baseline: +4.9%


flasksimple - 18/18

✅ appsec-get

Time: ✅ 3.408ms (SLO: <4.750ms 📉 -28.3%) vs baseline: +0.1%

Memory: ✅ 58.513MB (SLO: <66.500MB 📉 -12.0%) vs baseline: +5.5%


✅ appsec-post

Time: ✅ 2.914ms (SLO: <6.750ms 📉 -56.8%) vs baseline: +0.4%

Memory: ✅ 58.552MB (SLO: <66.500MB 📉 -12.0%) vs baseline: +5.6%


✅ appsec-telemetry

Time: ✅ 3.452ms (SLO: <4.750ms 📉 -27.3%) vs baseline: +1.7%

Memory: ✅ 58.591MB (SLO: <66.500MB 📉 -11.9%) vs baseline: +5.6%


✅ debugger

Time: ✅ 1.883ms (SLO: <2.000ms -5.8%) vs baseline: +0.2%

Memory: ✅ 49.294MB (SLO: <51.500MB -4.3%) vs baseline: +5.6%


✅ iast-get

Time: ✅ 1.877ms (SLO: <2.000ms -6.2%) vs baseline: +0.5%

Memory: ✅ 46.128MB (SLO: <49.000MB -5.9%) vs baseline: +6.1%


✅ profiler

Time: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: -0.2%

Memory: ✅ 51.947MB (SLO: <53.500MB -2.9%) vs baseline: +5.5%


✅ resource-renaming

Time: ✅ 3.389ms (SLO: <3.650ms -7.1%) vs baseline: ~same

Memory: ✅ 58.549MB (SLO: <60.000MB -2.4%) vs baseline: +5.5%


✅ tracer

Time: ✅ 3.410ms (SLO: <3.650ms -6.6%) vs baseline: +0.5%

Memory: ✅ 58.513MB (SLO: <60.000MB -2.5%) vs baseline: +5.2%


✅ tracer-native

Time: ✅ 3.406ms (SLO: <3.650ms -6.7%) vs baseline: ~same

Memory: ✅ 58.513MB (SLO: <60.000MB -2.5%) vs baseline: +5.4%


flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 2.117ms (SLO: <4.200ms 📉 -49.6%) vs baseline: ~same

Memory: ✅ 58.293MB (SLO: <66.000MB 📉 -11.7%) vs baseline: +5.0%


✅ iast-enabled

Time: ✅ 2.126ms (SLO: <2.800ms 📉 -24.1%) vs baseline: ~same

Memory: ✅ 58.290MB (SLO: <62.500MB -6.7%) vs baseline: +4.9%


✅ tracer-enabled

Time: ✅ 2.116ms (SLO: <2.250ms -6.0%) vs baseline: +0.1%

Memory: ✅ 58.295MB (SLO: <60.000MB -2.8%) vs baseline: +5.0%


forktime - 4/4

✅ baseline

Time: ✅ 1.932ms (SLO: <3.000ms 📉 -35.6%) vs baseline: +3.1%

Memory: ✅ 29.255MB (SLO: <33.000MB 📉 -11.3%) vs baseline: +4.4%


✅ configured

Time: ✅ 9.359ms (SLO: <13.000ms 📉 -28.0%) vs baseline: -0.5%

Memory: ✅ 58.411MB (SLO: <60.000MB -2.6%) vs baseline: +5.2%


httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.371µs (SLO: <100.000µs 📉 -18.6%) vs baseline: +4.6%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ b3_headers

Time: ✅ 12.891µs (SLO: <20.000µs 📉 -35.5%) vs baseline: +0.7%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ b3_single_headers

Time: ✅ 11.969µs (SLO: <20.000µs 📉 -40.2%) vs baseline: +1.1%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.1%


✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 61.015µs (SLO: <80.000µs 📉 -23.7%) vs baseline: ~same

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.5%


✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 63.717µs (SLO: <80.000µs 📉 -20.4%) vs baseline: -0.2%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.2%


✅ empty_headers

Time: ✅ 1.306µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.0%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ full_t_id_datadog_headers

Time: ✅ 21.588µs (SLO: <30.000µs 📉 -28.0%) vs baseline: -0.6%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ invalid_priority_header

Time: ✅ 5.922µs (SLO: <10.000µs 📉 -40.8%) vs baseline: ~same

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.9%


✅ invalid_span_id_header

Time: ✅ 5.936µs (SLO: <10.000µs 📉 -40.6%) vs baseline: -0.3%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.3%


✅ invalid_tags_header

Time: ✅ 5.917µs (SLO: <10.000µs 📉 -40.8%) vs baseline: -0.5%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.4%


✅ invalid_trace_id_header

Time: ✅ 5.916µs (SLO: <10.000µs 📉 -40.8%) vs baseline: -1.0%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ large_header_no_matches

Time: ✅ 26.886µs (SLO: <30.000µs 📉 -10.4%) vs baseline: -0.9%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.4%


✅ large_valid_headers_all

Time: ✅ 28.025µs (SLO: <40.000µs 📉 -29.9%) vs baseline: ~same

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ medium_header_no_matches

Time: ✅ 9.219µs (SLO: <20.000µs 📉 -53.9%) vs baseline: -0.2%

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.7%


✅ medium_valid_headers_all

Time: ✅ 10.719µs (SLO: <20.000µs 📉 -46.4%) vs baseline: ~same

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ none_propagation_style

Time: ✅ 1.391µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.5%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


✅ tracecontext_headers

Time: ✅ 33.058µs (SLO: <40.000µs 📉 -17.4%) vs baseline: +0.3%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


✅ valid_headers_all

Time: ✅ 5.918µs (SLO: <10.000µs 📉 -40.8%) vs baseline: ~same

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ valid_headers_basic

Time: ✅ 5.515µs (SLO: <10.000µs 📉 -44.8%) vs baseline: -0.2%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


✅ wsgi_empty_headers

Time: ✅ 1.304µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.9%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.3%


✅ wsgi_invalid_priority_header

Time: ✅ 5.972µs (SLO: <10.000µs 📉 -40.3%) vs baseline: ~same

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.1%


✅ wsgi_invalid_span_id_header

Time: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.4%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.3%


✅ wsgi_invalid_tags_header

Time: ✅ 5.959µs (SLO: <10.000µs 📉 -40.4%) vs baseline: -0.2%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.4%


✅ wsgi_invalid_trace_id_header

Time: ✅ 6.023µs (SLO: <10.000µs 📉 -39.8%) vs baseline: +0.2%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.3%


✅ wsgi_large_header_no_matches

Time: ✅ 27.910µs (SLO: <40.000µs 📉 -30.2%) vs baseline: -1.0%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ wsgi_large_valid_headers_all

Time: ✅ 29.296µs (SLO: <40.000µs 📉 -26.8%) vs baseline: +0.4%

Memory: ✅ 36.176MB (SLO: <38.000MB -4.8%) vs baseline: +5.0%


✅ wsgi_medium_header_no_matches

Time: ✅ 9.516µs (SLO: <20.000µs 📉 -52.4%) vs baseline: +0.3%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


✅ wsgi_medium_valid_headers_all

Time: ✅ 11.003µs (SLO: <20.000µs 📉 -45.0%) vs baseline: ~same

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ wsgi_valid_headers_all

Time: ✅ 6.003µs (SLO: <10.000µs 📉 -40.0%) vs baseline: +0.8%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.3%


✅ wsgi_valid_headers_basic

Time: ✅ 5.518µs (SLO: <10.000µs 📉 -44.8%) vs baseline: -0.3%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.0%


httppropagationinject - 16/16

✅ ids_only

Time: ✅ 20.882µs (SLO: <30.000µs 📉 -30.4%) vs baseline: +4.3%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +5.5%


✅ with_all

Time: ✅ 27.033µs (SLO: <40.000µs 📉 -32.4%) vs baseline: ~same

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +5.4%


✅ with_dd_origin

Time: ✅ 23.913µs (SLO: <30.000µs 📉 -20.3%) vs baseline: ~same

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.1%


✅ with_priority_and_origin

Time: ✅ 23.155µs (SLO: <40.000µs 📉 -42.1%) vs baseline: -1.3%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.4%


✅ with_sampling_priority

Time: ✅ 20.180µs (SLO: <30.000µs 📉 -32.7%) vs baseline: +0.4%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


✅ with_tags

Time: ✅ 25.084µs (SLO: <40.000µs 📉 -37.3%) vs baseline: +0.2%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.5%


✅ with_tags_invalid

Time: ✅ 26.544µs (SLO: <40.000µs 📉 -33.6%) vs baseline: ~same

Memory: ✅ 36.392MB (SLO: <38.000MB -4.2%) vs baseline: +5.5%


✅ with_tags_max_size

Time: ✅ 25.753µs (SLO: <40.000µs 📉 -35.6%) vs baseline: +0.9%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.516ms (SLO: <42.000ms -3.5%) vs baseline: ~same

Memory: ✅ 39.105MB (SLO: <40.750MB -4.0%) vs baseline: +6.7%


✅ add-link

Time: ✅ 36.381ms (SLO: <38.550ms -5.6%) vs baseline: +0.3%

Memory: ✅ 39.125MB (SLO: <40.750MB -4.0%) vs baseline: +6.6%


✅ add-metrics

Time: ✅ 219.590ms (SLO: <232.000ms -5.3%) vs baseline: +0.1%

Memory: ✅ 39.007MB (SLO: <40.750MB -4.3%) vs baseline: +6.1%


✅ add-tags

Time: ✅ 212.251ms (SLO: <221.600ms -4.2%) vs baseline: +0.2%

Memory: ✅ 39.086MB (SLO: <40.750MB -4.1%) vs baseline: +6.2%


✅ get-context

Time: ✅ 29.209ms (SLO: <31.300ms -6.7%) vs baseline: +0.6%

Memory: ✅ 39.027MB (SLO: <40.750MB -4.2%) vs baseline: +6.1%


✅ is-recording

Time: ✅ 29.143ms (SLO: <31.000ms -6.0%) vs baseline: ~same

Memory: ✅ 39.027MB (SLO: <40.750MB -4.2%) vs baseline: +5.8%


✅ record-exception

Time: ✅ 63.244ms (SLO: <65.850ms -4.0%) vs baseline: +0.2%

Memory: ✅ 39.046MB (SLO: <40.750MB -4.2%) vs baseline: +6.4%


✅ set-status

Time: ✅ 31.717ms (SLO: <34.150ms -7.1%) vs baseline: -0.5%

Memory: ✅ 38.987MB (SLO: <40.750MB -4.3%) vs baseline: +6.0%


✅ start

Time: ✅ 29.367ms (SLO: <30.150ms -2.6%) vs baseline: +2.3%

Memory: ✅ 39.027MB (SLO: <40.750MB -4.2%) vs baseline: +6.7%


✅ start-finish

Time: ✅ 33.842ms (SLO: <35.350ms -4.3%) vs baseline: -0.3%

Memory: ✅ 39.086MB (SLO: <40.750MB -4.1%) vs baseline: +6.0%


✅ start-finish-telemetry

Time: ✅ 33.976ms (SLO: <35.450ms -4.2%) vs baseline: +0.8%

Memory: ✅ 38.968MB (SLO: <40.750MB -4.4%) vs baseline: +6.2%


✅ update-name

Time: ✅ 31.106ms (SLO: <33.400ms -6.9%) vs baseline: +0.2%

Memory: ✅ 39.027MB (SLO: <40.750MB -4.2%) vs baseline: +5.9%


ratelimiter - 11/11

✅ defaults

Time: ✅ 2.366µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +1.0%

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%) vs baseline: +6.5%


✅ high_rate_limit

Time: ✅ 2.419µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +1.0%

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%) vs baseline: +6.4%


✅ long_window

Time: ✅ 2.342µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -0.6%


✅ low_rate_limit

Time: ✅ 2.375µs (SLO: <10.000µs 📉 -76.2%) vs baseline: -0.5%

Memory: ✅ 36.569MB (SLO: <38.000MB -3.8%) vs baseline: +6.2%


✅ no_rate_limit

Time: ✅ 0.833µs (SLO: <10.000µs 📉 -91.7%) vs baseline: +0.4%

Memory: ✅ 36.510MB (SLO: <38.000MB -3.9%) vs baseline: +5.7%


✅ short_window

Time: ✅ 2.490µs (SLO: <10.000µs 📉 -75.1%) vs baseline: ~same

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%) vs baseline: +6.3%


samplingrules - 8/8

✅ average_match

Time: ✅ 168.967µs (SLO: <300.000µs 📉 -43.7%) vs baseline: -0.1%

Memory: ✅ 36.156MB (SLO: <38.000MB -4.9%) vs baseline: +5.0%


✅ high_match

Time: ✅ 215.151µs (SLO: <480.000µs 📉 -55.2%) vs baseline: -0.7%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.3%


✅ low_match

Time: ✅ 118.721µs (SLO: <130.000µs -8.7%) vs baseline: -1.3%

Memory: ✅ 701.594MB (SLO: <780.000MB 📉 -10.1%) vs baseline: +4.9%


✅ very_low_match

Time: ✅ 3.130ms (SLO: <9.000ms 📉 -65.2%) vs baseline: ~same

Memory: ✅ 78.599MB (SLO: <85.000MB -7.5%) vs baseline: +4.8%


sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.552µs (SLO: <20.000µs 📉 -47.2%) vs baseline: -0.2%

Memory: ✅ 37.277MB (SLO: <38.750MB -3.8%) vs baseline: +5.8%


✅ all-enabled

Time: ✅ 39.968µs (SLO: <50.000µs 📉 -20.1%) vs baseline: +2.3%

Memory: ✅ 37.218MB (SLO: <38.750MB -4.0%) vs baseline: +5.7%


✅ collectipvariant_exists

Time: ✅ 39.841µs (SLO: <50.000µs 📉 -20.3%) vs baseline: +0.4%

Memory: ✅ 37.139MB (SLO: <38.750MB -4.2%) vs baseline: +5.3%


✅ no-collectipvariant

Time: ✅ 39.196µs (SLO: <50.000µs 📉 -21.6%) vs baseline: ~same

Memory: ✅ 37.080MB (SLO: <38.750MB -4.3%) vs baseline: +5.4%


✅ no-useragentvariant

Time: ✅ 37.832µs (SLO: <50.000µs 📉 -24.3%) vs baseline: +0.4%

Memory: ✅ 37.080MB (SLO: <38.750MB -4.3%) vs baseline: +5.6%


✅ obfuscation-no-query

Time: ✅ 39.774µs (SLO: <50.000µs 📉 -20.5%) vs baseline: +0.7%

Memory: ✅ 37.100MB (SLO: <38.750MB -4.3%) vs baseline: +5.5%


✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.799µs (SLO: <90.000µs 📉 -15.8%) vs baseline: +0.3%

Memory: ✅ 37.513MB (SLO: <38.750MB -3.2%) vs baseline: +6.2%


✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.247µs (SLO: <90.000µs 📉 -15.3%) vs baseline: ~same

Memory: ✅ 37.493MB (SLO: <38.750MB -3.2%) vs baseline: +6.3%


✅ obfuscation-send-querystring-disabled

Time: ✅ 154.586µs (SLO: <170.000µs -9.1%) vs baseline: +0.2%

Memory: ✅ 37.552MB (SLO: <38.750MB -3.1%) vs baseline: +5.6%


✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.696µs (SLO: <160.000µs -7.1%) vs baseline: ~same

Memory: ✅ 37.415MB (SLO: <38.750MB -3.4%) vs baseline: +5.1%


✅ obfuscation-worst-case-implicit-query

Time: ✅ 155.421µs (SLO: <170.000µs -8.6%) vs baseline: +0.2%

Memory: ✅ 37.631MB (SLO: <38.750MB -2.9%) vs baseline: +6.0%


✅ useragentvariant_exists_1

Time: ✅ 38.577µs (SLO: <50.000µs 📉 -22.8%) vs baseline: +0.3%

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +5.4%


✅ useragentvariant_exists_2

Time: ✅ 39.677µs (SLO: <50.000µs 📉 -20.6%) vs baseline: -0.1%

Memory: ✅ 37.198MB (SLO: <38.750MB -4.0%) vs baseline: +5.4%


✅ useragentvariant_exists_3

Time: ✅ 39.128µs (SLO: <50.000µs 📉 -21.7%) vs baseline: +0.3%

Memory: ✅ 37.218MB (SLO: <38.750MB -4.0%) vs baseline: +5.8%


✅ useragentvariant_not_exists_1

Time: ✅ 38.622µs (SLO: <50.000µs 📉 -22.8%) vs baseline: +0.1%

Memory: ✅ 37.218MB (SLO: <38.750MB -4.0%) vs baseline: +5.5%


✅ useragentvariant_not_exists_2

Time: ✅ 38.488µs (SLO: <50.000µs 📉 -23.0%) vs baseline: ~same

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +5.5%


telemetryaddmetric - 28/28

✅ 1-count-metric-1-times

Time: ✅ 2.325µs (SLO: <20.000µs 📉 -88.4%) vs baseline: +9.2%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.5%


✅ 1-count-metrics-100-times

Time: ✅ 153.148µs (SLO: <220.000µs 📉 -30.4%) vs baseline: +0.8%


✅ 1-distribution-metric-1-times

Time: ✅ 2.412µs (SLO: <20.000µs 📉 -87.9%) vs baseline: -3.4%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.4%


✅ 1-distribution-metrics-100-times

Time: ✅ 164.777µs (SLO: <230.000µs 📉 -28.4%) vs baseline: -0.6%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.2%


✅ 1-gauge-metric-1-times

Time: ✅ 1.981µs (SLO: <20.000µs 📉 -90.1%) vs baseline: -1.3%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.3%


✅ 1-gauge-metrics-100-times

Time: ✅ 136.513µs (SLO: <150.000µs -9.0%) vs baseline: -0.5%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.2%


✅ 1-rate-metric-1-times

Time: ✅ 2.277µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +1.0%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.4%


✅ 1-rate-metrics-100-times

Time: ✅ 169.140µs (SLO: <250.000µs 📉 -32.3%) vs baseline: +1.6%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ 100-count-metrics-100-times

Time: ✅ 15.474ms (SLO: <22.000ms 📉 -29.7%) vs baseline: +0.7%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ 100-distribution-metrics-100-times

Time: ✅ 1.723ms (SLO: <2.550ms 📉 -32.4%) vs baseline: -1.1%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.4%


✅ 100-gauge-metrics-100-times

Time: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: ~same

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.2%


✅ 100-rate-metrics-100-times

Time: ✅ 1.726ms (SLO: <2.550ms 📉 -32.3%) vs baseline: +0.3%


✅ flush-1-metric

Time: ✅ 3.613µs (SLO: <20.000µs 📉 -81.9%) vs baseline: -0.9%

Memory: ✅ 36.589MB (SLO: <38.000MB -3.7%) vs baseline: +6.5%


✅ flush-100-metrics

Time: ✅ 174.543µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.9%

Memory: ✅ 36.608MB (SLO: <38.000MB -3.7%) vs baseline: +5.5%


✅ flush-1000-metrics

Time: ✅ 2.201ms (SLO: <2.500ms 📉 -12.0%) vs baseline: -0.7%

Memory: ✅ 37.021MB (SLO: <38.750MB -4.5%) vs baseline: +5.1%

ℹ️ Scenarios Missing SLO Configuration (26 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline
  • sethttpmeta-obfuscation-disabled
  • startup-baseline
  • startup-baseline_django
  • startup-baseline_flask
  • startup-ddtrace_run
  • startup-ddtrace_run_appsec
  • startup-ddtrace_run_profiling
  • startup-ddtrace_run_runtime_metrics
  • startup-ddtrace_run_send_span
  • startup-ddtrace_run_telemetry_disabled
  • startup-ddtrace_run_telemetry_enabled
  • startup-import_ddtrace
  • startup-import_ddtrace_auto
  • startup-import_ddtrace_auto_django
  • startup-import_ddtrace_auto_flask
  • startup-import_ddtrace_django
  • startup-import_ddtrace_flask

@mabdinur mabdinur force-pushed the munir/send-app-start-closed-on-root branch from 691ac6e to 4fd8cd0 Compare March 10, 2026 20:49
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codeowners resolved as

ddtrace/contrib/internal/subprocess/patch.py                            @DataDog/asm-python
ddtrace/internal/runtime/__init__.py                                    @DataDog/apm-sdk-capabilities-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-python
tests/contrib/subprocess/test_subprocess.py                             @DataDog/asm-python
tests/telemetry/test_telemetry.py                                       @DataDog/apm-python
tests/testing/internal/test_env_tags.py                                 @DataDog/ci-app-libraries
tests/tracer/runtime/test_runtime_id.py                                 @DataDog/apm-sdk-capabilities-python @DataDog/apm-core-python

@mabdinur mabdinur changed the title chore(telemetry): track process linage chore(telemetry): track process across exec Mar 11, 2026
@mabdinur mabdinur changed the title chore(telemetry): track process across exec chore(telemetry): track process across exec-based child processes Mar 11, 2026
@mabdinur mabdinur changed the title chore(telemetry): track process across exec-based child processes chore(telemetry): track process parenting across spawned processes Mar 11, 2026
@mabdinur mabdinur force-pushed the munir/send-app-start-closed-on-root branch from 4fd8cd0 to 2368fb5 Compare March 11, 2026 16:37
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 11, 2026
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
@mabdinur mabdinur changed the title chore(telemetry): track process parenting across spawned processes chore(telemetry): extend process tracking to spawned processes Mar 12, 2026
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/dd-trace-go that referenced this pull request Mar 20, 2026
## Summary

Implements the [Stable Service Instance Identifier RFC](https://docs.google.com/document/d/1ECKj9_NnwaKYtFqm3p3Rlpicx5d-OQcdj9kI2jvRqVU) for Go instrumentation telemetry.

- **`DD-Session-ID`**: always present on every telemetry request, set to the current `runtime_id`
- **`DD-Root-Session-ID`**: present only in child processes, inherited via `_DD_ROOT_GO_SESSION_ID` env var. Omitted when equal to session ID — backend infers root = self when absent
- **Auto-propagation**: `globalconfig.init()` sets `_DD_ROOT_GO_SESSION_ID` in `os.Environ()` so child processes spawned via `os/exec` inherit it automatically without any user-side calls

## Changes

- `internal/globalconfig/globalconfig.go`: adds `rootSessionID` field, `init()` reads/sets `_DD_ROOT_GO_SESSION_ID` (internal env var, not in supported_configurations), `RootSessionID()` getter
- `internal/telemetry/internal/writer.go`: adds `DD-Session-ID` (always) and `DD-Root-Session-ID` (child processes only) to pre-baked telemetry headers
- Tests for both globalconfig (including cross-process propagation) and writer

## Related

- System-tests PR: DataDog/system-tests#6510
- Node.js PR: DataDog/dd-trace-js#7821
- dd-trace-py fork tracking: DataDog/dd-trace-py#16839
- dd-trace-py spawn tracking: DataDog/dd-trace-py#16842

Co-authored-by: ayan.khan <ayan.khan@datadoghq.com>
Base automatically changed from munir/implement-stable-runtime-id to main March 25, 2026 16:52
@mabdinur mabdinur marked this pull request as ready for review March 25, 2026 16:55
@mabdinur mabdinur requested review from a team as code owners March 25, 2026 16:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b384eb7bb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/contrib/internal/subprocess/patch.py Outdated
Comment thread ddtrace/contrib/internal/subprocess/patch.py Outdated
Comment thread ddtrace/contrib/internal/subprocess/patch.py
Comment thread tests/contrib/subprocess/test_subprocess.py Outdated
Comment thread tests/contrib/subprocess/test_subprocess.py Outdated
Comment thread ddtrace/contrib/internal/subprocess/patch.py
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
@mabdinur mabdinur requested a review from juanjux March 27, 2026 16:08
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 314ac2f into main Apr 14, 2026
1097 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the munir/send-app-start-closed-on-root branch April 14, 2026 18:46
emmettbutler pushed a commit that referenced this pull request May 6, 2026
## Description                                                                                                                                                                                                      
                                         
  Extends process lineage tracking to exec-based child processes (`subprocess`, `multiprocessing` spawn). Fork support was added in a previous PR; this covers the remaining spawning mechanism.                      
                                                                                                                                                                                                                      
  `subprocess.Popen.__init__` is now patched unconditionally (independent of ASM) to inject `_DD_ROOT_PY_SESSION_ID` and `_DD_PARENT_PY_SESSION_ID` into the child's environment. The child reads these at module load
   time to seed `get_ancestor_runtime_id()` and `get_parent_runtime_id()`. Disable via `DD_TRACE_SUBPROCESS_ENABLED=false`.

  **Key changes:**
  - `runtime/__init__.py` — adds env var name constants, seeds module state from them at import, exposes `get_session_env_vars()`
  - `subprocess/patch.py` — moves `Popen.__init__`/`Popen.wait` wrapping before the ASM gate; injects lineage env vars unconditionally in `_traced_subprocess_init`
  - `telemetry/writer.py` — replaces `forksafe.is_fork_child()` with `get_parent_runtime_id() is not None`, which now correctly identifies both forked and exec-spawned children

  ## Testing

  `test_subprocess_session_lineage_env_vars` — parametrized over `DD_TRACE_SUBPROCESS_ENABLED=true/false/unset`, runs under `ddtrace-run`, spawns a `ddtrace-run` child, and verifies the child's
  `get_parent_runtime_id()` / `get_ancestor_runtime_id()` match the parent's runtime ID when enabled and are `None` when disabled.

  ## Risks

  `Popen.__init__` is now patched whenever ddtrace is loaded, not only when ASM is enabled. Spawned processes will receive two extra `_DD_`-prefixed env vars. These are ignored by non-ddtrace processes so the blast
   radius is minimal.

Co-authored-by: munir.abdinur <munir.abdinur@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants