Skip to content

refactor(asm): appsec and iast with product plugin interface#12025

Merged
gnufede merged 8 commits into
mainfrom
gnufede/asm-product-plugin-interface
Jan 24, 2025
Merged

refactor(asm): appsec and iast with product plugin interface#12025
gnufede merged 8 commits into
mainfrom
gnufede/asm-product-plugin-interface

Conversation

@gnufede

@gnufede gnufede commented Jan 22, 2025 •
edited by christophe-papazian
Loading

Copy link
Copy Markdown
Member

Migrate appsec and iast code to product plugin interface

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede changed the title refactor preload to use appsec and iast with product interface refactor(asm): appsec and iast with product plugin interface Jan 22, 2025
@github-actions

github-actions Bot commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/appsec/product.py                                      @DataDog/asm-python
ddtrace/internal/iast/product.py                                        @DataDog/asm-python
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_remoteconfiguration.py                                  @DataDog/asm-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn

datadog-dd-trace-py-rkomorn Bot commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: gnufede/asm-product-plugin-interface
Commit report: 1da244d
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 37.14s Total duration (35m 35.04s time saved)

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 22, 2025
P403n1x87
P403n1x87 reviewed Jan 22, 2025
View reviewed changes
Comment thread ddtrace/internal/appsec/product.py
@pr-commenter

pr-commenter Bot commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-23 13:46:11

Comparing candidate commit c3eccd9 in PR branch gnufede/asm-product-plugin-interface with baseline commit ff41c13 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

gnufede
gnufede commented Jan 23, 2025
View reviewed changes
Comment thread pyproject.toml Outdated
@datadog-dd-trace-py-rkomorn

datadog-dd-trace-py-rkomorn Bot commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: gnufede/asm-product-plugin-interface
Commit report: c3eccd9
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 36s Total duration (35m 37.19s time saved)

@gnufede gnufede marked this pull request as ready for review January 23, 2025 13:06
@gnufede gnufede requested review from a team as code owners January 23, 2025 13:06
@gnufede gnufede requested a review from P403n1x87 January 23, 2025 13:10
P403n1x87
P403n1x87 approved these changes Jan 23, 2025
View reviewed changes

@P403n1x87 P403n1x87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 awesome, thanks!

@gnufede gnufede enabled auto-merge (squash) January 23, 2025 17:01
@gnufede gnufede merged commit 7669493 into main Jan 24, 2025
@gnufede gnufede deleted the gnufede/asm-product-plugin-interface branch January 24, 2025 14:51
ZStriker19 pushed a commit that referenced this pull request Jan 30, 2025
@gnufede @ZStriker19
refactor(asm): appsec and iast with product plugin interface (#12025)
92daf19
github-actions Bot pushed a commit that referenced this pull request Feb 10, 2025
@gnufede @github-actions
refactor(asm): appsec and iast with product plugin interface (#12025)
15a835f 
(cherry picked from commit 7669493)
@github-actions github-actions Bot mentioned this pull request Feb 10, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@avara1986 avara1986 avara1986 approved these changes

@P403n1x87 P403n1x87 P403n1x87 approved these changes

@christophe-papazian christophe-papazian christophe-papazian approved these changes

Assignees

No one assigned

Labels

ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnufede @emmettbutler @avara1986 @P403n1x87 @christophe-papazian