Try fixing the test flakiness by using definitely not a Java fake PID#11280
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0a61374d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amarziali
left a comment
There was a problem hiding this comment.
lgtm. you might need to rerun spotless
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Changing the fake PID of 1234 to fake PID of 0
Motivation
Trying to rule out the possibility of 1234 being a valid Java process on the test CI machine, causing the temp files not to be cleared (the PID is still alive) and flaking the test.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueNote: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.