Skip to content

Consider Gradle wrapper as a wrapper for headless calculations#11266

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
daniel.mohedano/process-hierarchy-gradle-wrapper
May 5, 2026
Merged

Consider Gradle wrapper as a wrapper for headless calculations#11266
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
daniel.mohedano/process-hierarchy-gradle-wrapper

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

  • Fixes ProcessHierarchy.isGradleLauncher() to not misclassify Gradle wrapper as headless.
  • Disables code coverage gathering in the launcher tests to avoid building the repository index for tracer repo on every iteration.

Motivation

:dd-smoke-tests:gradle:test was timing out on master. Each launcher test iteration was building the repository index twice: once in the Gradle wrapper JVM and once in the spawned Gradle daemon. ProcessHierarchy misclassified the wrapper JVMs as headless due to launcher classes (org.gradle.launcher.Main/GradleMain) being missing at premain, since the wrapper loads the Gradle distribution later. Verified by enabling debug logs and seeing two Building index of source files... lines in the test output instead of one.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@daniel-mohedano daniel-mohedano requested a review from a team as a code owner May 4, 2026 12:24
@daniel-mohedano daniel-mohedano added type: bug Bug report and fix comp: ci visibility Continuous Integration Visibility labels May 4, 2026
nikita-tkachenko-datadog
nikita-tkachenko-datadog approved these changes May 4, 2026
View reviewed changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the new check to the isWrapper method. Otherwise, LGTM!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - sbt-scalatest

Job Status: success

Scenario Overhead (%)
agent 55.09
agentEvpProxy 55.08

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - netflix-zuul

Job Status: success

Scenario Overhead (%)
agent 89.08
agentless 81.36
agentlessCodeCoverage 96.44
agentlessLineCoverage 112.55

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - nebula-release-plugin

Job Status: success

Scenario Overhead (%)
agent 37.02
agentless 36.13
agentlessCodeCoverage 43.83
agentlessLineCoverage 76.29

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - pass4s

Job Status: success

Scenario Overhead (%)
agent 9.27
agentless 12.62
agentlessCodeCoverage 15.27

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - reactive-streams-jvm

Job Status: success

Scenario Overhead (%)
agent 21.28
agentless 20.50
agentlessCodeCoverage 20.30
agentlessLineCoverage 30.11

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - sonar-kotlin

Job Status: success

Scenario Overhead (%)
agent 13.63
agentless 13.45
agentlessCodeCoverage 15.95
agentlessLineCoverage 20.42

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - jolokia

Job Status: success

Scenario Overhead (%)
agent 92.75
agentless 88.44
agentlessCodeCoverage 97.86
agentlessLineCoverage 97.54

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - okhttp

Job Status: success

Scenario Overhead (%)
agent 19.82
agentless 19.65
agentlessCodeCoverage 21.36
agentlessLineCoverage 45.92

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - spring_boot

Job Status: success

Scenario Overhead (%)
agent 16.08
agentless 9.84
agentlessCodeCoverage 13.08
agentlessLineCoverage 32.70

@daniel-mohedano daniel-mohedano enabled auto-merge May 4, 2026 15:17
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 4, 2026

Copy link
Copy Markdown

Test Environment - sonar-java

Job Status: success

Scenario Overhead (%)
agent 28.45
agentless 24.22
agentlessCodeCoverage 91.65
agentlessLineCoverage 154.70

@daniel-mohedano daniel-mohedano disabled auto-merge May 5, 2026 09:08
@daniel-mohedano

daniel-mohedano commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-05 09:39:28 UTC ℹ️ Start processing command /merge

2026-05-05 09:39:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-05 09:40:07 UTC ⚠️ MergeQueue: This merge request build was cancelled

daniel.mohedano@datadoghq.com cancelled this merge request build

@daniel-mohedano

daniel-mohedano commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-05 09:39:58 UTC ℹ️ Start processing command /merge -c

@daniel-mohedano daniel-mohedano changed the title Consider gradle wrapper as gradle launcher in process hierarchy Consider Gradle wrapper as a wrapper for headless calculations May 5, 2026
@daniel-mohedano

daniel-mohedano commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-05 09:41:24 UTC ℹ️ Start processing command /merge

2026-05-05 09:41:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-05 10:53:46 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 5a1127a into master May 5, 2026
608 of 613 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the daniel.mohedano/process-hierarchy-gradle-wrapper branch May 5, 2026 10:53
@github-actions github-actions Bot added this to the 1.63.0 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility type: bug Bug report and fix

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-mohedano @nikita-tkachenko-datadog @AlexeyKuznetsov-DD