Avoid racy indefinite wait in netty ws tests (#10539)

amarziali · web-flow · commit e036f8ca99b5 · 2026-02-06T14:06:50.000Z
Avoid racy indefinite wait in netty ws tests

Co-authored-by: andrea.marziali &lt;andrea.marziali@datadoghq.com&gt;
diff --git a/dd-java-agent/instrumentation/netty/netty-4.1/src/test/groovy/Netty41ServerTest.groovy b/dd-java-agent/instrumentation/netty/netty-4.1/src/test/groovy/Netty41ServerTest.groovy
@@ -202,7 +202,8 @@ abstract class Netty41ServerTest extends HttpServerTest<EventLoopGroup> {
     void awaitConnected() {
       while (WsEndpoint.activeSession == null) {
         synchronized (WsEndpoint) {
-          WsEndpoint.wait()
+          // this can be racy so we need to wait with timeout and retry
+          WsEndpoint.wait(1_000)
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,8 @@ abstract class Netty41ServerTest extends HttpServerTest<EventLoopGroup> {`
`202`	`202`	`void awaitConnected() {`
`203`	`203`	`while (WsEndpoint.activeSession == null) {`
`204`	`204`	`synchronized (WsEndpoint) {`
`205`		`- WsEndpoint.wait()`
	`205`	`+ // this can be racy so we need to wait with timeout and retry`
	`206`	`+ WsEndpoint.wait(1_000)`
`206`	`207`	`}`
`207`	`208`	`}`
`208`	`209`	`}`