Avoid racy indefinite wait in netty ws tests#10539
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062647
Total [baseline] (10.891 s) : 0, 10890897
Agent [candidate] (1.08 s) : 0, 1080499
Total [candidate] (11.043 s) : 0, 11042946
section appsec
Agent [baseline] (1.241 s) : 0, 1240911
Total [baseline] (10.965 s) : 0, 10965033
Agent [candidate] (1.246 s) : 0, 1246037
Total [candidate] (10.893 s) : 0, 10893315
section iast
Agent [baseline] (1.231 s) : 0, 1231343
Total [baseline] (11.185 s) : 0, 11184597
Agent [candidate] (1.236 s) : 0, 1235825
Total [candidate] (11.22 s) : 0, 11219588
section profiling
Agent [baseline] (1.193 s) : 0, 1192532
Total [baseline] (10.994 s) : 0, 10993756
Agent [candidate] (1.191 s) : 0, 1191126
Total [candidate] (11.046 s) : 0, 11045810
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (627.079 ms) : 0, 627079
BytebuddyAgent [candidate] (638.084 ms) : 0, 638084
AgentMeter [baseline] (28.894 ms) : 0, 28894
AgentMeter [candidate] (29.335 ms) : 0, 29335
GlobalTracer [baseline] (256.943 ms) : 0, 256943
GlobalTracer [candidate] (261.058 ms) : 0, 261058
AppSec [baseline] (32.619 ms) : 0, 32619
AppSec [candidate] (33.479 ms) : 0, 33479
Debugger [baseline] (62.437 ms) : 0, 62437
Debugger [candidate] (64.164 ms) : 0, 64164
Remote Config [baseline] (609.453 µs) : 0, 609
Remote Config [candidate] (626.933 µs) : 0, 627
Telemetry [baseline] (11.451 ms) : 0, 11451
Telemetry [candidate] (10.088 ms) : 0, 10088
Flare Poller [baseline] (6.126 ms) : 0, 6126
Flare Poller [candidate] (6.936 ms) : 0, 6936
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (659.44 ms) : 0, 659440
BytebuddyAgent [candidate] (663.467 ms) : 0, 663467
AgentMeter [baseline] (11.963 ms) : 0, 11963
AgentMeter [candidate] (11.912 ms) : 0, 11912
GlobalTracer [baseline] (259.384 ms) : 0, 259384
GlobalTracer [candidate] (259.281 ms) : 0, 259281
AppSec [baseline] (167.763 ms) : 0, 167763
AppSec [candidate] (168.702 ms) : 0, 168702
Debugger [baseline] (67.384 ms) : 0, 67384
Debugger [candidate] (67.423 ms) : 0, 67423
Remote Config [baseline] (664.778 µs) : 0, 665
Remote Config [candidate] (653.5 µs) : 0, 653
Telemetry [baseline] (9.101 ms) : 0, 9101
Telemetry [candidate] (9.215 ms) : 0, 9215
Flare Poller [baseline] (3.672 ms) : 0, 3672
Flare Poller [candidate] (3.662 ms) : 0, 3662
IAST [baseline] (25.148 ms) : 0, 25148
IAST [candidate] (25.23 ms) : 0, 25230
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (795.566 ms) : 0, 795566
BytebuddyAgent [candidate] (798.794 ms) : 0, 798794
AgentMeter [baseline] (11.239 ms) : 0, 11239
AgentMeter [candidate] (11.287 ms) : 0, 11287
GlobalTracer [baseline] (247.881 ms) : 0, 247881
GlobalTracer [candidate] (248.869 ms) : 0, 248869
AppSec [baseline] (32.239 ms) : 0, 32239
AppSec [candidate] (32.352 ms) : 0, 32352
Debugger [baseline] (68.359 ms) : 0, 68359
Debugger [candidate] (68.3 ms) : 0, 68300
Remote Config [baseline] (540.32 µs) : 0, 540
Remote Config [candidate] (549.535 µs) : 0, 550
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.788 ms) : 0, 8788
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.445 ms) : 0, 3445
IAST [baseline] (26.893 ms) : 0, 26893
IAST [candidate] (27.073 ms) : 0, 27073
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (683.134 ms) : 0, 683134
BytebuddyAgent [candidate] (682.387 ms) : 0, 682387
AgentMeter [baseline] (9.036 ms) : 0, 9036
AgentMeter [candidate] (8.985 ms) : 0, 8985
GlobalTracer [baseline] (216.031 ms) : 0, 216031
GlobalTracer [candidate] (215.706 ms) : 0, 215706
AppSec [baseline] (32.48 ms) : 0, 32480
AppSec [candidate] (32.375 ms) : 0, 32375
Debugger [baseline] (68.021 ms) : 0, 68021
Debugger [candidate] (67.756 ms) : 0, 67756
Remote Config [baseline] (598.696 µs) : 0, 599
Remote Config [candidate] (597.143 µs) : 0, 597
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (8.902 ms) : 0, 8902
Flare Poller [baseline] (3.724 ms) : 0, 3724
Flare Poller [candidate] (3.831 ms) : 0, 3831
ProfilingAgent [baseline] (99.447 ms) : 0, 99447
ProfilingAgent [candidate] (99.479 ms) : 0, 99479
Profiling [baseline] (100.011 ms) : 0, 100011
Profiling [candidate] (100.052 ms) : 0, 100052
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075846
Total [baseline] (8.78 s) : 0, 8779520
Agent [candidate] (1.072 s) : 0, 1071701
Total [candidate] (8.762 s) : 0, 8762209
section iast
Agent [baseline] (1.229 s) : 0, 1229371
Total [baseline] (9.427 s) : 0, 9427437
Agent [candidate] (1.24 s) : 0, 1240256
Total [candidate] (9.399 s) : 0, 9399244
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (635.737 ms) : 0, 635737
BytebuddyAgent [candidate] (633.164 ms) : 0, 633164
AgentMeter [baseline] (29.2 ms) : 0, 29200
AgentMeter [candidate] (29.038 ms) : 0, 29038
GlobalTracer [baseline] (259.634 ms) : 0, 259634
GlobalTracer [candidate] (259.501 ms) : 0, 259501
AppSec [baseline] (33.415 ms) : 0, 33415
AppSec [candidate] (32.993 ms) : 0, 32993
Debugger [baseline] (61.131 ms) : 0, 61131
Debugger [candidate] (62.9 ms) : 0, 62900
Remote Config [baseline] (648.643 µs) : 0, 649
Remote Config [candidate] (625.404 µs) : 0, 625
Telemetry [baseline] (10.797 ms) : 0, 10797
Telemetry [candidate] (11.451 ms) : 0, 11451
Flare Poller [baseline] (8.557 ms) : 0, 8557
Flare Poller [candidate] (5.284 ms) : 0, 5284
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (795.301 ms) : 0, 795301
BytebuddyAgent [candidate] (802.587 ms) : 0, 802587
AgentMeter [baseline] (11.247 ms) : 0, 11247
AgentMeter [candidate] (11.583 ms) : 0, 11583
GlobalTracer [baseline] (246.803 ms) : 0, 246803
GlobalTracer [candidate] (249.696 ms) : 0, 249696
AppSec [baseline] (33.749 ms) : 0, 33749
AppSec [candidate] (33.975 ms) : 0, 33975
Debugger [baseline] (66.041 ms) : 0, 66041
Debugger [candidate] (65.77 ms) : 0, 65770
Remote Config [baseline] (549.217 µs) : 0, 549
Remote Config [candidate] (542.014 µs) : 0, 542
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.737 ms) : 0, 8737
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.54 ms) : 0, 3540
IAST [baseline] (27.001 ms) : 0, 27001
IAST [candidate] (27.2 ms) : 0, 27200
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section baseline
no_agent (1.211 ms) : 1199, 1224
. : milestone, 1211,
iast (3.089 ms) : 3045, 3133
. : milestone, 3089,
iast_FULL (5.952 ms) : 5893, 6011
. : milestone, 5952,
iast_GLOBAL (3.341 ms) : 3287, 3396
. : milestone, 3341,
profiling (2.124 ms) : 2101, 2146
. : milestone, 2124,
tracing (1.756 ms) : 1741, 1770
. : milestone, 1756,
section candidate
no_agent (1.178 ms) : 1167, 1189
. : milestone, 1178,
iast (3.21 ms) : 3166, 3255
. : milestone, 3210,
iast_FULL (5.944 ms) : 5883, 6004
. : milestone, 5944,
iast_GLOBAL (3.697 ms) : 3632, 3763
. : milestone, 3697,
profiling (1.975 ms) : 1959, 1992
. : milestone, 1975,
tracing (1.809 ms) : 1793, 1825
. : milestone, 1809,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section baseline
no_agent (17.963 ms) : 17780, 18146
. : milestone, 17963,
appsec (18.904 ms) : 18711, 19097
. : milestone, 18904,
code_origins (17.784 ms) : 17608, 17960
. : milestone, 17784,
iast (17.843 ms) : 17660, 18026
. : milestone, 17843,
profiling (18.483 ms) : 18294, 18672
. : milestone, 18483,
tracing (17.713 ms) : 17539, 17887
. : milestone, 17713,
section candidate
no_agent (16.968 ms) : 16799, 17136
. : milestone, 16968,
appsec (18.692 ms) : 18502, 18882
. : milestone, 18692,
code_origins (17.651 ms) : 17477, 17826
. : milestone, 17651,
iast (18.803 ms) : 18612, 18994
. : milestone, 18803,
profiling (18.916 ms) : 18724, 19109
. : milestone, 18916,
tracing (17.675 ms) : 17500, 17851
. : milestone, 17675,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.785 ms) : 3563, 4007
. : milestone, 3785,
iast (2.257 ms) : 2187, 2326
. : milestone, 2257,
iast_GLOBAL (2.316 ms) : 2246, 2387
. : milestone, 2316,
profiling (2.098 ms) : 2042, 2155
. : milestone, 2098,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.681 ms) : 3464, 3898
. : milestone, 3681,
iast (2.253 ms) : 2183, 2322
. : milestone, 2253,
iast_GLOBAL (2.294 ms) : 2224, 2364
. : milestone, 2294,
profiling (2.494 ms) : 2329, 2658
. : milestone, 2494,
tracing (2.057 ms) : 2004, 2111
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~17e71ce1ec6, baseline=1.60.0-SNAPSHOT~b83178b28d
dateFormat X
axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
appsec (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
iast (18.594 s) : 18594000, 18594000
. : milestone, 18594000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
. : milestone, 17870000,
profiling (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
tracing (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
section candidate
no_agent (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
appsec (15.168 s) : 15168000, 15168000
. : milestone, 15168000,
iast (18.025 s) : 18025000, 18025000
. : milestone, 18025000,
iast_GLOBAL (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
profiling (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
tracing (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
e036f8c
into
master
What Does This Do
If think that the issue with the previous implementation is that there can be a race that cause the test to wait infinitely for a connection.
In fact if the activeSession is null, the awaiting thread tries to lock and await on the monitor.
However, in the same time, the server thread might be faster in notifyingAll before the wait is called.
With the proposed fix, the while loop is retried since the wait times out after one second. So that, even if this race is not solved, it is now handled correctly.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]