[core] more improvements#3
Merged
Merged
Conversation
added 7 commits
September 15, 2016 17:33
clutchski
reviewed
Sep 15, 2016
|
|
||
| // child that is correctly configured | ||
| return newSpan(name, parent.Service, parent.Resource, spanID, parent.TraceID, parent.SpanID, parent.tracer) | ||
| return newSpan(name, parent.Service, "", spanID, parent.TraceID, parent.SpanID, parent.tracer) |
Contributor
There was a problem hiding this comment.
i think this should default to the name not empty (ti won't work if it's empty)
palazzem
commented
Sep 16, 2016
| if parent == nil { | ||
| // TODO[manu]: maybe pass a kind of DevNullTracer instead of nil | ||
| return newSpan(name, "", "", spanID, spanID, spanID, nil) | ||
| return newSpan(name, "", "", spanID, spanID, spanID, t) |
Contributor
Author
There was a problem hiding this comment.
@clutchski what about this? to be specular I should put the name in the resource argument... but for the service?
added 5 commits
September 16, 2016 11:02
palazzem
commented
Sep 16, 2016
|
|
||
| select { | ||
| case encoder = <-p.pool: | ||
| log.Println("[POOL] Reusing the encoder") |
Contributor
Author
There was a problem hiding this comment.
maybe here we're logging too much
palazzem
commented
Sep 16, 2016
| if s.Name != "" && s.Service != "" && s.Resource != "" { | ||
| s.tracer.record(s) | ||
| } | ||
| s.tracer.record(s) |
Contributor
Author
There was a problem hiding this comment.
The tracer knows if the span must be discarded or not. Moved in tracer.record
jdgordon
pushed a commit
to jdgordon/dd-trace-go
that referenced
this pull request
May 31, 2022
Fix UDP Dial for go 1.5
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.