Skip to content

[Test Optimization] ci: client caching + feature tweaks#8073

Merged
tonyredondo merged 2 commits intomasterfrom
tony/testoptimization-performance-work-pr4
Feb 3, 2026
Merged

[Test Optimization] ci: client caching + feature tweaks#8073
tonyredondo merged 2 commits intomasterfrom
tony/testoptimization-performance-work-pr4

Conversation

@tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Jan 15, 2026 •
edited
Loading

Summary of changes

  • Add cached/file Test Optimization clients and update client wrappers.
  • Reduce feature init overhead and adjust background initialization.
  • Improve runner logging and CI workspace cache usage.

Reason for change

Reduce repeated HTTP calls and improve initialization performance for CI visibility features.

Implementation details

  • New cached/file client implementations for disk/memory caching.
  • Feature creation updated to reduce dependencies on client calls.
  • CodeDuration instrumentation added to CI initialization paths.

Test coverage

CI passes then all changes are good.

Other details

@tonyredondo tonyredondo changed the title ci: client caching + feature tweaks [Test Optimization] ci: client caching + feature tweaks Jan 15, 2026
This was referenced Jan 15, 2026
Merged
Merged
Merged
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-02-03 12:19:09

Comparing candidate commit 5eec120 in PR branch tony/testoptimization-performance-work-pr4 with baseline commit 886954d in branch master.

Found 7 performance improvements and 9 performance regressions! Performance is the same for 161 metrics, 15 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-95.797ms; -95.571ms] or [-47.948%; -47.834%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+86.145ms; +86.250ms] or [+77.999%; +78.095%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 execution_time [+18.175ms; +23.685ms] or [+9.146%; +11.919%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟥 execution_time [+19.143ms; +25.514ms] or [+9.567%; +12.751%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-16.152ms; -12.003ms] or [-7.529%; -5.595%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+17.603ms; +17.744ms] or [+9.419%; +9.494%]
  • 🟩 throughput [+459.691op/s; +464.450op/s] or [+7.160%; +7.234%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+17.787ms; +18.685ms] or [+9.767%; +10.261%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-21.196ms; -17.601ms] or [-12.163%; -10.101%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 throughput [-48526.019op/s; -34831.652op/s] or [-8.472%; -6.081%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-12157.287op/s; -11316.021op/s] or [-8.048%; -7.491%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+14.675ms; +16.254ms] or [+7.367%; +8.159%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟩 execution_time [-69.097ms; -66.793ms] or [-42.123%; -40.718%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟥 execution_time [+10.274ms; +15.022ms] or [+5.102%; +7.460%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-17.056ms; -15.763ms] or [-7.842%; -7.247%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 execution_time [-21.700ms; -16.402ms] or [-10.101%; -7.635%]

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 50fc18c to 2018124 Compare January 15, 2026 22:06
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch 3 times, most recently from 11d2f07 to aeb7574 Compare January 15, 2026 22:31
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jan 15, 2026 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8073) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.27 ± (72.28 - 72.57) ms73.50 ± (73.66 - 73.99) ms+1.7%✅⬆️
.NET Framework 4.8 - Bailout
duration77.07 ± (76.89 - 77.25) ms77.29 ± (77.20 - 77.55) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1051.97 ± (1053.07 - 1059.58) ms1060.96 ± (1062.00 - 1068.38) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.58 ± (22.54 - 22.63) ms22.98 ± (22.93 - 23.03) ms+1.7%✅⬆️
process.time_to_main_ms84.97 ± (84.78 - 85.16) ms87.36 ± (87.12 - 87.60) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.94) MB10.94 ± (10.94 - 10.95) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.39 ± (22.35 - 22.43) ms22.86 ± (22.81 - 22.91) ms+2.1%✅⬆️
process.time_to_main_ms86.32 ± (86.15 - 86.50) ms89.11 ± (88.86 - 89.36) ms+3.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.97 ± (10.97 - 10.98) MB10.98 ± (10.98 - 10.99) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms253.35 ± (249.61 - 257.10) ms230.24 ± (226.73 - 233.76) ms-9.1%✅
process.time_to_main_ms495.31 ± (494.64 - 495.98) ms507.96 ± (506.97 - 508.96) ms+2.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.64 ± (48.61 - 48.66) MB48.67 ± (48.65 - 48.70) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms21.38 ± (21.35 - 21.42) ms21.78 ± (21.73 - 21.83) ms+1.9%✅⬆️
process.time_to_main_ms74.25 ± (74.04 - 74.45) ms76.52 ± (76.30 - 76.74) ms+3.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.66 ± (10.66 - 10.66) MB10.67 ± (10.67 - 10.68) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.12 ± (21.07 - 21.17) ms21.41 ± (21.37 - 21.44) ms+1.4%✅⬆️
process.time_to_main_ms74.10 ± (73.91 - 74.28) ms75.60 ± (75.41 - 75.78) ms+2.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.71 ± (10.71 - 10.72) MB10.77 ± (10.77 - 10.78) MB+0.6%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms241.02 ± (237.19 - 244.85) ms235.76 ± (231.79 - 239.72) ms-2.2%✅
process.time_to_main_ms469.95 ± (469.39 - 470.50) ms480.53 ± (479.62 - 481.45) ms+2.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.30 ± (49.28 - 49.33) MB49.27 ± (49.24 - 49.29) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.37 ± (19.34 - 19.41) ms19.79 ± (19.75 - 19.84) ms+2.2%✅⬆️
process.time_to_main_ms72.24 ± (72.08 - 72.41) ms73.97 ± (73.81 - 74.12) ms+2.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.69 - 7.70) MB7.69 ± (7.69 - 7.70) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.42 ± (19.39 - 19.46) ms19.84 ± (19.80 - 19.89) ms+2.2%✅⬆️
process.time_to_main_ms73.35 ± (73.18 - 73.51) ms75.29 ± (75.13 - 75.46) ms+2.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.76 ± (7.75 - 7.77) MB7.77 ± (7.76 - 7.78) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms183.31 ± (182.40 - 184.21) ms189.76 ± (188.96 - 190.56) ms+3.5%✅⬆️
process.time_to_main_ms448.97 ± (448.28 - 449.65) ms462.76 ± (461.84 - 463.68) ms+3.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.67 ± (36.63 - 36.71) MB36.84 ± (36.80 - 36.88) MB+0.5%✅⬆️
runtime.dotnet.threads.count27 ± (26 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration196.22 ± (196.18 - 197.09) ms197.62 ± (197.65 - 198.54) ms+0.7%✅⬆️
.NET Framework 4.8 - Bailout
duration200.76 ± (200.82 - 201.78) ms201.26 ± (201.10 - 202.04) ms+0.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1154.35 ± (1153.79 - 1160.11) ms1162.79 ± (1162.92 - 1169.86) ms+0.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms192.82 ± (192.41 - 193.23) ms191.38 ± (190.99 - 191.77) ms-0.7%✅
process.time_to_main_ms83.36 ± (83.10 - 83.62) ms83.03 ± (82.77 - 83.29) ms-0.4%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.17 ± (16.15 - 16.19) MB16.17 ± (16.15 - 16.20) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms190.66 ± (190.30 - 191.02) ms190.98 ± (190.57 - 191.40) ms+0.2%✅⬆️
process.time_to_main_ms84.18 ± (83.98 - 84.39) ms84.29 ± (84.11 - 84.47) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.20 ± (16.17 - 16.23) MB16.24 ± (16.22 - 16.27) MB+0.3%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.2%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms440.48 ± (438.03 - 442.93) ms423.94 ± (420.41 - 427.48) ms-3.8%✅
process.time_to_main_ms487.30 ± (486.67 - 487.93) ms490.96 ± (490.30 - 491.63) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.82 ± (58.72 - 58.93) MB59.26 ± (59.16 - 59.37) MB+0.7%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms196.10 ± (195.64 - 196.55) ms197.84 ± (197.41 - 198.26) ms+0.9%✅⬆️
process.time_to_main_ms71.71 ± (71.51 - 71.91) ms72.69 ± (72.51 - 72.86) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.36 ± (16.33 - 16.38) MB16.43 ± (16.41 - 16.46) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.1%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms194.32 ± (193.90 - 194.75) ms197.94 ± (197.43 - 198.45) ms+1.9%✅⬆️
process.time_to_main_ms72.57 ± (72.43 - 72.71) ms73.73 ± (73.51 - 73.95) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.38 ± (16.31 - 16.45) MB16.45 ± (16.42 - 16.47) MB+0.4%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.7%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms452.39 ± (449.22 - 455.55) ms448.14 ± (444.61 - 451.66) ms-0.9%✅
process.time_to_main_ms465.69 ± (464.96 - 466.42) ms468.15 ± (467.49 - 468.80) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.82 ± (58.68 - 58.97) MB59.00 ± (58.85 - 59.16) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms193.76 ± (193.30 - 194.22) ms194.50 ± (194.06 - 194.94) ms+0.4%✅⬆️
process.time_to_main_ms71.43 ± (71.25 - 71.62) ms71.94 ± (71.77 - 72.10) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.78 ± (11.76 - 11.79) MB11.78 ± (11.75 - 11.80) MB+0.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.0%✅
.NET 8 - Bailout
process.internal_duration_ms192.78 ± (192.33 - 193.23) ms195.29 ± (194.80 - 195.79) ms+1.3%✅⬆️
process.time_to_main_ms72.25 ± (72.09 - 72.41) ms73.82 ± (73.64 - 73.99) ms+2.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.80 - 11.85) MB11.80 ± (11.78 - 11.82) MB-0.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms371.65 ± (370.31 - 372.99) ms372.18 ± (370.61 - 373.74) ms+0.1%✅⬆️
process.time_to_main_ms448.80 ± (448.14 - 449.45) ms452.14 ± (451.54 - 452.75) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed48.40 ± (48.36 - 48.43) MB48.33 ± (48.28 - 48.39) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)29 ± (29 - 29)+1.4%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (74ms)  : 71, 76
    master - mean (72ms)  : 70, 75

    section Bailout
    This PR (8073) - mean (77ms)  : 76, 79
    master - mean (77ms)  : 75, 79

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (1,065ms)  : 1019, 1111
    master - mean (1,056ms)  : 1009, 1104
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (118ms)  : 114, 122
    master - mean (115ms)  : 110, 120

    section Bailout
    This PR (8073) - mean (119ms)  : 116, 123
    master - mean (116ms)  : 114, 118

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (780ms)  : 721, 840
    master - mean (786ms)  : 729, 843
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (105ms)  : 101, 109
    master - mean (102ms)  : 98, 106

    section Bailout
    This PR (8073) - mean (104ms)  : 100, 107
    master - mean (102ms)  : 99, 105

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (748ms)  : 675, 822
    master - mean (748ms)  : 687, 809
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (102ms)  : 99, 105
    master - mean (99ms)  : 96, 103

    section Bailout
    This PR (8073) - mean (103ms)  : 101, 105
    master - mean (101ms)  : 98, 103

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (695ms)  : 674, 716
    master - mean (675ms)  : 656, 694
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (198ms)  : 193, 203
    master - mean (197ms)  : 192, 201

    section Bailout
    This PR (8073) - mean (202ms)  : 197, 206
    master - mean (201ms)  : 196, 206

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (1,166ms)  : 1116, 1217
    master - mean (1,157ms)  : 1112, 1202
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (284ms)  : 277, 290
    master - mean (285ms)  : 279, 292

    section Bailout
    This PR (8073) - mean (284ms)  : 279, 289
    master - mean (284ms)  : 278, 289

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (954ms)  : 891, 1017
    master - mean (964ms)  : 920, 1008
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (280ms)  : 269, 291
    master - mean (277ms)  : 270, 284

    section Bailout
    This PR (8073) - mean (280ms)  : 272, 288
    master - mean (276ms)  : 270, 281

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (951ms)  : 898, 1005
    master - mean (953ms)  : 900, 1005
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8073) - mean (277ms)  : 271, 283
    master - mean (275ms)  : 268, 283

    section Bailout
    This PR (8073) - mean (280ms)  : 271, 288
    master - mean (275ms)  : 269, 281

    section CallTarget+Inlining+NGEN
    This PR (8073) - mean (859ms)  : 827, 890
    master - mean (853ms)  : 827, 878
Loading

@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from b98a4d3 to e77015c Compare January 16, 2026 11:38
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from aeb7574 to 016b2b1 Compare January 16, 2026 11:38
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from e77015c to 8fae54a Compare January 16, 2026 12:32
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from 016b2b1 to 2e0e878 Compare January 16, 2026 12:36
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 8fae54a to 33077cb Compare January 16, 2026 12:39
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch 4 times, most recently from 2ee26aa to a5a26dc Compare January 16, 2026 14:58
@tonyredondo tonyredondo marked this pull request as ready for review January 16, 2026 15:13
@tonyredondo tonyredondo requested review from a team as code owners January 16, 2026 15:13
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 07b09e0 to 566cf1c Compare January 19, 2026 09:19
@tonyredondo tonyredondo requested a review from a team as a code owner January 19, 2026 09:19
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from ab1efa1 to 61e1498 Compare January 19, 2026 09:20
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 566cf1c to 87c7fd2 Compare January 19, 2026 09:28
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from 61e1498 to 9bc0188 Compare January 19, 2026 09:28
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 87c7fd2 to 2f8135c Compare January 23, 2026 15:31
@tonyredondo tonyredondo requested review from a team as code owners January 23, 2026 15:31
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch 2 times, most recently from 8ce882a to bf4132b Compare January 23, 2026 16:12
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from eee4289 to 882dbe0 Compare January 23, 2026 17:28
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from bf4132b to 9ced60f Compare January 23, 2026 17:29
bouwkast
bouwkast approved these changes Jan 28, 2026
View reviewed changes
tracer/src/Datadog.Trace/Ci/TestOptimizationDynamicInstrumentationFeature.cs
Log.Information("TestOptimizationDynamicInstrumentationFeature: Dynamic instrumentation has been changed to {Value} by the settings api.", clientSettingsResponse.DynamicInstrumentationEnabled.Value);
settings.SetFlakyRetryEnabled(clientSettingsResponse.DynamicInstrumentationEnabled.Value);
Log.Information("TestOptimizationDynamicInstrumentationFeature: Dynamic instrumentation has been changed to {Value} by the settings api.", clientSettingsResponse.DynamicInstrumentationEnabled);
settings.SetDynamicInstrumentationEnabled(clientSettingsResponse.DynamicInstrumentationEnabled.Value);
Copy link
Collaborator

@bouwkast bouwkast Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking to make sure that this was expected to swap from SetFlakyRetryEnabled to SetDynamicInstrumentationEnabled

Based on how SetFlakyRetryEnabled is set below it looks fine just wanted to call out

tonyredondo added a commit that referenced this pull request Jan 30, 2026
@tonyredondo
[Test Optimization] perf: logging/timing helpers (#8070)
30a543a 
## Summary of changes
- Add FixedSizeArrayPool and logger overloads to reduce per-log
allocations.
- Add RefStopwatch/StopwatchHelpers/CodeDuration and apply timing to
TraceClock/TracerManagerFactory/Instrumentation and CI processors.
- Lower init logs to Debug for CI protocol writer/sender and processors.

## Reason for change
Reduce allocations and improve timing diagnostics in hot paths.

## Implementation details
- New utility helpers in `Datadog.Trace.Util` for allocation-free timing
and pooling.
- Logging changes to avoid params array allocations in common log paths.
- Timing/log-level tweaks in CI protocol writer/sender and trace
processors.

## Test coverage
CI passes then all changes are good.

## Other details
- Stacked PRs (current marked):
- **CURRENT**: PR1 #8070
  - PR2 #8071
  - PR3 #8072
  - PR4 #8073
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from 882dbe0 to 2131bb0 Compare February 2, 2026 17:08
tonyredondo added a commit that referenced this pull request Feb 3, 2026
@tonyredondo
[Test Optimization] ci: add run id + config keys (#8071)
a6ca856 
## Summary of changes
- Introduce Test Optimization RunId and EnsureRunId with cache folder
lifecycle.
- Add `_DD_INTERNAL_TOPT_RUNID` to config mapping/docs and regenerate
keys.
- Update CI integration tests to set/print RunId for deterministic runs.
- Adjust test helper thread naming for clearer CI debugging.

## Reason for change
Provide a stable RunId before caching work that depends on it and keep
configuration in sync.

## Implementation details
- Add RunId/EnsureRunId to `ITestOptimization`/`TestOptimization` with
environment propagation.
- Update configuration mapping and generated CI visibility keys.
- Update CI integration tests for RunId coverage.

## Test coverage
CI passes then all changes are good.

## Other details
- Stacked PRs (current marked):
  - PR1 #8070
- **CURRENT**: PR2 #8071
  - PR3 #8072
  - PR4 #8073
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr3 branch from b8c4942 to 9debeb5 Compare February 3, 2026 09:26
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from 9ced60f to 721c611 Compare February 3, 2026 09:33
tonyredondo added a commit that referenced this pull request Feb 3, 2026
@tonyredondo
[Test Optimization] ci: git caching + env improvements (#8072)
7c6440c 
## Summary of changes
- Add git command caching and telemetry improvements for CI visibility.
- Update GitInfo discovery and CI environment logging.
- Update impacted tests for new git discovery behavior.

JIRA: SDTEST-3226

## Reason for change
Reduce git command overhead and improve visibility into CI git metadata
collection.

## Implementation details
- Disk cache keyed by RunId in GitCommandHelper with safe.directory
handling.
- JSON annotations in ProcessHelpers for cache serialization.
- Adjusted CI runner git discovery logic and tests.

## Test coverage
CI passes then all changes are good.

## Other details
- Stacked PRs (current marked):
  - PR1 #8070
  - PR2 #8071
- **CURRENT**: PR3 #8072
  - PR4 #8073
Base automatically changed from tony/testoptimization-performance-work-pr3 to master February 3, 2026 11:33
@tonyredondo tonyredondo force-pushed the tony/testoptimization-performance-work-pr4 branch from 721c611 to 5eec120 Compare February 3, 2026 11:37
@tonyredondo tonyredondo merged commit 9ffd7d6 into master Feb 3, 2026
140 checks passed
@tonyredondo tonyredondo deleted the tony/testoptimization-performance-work-pr4 branch February 3, 2026 13:11
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:ci-visibility

Projects

None yet

Milestone

3.37.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tonyredondo @anmarchenko @bouwkast