Skip to content

Generate GH tokens with dd-octo-sts for Windows macrobenchmarks#7927

Merged
igoragoli merged 8 commits intomasterfrom
augusto/use-dd-octo-sts-on-windows-benchmarks
Dec 11, 2025
Merged

Generate GH tokens with dd-octo-sts for Windows macrobenchmarks#7927
igoragoli merged 8 commits intomasterfrom
augusto/use-dd-octo-sts-on-windows-benchmarks

Conversation

@igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Dec 9, 2025 •
edited
Loading

  • Set HARDCODED_BUILD_ID to "" before merging.

Summary of changes

  • Generate GitHub tokens with dd-octo-sts for Windows macrobenchmarks.

Less importantly:

  • Readability improvements on benchmarking CI jobs: reorganizing CI job keys, making check_azure_pipeline follow kebab-case naming from other jobs
  • Adding an option to hard-code buildId to facilitate testing benchmarking jobs.

Related changes on benchmarking-platform: https://github.com/DataDog/benchmarking-platform/pull/219

Reason for change

Using dd-octo-sts prevents rate limiting when fetching benchmarking-platform from within Windows benchmarking instances.

Implementation details

Test coverage

Macrobenchmark jobs correctly running on the CI: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/pipelines/85870816

Other details

@igoragoli Graphite App
Copy link
Contributor Author

igoragoli commented Dec 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@igoragoli igoragoli mentioned this pull request Dec 9, 2025
Merged
2 tasks
@igoragoli igoragoli force-pushed the augusto/use-dd-octo-sts-on-windows-benchmarks branch 2 times, most recently from 5a19606 to 98ad60a Compare December 10, 2025 10:50
@igoragoli igoragoli changed the title Use dd-octo-sts generated tokens on Windows macrobenchmarks Generate GitHub tokens with dd-octo-sts for Windows macrobenchmarks Dec 10, 2025
@igoragoli igoragoli changed the title Generate GitHub tokens with dd-octo-sts for Windows macrobenchmarks Generate GH tokens with dd-octo-sts for Windows macrobenchmarks Dec 10, 2025
@igoragoli igoragoli marked this pull request as ready for review December 10, 2025 11:31
@igoragoli igoragoli requested a review from a team as a code owner December 10, 2025 11:31
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Dec 10, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 10, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7927) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.25 ± (75.09 - 75.76) ms75.59 ± (75.71 - 76.42) ms+0.5%✅⬆️
.NET Framework 4.8 - Bailout
duration81.10 ± (80.71 - 81.45) ms80.02 ± (80.17 - 81.05) ms-1.3%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1077.89 ± (1076.16 - 1083.62) ms1084.73 ± (1085.87 - 1097.05) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.87 ± (22.78 - 22.96) ms22.98 ± (22.90 - 23.07) ms+0.5%✅⬆️
process.time_to_main_ms86.99 ± (86.67 - 87.31) ms88.21 ± (87.69 - 88.72) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.95 ± (10.94 - 10.95) MB+0.4%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.76 ± (22.69 - 22.83) ms22.96 ± (22.88 - 23.04) ms+0.9%✅⬆️
process.time_to_main_ms89.98 ± (89.62 - 90.34) ms90.12 ± (89.67 - 90.57) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.95) MB10.98 ± (10.98 - 10.99) MB+0.3%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms222.34 ± (220.98 - 223.70) ms227.03 ± (225.10 - 228.96) ms+2.1%✅⬆️
process.time_to_main_ms507.87 ± (506.91 - 508.82) ms513.77 ± (512.16 - 515.38) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.01 ± (47.98 - 48.03) MB48.07 ± (48.05 - 48.09) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.81 ± (21.74 - 21.87) ms21.70 ± (21.63 - 21.76) ms-0.5%✅
process.time_to_main_ms75.92 ± (75.60 - 76.24) ms75.94 ± (75.61 - 76.28) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.64) MB10.64 ± (10.64 - 10.65) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.58 ± (21.52 - 21.64) ms21.64 ± (21.58 - 21.71) ms+0.3%✅⬆️
process.time_to_main_ms76.29 ± (75.98 - 76.59) ms76.36 ± (76.02 - 76.70) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.68 ± (10.68 - 10.68) MB10.69 ± (10.69 - 10.70) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms210.14 ± (209.09 - 211.19) ms212.82 ± (211.49 - 214.15) ms+1.3%✅⬆️
process.time_to_main_ms468.20 ± (467.14 - 469.26) ms474.98 ± (473.64 - 476.31) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.54 ± (48.52 - 48.57) MB48.49 ± (48.47 - 48.51) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.84 ± (19.78 - 19.89) ms20.07 ± (20.00 - 20.14) ms+1.2%✅⬆️
process.time_to_main_ms74.63 ± (74.35 - 74.91) ms75.63 ± (75.24 - 76.02) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.68) MB7.68 ± (7.67 - 7.69) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.89 ± (19.83 - 19.96) ms19.96 ± (19.89 - 20.02) ms+0.3%✅⬆️
process.time_to_main_ms75.82 ± (75.53 - 76.12) ms76.45 ± (76.11 - 76.80) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.72 - 7.73) MB7.73 ± (7.73 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms191.52 ± (190.63 - 192.41) ms193.80 ± (192.80 - 194.80) ms+1.2%✅⬆️
process.time_to_main_ms452.07 ± (451.29 - 452.85) ms457.83 ± (456.68 - 458.99) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.53 ± (36.49 - 36.56) MB36.59 ± (36.55 - 36.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration194.47 ± (194.40 - 195.29) ms194.61 ± (194.72 - 195.59) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration198.67 ± (198.65 - 199.58) ms198.76 ± (198.47 - 199.30) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1117.87 ± (1119.64 - 1127.30) ms1128.08 ± (1130.95 - 1140.03) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms189.82 ± (189.37 - 190.28) ms191.55 ± (191.05 - 192.06) ms+0.9%✅⬆️
process.time_to_main_ms81.69 ± (81.44 - 81.94) ms82.17 ± (81.91 - 82.43) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.06 ± (16.03 - 16.09) MB16.04 ± (16.01 - 16.06) MB-0.1%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.8%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms188.90 ± (188.46 - 189.34) ms189.55 ± (189.14 - 189.96) ms+0.3%✅⬆️
process.time_to_main_ms82.64 ± (82.44 - 82.85) ms82.75 ± (82.56 - 82.93) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.05 ± (16.02 - 16.07) MB16.18 ± (16.14 - 16.21) MB+0.8%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.5%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.72 ± (397.99 - 403.45) ms400.74 ± (398.24 - 403.25) ms+0.0%✅⬆️
process.time_to_main_ms479.46 ± (478.71 - 480.21) ms480.73 ± (479.85 - 481.62) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.58 ± (58.45 - 58.72) MB58.93 ± (58.83 - 59.03) MB+0.6%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms193.83 ± (193.42 - 194.23) ms196.42 ± (195.93 - 196.92) ms+1.3%✅⬆️
process.time_to_main_ms70.55 ± (70.34 - 70.75) ms71.03 ± (70.82 - 71.24) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.33 ± (16.29 - 16.37) MB16.32 ± (16.30 - 16.34) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.6%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms193.21 ± (192.81 - 193.61) ms194.27 ± (193.79 - 194.75) ms+0.5%✅⬆️
process.time_to_main_ms71.44 ± (71.29 - 71.60) ms71.85 ± (71.64 - 72.06) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.29 ± (16.18 - 16.40) MB16.41 ± (16.38 - 16.43) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.6%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms413.15 ± (410.66 - 415.63) ms411.69 ± (409.66 - 413.72) ms-0.4%✅
process.time_to_main_ms448.29 ± (447.65 - 448.93) ms451.52 ± (450.76 - 452.28) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.10 ± (58.96 - 59.23) MB59.14 ± (59.01 - 59.27) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (29 - 30)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms192.76 ± (192.32 - 193.20) ms194.12 ± (193.68 - 194.56) ms+0.7%✅⬆️
process.time_to_main_ms70.54 ± (70.36 - 70.73) ms70.28 ± (70.09 - 70.47) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.74) MB11.67 ± (11.65 - 11.69) MB-0.4%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%✅
.NET 8 - Bailout
process.internal_duration_ms191.79 ± (191.40 - 192.18) ms192.24 ± (191.79 - 192.68) ms+0.2%✅⬆️
process.time_to_main_ms71.10 ± (70.92 - 71.28) ms71.05 ± (70.89 - 71.21) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.80 ± (11.78 - 11.83) MB11.74 ± (11.72 - 11.76) MB-0.5%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.3%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms369.64 ± (368.29 - 370.98) ms370.74 ± (369.22 - 372.26) ms+0.3%✅⬆️
process.time_to_main_ms432.89 ± (432.17 - 433.62) ms435.44 ± (434.64 - 436.25) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.92 ± (47.89 - 47.95) MB47.98 ± (47.96 - 48.01) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (76ms)  : 71, 81
    master - mean (75ms)  : 70, 80

    section Bailout
    This PR (7927) - mean (81ms)  : 74, 87
    master - mean (81ms)  : 75, 87

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (1,091ms)  : 1007, 1176
    master - mean (1,080ms)  : 1027, 1133
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (119ms)  : 110, 128
    master - mean (117ms)  : 112, 123

    section Bailout
    This PR (7927) - mean (121ms)  : 113, 128
    master - mean (120ms)  : 113, 127

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (788ms)  : 725, 850
    master - mean (770ms)  : 735, 805
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (105ms)  : 97, 113
    master - mean (105ms)  : 99, 110

    section Bailout
    This PR (7927) - mean (105ms)  : 98, 112
    master - mean (105ms)  : 99, 110

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (718ms)  : 683, 753
    master - mean (707ms)  : 680, 733
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (104ms)  : 97, 112
    master - mean (103ms)  : 96, 109

    section Bailout
    This PR (7927) - mean (105ms)  : 98, 112
    master - mean (104ms)  : 98, 110

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (690ms)  : 650, 730
    master - mean (679ms)  : 645, 713
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (195ms)  : 191, 199
    master - mean (195ms)  : 190, 200

    section Bailout
    This PR (7927) - mean (199ms)  : 195, 203
    master - mean (199ms)  : 195, 204

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (1,135ms)  : 1070, 1201
    master - mean (1,123ms)  : 1069, 1178
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (283ms)  : 276, 289
    master - mean (280ms)  : 272, 287

    section Bailout
    This PR (7927) - mean (281ms)  : 274, 287
    master - mean (280ms)  : 273, 286

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (918ms)  : 866, 969
    master - mean (921ms)  : 871, 971
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (276ms)  : 266, 286
    master - mean (273ms)  : 264, 282

    section Bailout
    This PR (7927) - mean (275ms)  : 268, 281
    master - mean (273ms)  : 267, 279

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (897ms)  : 859, 936
    master - mean (897ms)  : 848, 946
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7927) - mean (274ms)  : 266, 281
    master - mean (273ms)  : 265, 281

    section Bailout
    This PR (7927) - mean (273ms)  : 265, 281
    master - mean (272ms)  : 268, 277

    section CallTarget+Inlining+NGEN
    This PR (7927) - mean (838ms)  : 808, 868
    master - mean (834ms)  : 809, 859
Loading

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7927 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 56.5ns 329ns 0 0 0 5.49 KB
master StartStopWithChild netcoreapp3.1 13.8μs 72.4ns 362ns 0 0 0 5.71 KB
master StartStopWithChild net472 22μs 117ns 583ns 0.989 0.439 0.11 5.94 KB
#7927 StartStopWithChild net6.0 11.2μs 53.7ns 208ns 0 0 0 5.52 KB
#7927 StartStopWithChild netcoreapp3.1 14μs 24.4ns 91.2ns 0 0 0 5.7 KB
#7927 StartStopWithChild net472 22.4μs 126ns 828ns 0.985 0.328 0.109 5.95 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.26 KB 3.29 KB 27 B 0.83%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 1.26ms 133ns 496ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.35ms 205ns 796ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.7ms 171ns 664ns 0 0 0 3.26 KB
#7927 WriteAndFlushEnrichedTraces net6.0 1.25ms 101ns 377ns 0 0 0 2.7 KB
#7927 WriteAndFlushEnrichedTraces netcoreapp3.1 1.38ms 120ns 449ns 0 0 0 2.7 KB
#7927 WriteAndFlushEnrichedTraces net472 1.84ms 2.35μs 9.1μs 0 0 0 3.29 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.13μs 5.85ns 26.8ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.38μs 7.36ns 41.6ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.04μs 2.32ns 8.98ns 0.193 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.52μs 31.8ns 123ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 8.92μs 43.9ns 196ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.68μs 7.29ns 28.2ns 0.731 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 332ns 1.69ns 6.99ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 400ns 1.98ns 8.15ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.0169ns 0.0611ns 0.044 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.49μs 32.6ns 138ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.73μs 38.8ns 165ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.7μs 2.48ns 9.6ns 0.57 0 0 3.8 KB
#7927 AllCycleSimpleBody net6.0 1.07μs 5.88ns 35.8ns 0 0 0 1.22 KB
#7927 AllCycleSimpleBody netcoreapp3.1 1.41μs 6.98ns 29.6ns 0 0 0 1.2 KB
#7927 AllCycleSimpleBody net472 1.01μs 1.25ns 4.84ns 0.191 0 0 1.23 KB
#7927 AllCycleMoreComplexBody net6.0 7.39μs 34.4ns 133ns 0 0 0 4.72 KB
#7927 AllCycleMoreComplexBody netcoreapp3.1 8.83μs 43.9ns 191ns 0 0 0 4.62 KB
#7927 AllCycleMoreComplexBody net472 7.74μs 3.96ns 15.3ns 0.736 0 0 4.74 KB
#7927 ObjectExtractorSimpleBody net6.0 330ns 1.78ns 9.91ns 0 0 0 280 B
#7927 ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.11ns 10.3ns 0 0 0 272 B
#7927 ObjectExtractorSimpleBody net472 303ns 0.00526ns 0.0182ns 0.0443 0 0 281 B
#7927 ObjectExtractorMoreComplexBody net6.0 6.54μs 2.33ns 9.02ns 0 0 0 3.78 KB
#7927 ObjectExtractorMoreComplexBody netcoreapp3.1 7.92μs 38.4ns 163ns 0 0 0 3.69 KB
#7927 ObjectExtractorMoreComplexBody net472 6.68μs 1.25ns 4.68ns 0.603 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.4μs 296ns 1.15μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.6μs 54.8ns 212ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 18.8ns 70.4ns 4.92 0 0 32.5 KB
master EncodeLegacyArgs net6.0 151μs 135ns 521ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 202μs 48.5ns 188ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 32.8ns 123ns 0 0 0 2.14 KB
#7927 EncodeArgs net6.0 76.3μs 151ns 563ns 0 0 0 32.4 KB
#7927 EncodeArgs netcoreapp3.1 98μs 46.3ns 179ns 0 0 0 32.4 KB
#7927 EncodeArgs net472 108μs 18.9ns 73.2ns 4.89 0 0 32.5 KB
#7927 EncodeLegacyArgs net6.0 143μs 15ns 54.2ns 0 0 0 2.14 KB
#7927 EncodeLegacyArgs netcoreapp3.1 198μs 154ns 595ns 0 0 0 2.14 KB
#7927 EncodeLegacyArgs net472 264μs 17.8ns 68.9ns 0 0 0 2.14 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 435μs 611ns 2.2μs 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 467μs 4.1μs 40μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 489μs 324ns 1.17μs 0 0 0 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 328μs 2.39μs 23.7μs 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 339μs 2.55μs 24.7μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 363μs 304ns 1.1μs 0 0 0 0 b
#7927 RunWafRealisticBenchmark net6.0 419μs 853ns 3.41μs 0 0 0 4.55 KB
#7927 RunWafRealisticBenchmark netcoreapp3.1 444μs 2.58μs 23.5μs 0 0 0 4.48 KB
#7927 RunWafRealisticBenchmark net472 490μs 543ns 2.1μs 0 0 0 0 b
#7927 RunWafRealisticBenchmarkWithAttack net6.0 312μs 850ns 3.06μs 0 0 0 2.24 KB
#7927 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 334μs 1.8μs 10μs 0 0 0 2.22 KB
#7927 RunWafRealisticBenchmarkWithAttack net472 361μs 457ns 1.65μs 0 0 0 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 More allocations ⚠️

More allocations ⚠️ in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 21.18 KB 21.34 KB 157 B 0.74%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 85.5μs 146ns 525ns 0 0 0 18.97 KB
master SendRequest netcoreapp3.1 97μs 343ns 2.66μs 0 0 0 21.18 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#7927 SendRequest net6.0 85μs 329ns 1.47μs 0 0 0 18.98 KB
#7927 SendRequest netcoreapp3.1 96.7μs 332ns 1.45μs 0 0 0 21.34 KB
#7927 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 1.52μs 5.69μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 3.92ms 1.17μs 4.21μs 0 0 0 640.05 KB
master OriginalCharSlice net472 2.72ms 495ns 1.85μs 0 0 0 638.98 KB
master OptimizedCharSlice net6.0 1.39ms 407ns 1.41μs 0 0 0 0 b
master OptimizedCharSlice netcoreapp3.1 2.73ms 1.64μs 6.37μs 0 0 0 0 b
master OptimizedCharSlice net472 1.98ms 486ns 1.82μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 1.05ms 268ns 966ns 0 0 0 0 b
master OptimizedCharSliceWithPool netcoreapp3.1 1.86ms 2μs 7.74μs 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.14ms 559ns 2.09μs 0 0 0 0 b
#7927 OriginalCharSlice net6.0 1.99ms 992ns 3.84μs 0 0 0 640 KB
#7927 OriginalCharSlice netcoreapp3.1 4ms 2.6μs 10.1μs 0 0 0 640.05 KB
#7927 OriginalCharSlice net472 2.66ms 952ns 3.56μs 0 0 0 638.98 KB
#7927 OptimizedCharSlice net6.0 1.38ms 233ns 871ns 0 0 0 0 b
#7927 OptimizedCharSlice netcoreapp3.1 2.76ms 1.52μs 5.68μs 0 0 0 0 b
#7927 OptimizedCharSlice net472 2.02ms 1.31μs 5.07μs 0 0 0 0 b
#7927 OptimizedCharSliceWithPool net6.0 1.04ms 2.26μs 8.15μs 0 0 0 0 b
#7927 OptimizedCharSliceWithPool netcoreapp3.1 1.87ms 1.38μs 5.36μs 0 0 0 0 b
#7927 OptimizedCharSliceWithPool net472 1.17ms 904ns 3.5μs 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.15 KB 56.76 KB 617 B 1.10%

Fewer allocations 🎉 in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.32 KB 41.83 KB -488 B -1.15%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 649μs 562ns 2.03μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 3.93μs 32.2μs 0 0 0 42.32 KB
master WriteAndFlushEnrichedTraces net472 945μs 4.72μs 21.6μs 4.81 0 0 56.15 KB
#7927 WriteAndFlushEnrichedTraces net6.0 626μs 2.14μs 9.82μs 0 0 0 41.74 KB
#7927 WriteAndFlushEnrichedTraces netcoreapp3.1 772μs 3.69μs 15.2μs 0 0 0 41.83 KB
#7927 WriteAndFlushEnrichedTraces net472 886μs 3.13μs 12.1μs 8.33 4.17 0 56.76 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.83μs 8.71ns 32.6ns 0 0 0 968 B
master ExecuteNonQuery netcoreapp3.1 2.52μs 4.78ns 16.6ns 0 0 0 960 B
master ExecuteNonQuery net472 2.77μs 2.5ns 9.67ns 0.138 0 0 931 B
#7927 ExecuteNonQuery net6.0 1.84μs 5.5ns 20.6ns 0 0 0 968 B
#7927 ExecuteNonQuery netcoreapp3.1 2.59μs 9.19ns 35.6ns 0 0 0 960 B
#7927 ExecuteNonQuery net472 2.74μs 4.73ns 18.3ns 0.137 0 0 931 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.67μs 8.45ns 36.9ns 0 0 0 952 B
master CallElasticsearch netcoreapp3.1 2.29μs 8.22ns 31.8ns 0 0 0 968 B
master CallElasticsearch net472 3.55μs 6.37ns 24.7ns 0.141 0 0 955 B
master CallElasticsearchAsync net6.0 1.75μs 3ns 11.6ns 0 0 0 928 B
master CallElasticsearchAsync netcoreapp3.1 2.42μs 6.83ns 26.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync net472 3.36μs 2.95ns 11.4ns 0.152 0 0 1.01 KB
#7927 CallElasticsearch net6.0 1.65μs 3.76ns 14.6ns 0 0 0 952 B
#7927 CallElasticsearch netcoreapp3.1 2.18μs 7.58ns 29.3ns 0 0 0 968 B
#7927 CallElasticsearch net472 3.55μs 3.91ns 14.6ns 0.138 0 0 955 B
#7927 CallElasticsearchAsync net6.0 1.69μs 1.72ns 6.67ns 0 0 0 928 B
#7927 CallElasticsearchAsync netcoreapp3.1 2.36μs 2.05ns 7.93ns 0 0 0 1.02 KB
#7927 CallElasticsearchAsync net472 3.49μs 2.93ns 11.4ns 0.157 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.77μs 8.36ns 33.4ns 0 0 0 896 B
master ExecuteAsync netcoreapp3.1 2.4μs 8.55ns 33.1ns 0 0 0 896 B
master ExecuteAsync net472 2.56μs 1.72ns 6.65ns 0.128 0 0 858 B
#7927 ExecuteAsync net6.0 1.87μs 9.59ns 45ns 0 0 0 896 B
#7927 ExecuteAsync netcoreapp3.1 2.37μs 8.32ns 31.1ns 0 0 0 896 B
#7927 ExecuteAsync net472 2.64μs 2.09ns 7.83ns 0.131 0 0 858 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.77μs 12.3ns 45.9ns 0 0 0 2.29 KB
master SendAsync netcoreapp3.1 8.44μs 14.9ns 57.6ns 0 0 0 2.83 KB
master SendAsync net472 12μs 7.22ns 27.9ns 0.48 0 0 3.08 KB
#7927 SendAsync net6.0 6.69μs 8.09ns 30.3ns 0 0 0 2.29 KB
#7927 SendAsync netcoreapp3.1 8.63μs 13.4ns 50.3ns 0 0 0 2.83 KB
#7927 SendAsync net472 12.2μs 9.57ns 37.1ns 0.487 0 0 3.08 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 272.13 KB 274.08 KB 1.95 KB 0.72%

Fewer allocations 🎉 in #7927

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.04 KB 259.11 KB -14.93 KB -5.45%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.4μs 243ns 1.33μs 0 0 0 42.51 KB
master StringConcatBenchmark netcoreapp3.1 49.7μs 276ns 2.46μs 0 0 0 42.54 KB
master StringConcatBenchmark net472 57μs 267ns 1μs 0 0 0 49.15 KB
master StringConcatAspectBenchmark net6.0 457μs 1.98μs 7.9μs 0 0 0 272.13 KB
master StringConcatAspectBenchmark netcoreapp3.1 458μs 7.03μs 70μs 0 0 0 274.04 KB
master StringConcatAspectBenchmark net472 401μs 2.06μs 9.88μs 0 0 0 270.34 KB
#7927 StringConcatBenchmark net6.0 41.7μs 111ns 383ns 0 0 0 42.51 KB
#7927 StringConcatBenchmark netcoreapp3.1 48μs 264ns 1.65μs 0 0 0 42.54 KB
#7927 StringConcatBenchmark net472 56μs 245ns 947ns 0 0 0 49.15 KB
#7927 StringConcatAspectBenchmark net6.0 494μs 2.27μs 8.78μs 0 0 0 274.08 KB
#7927 StringConcatAspectBenchmark netcoreapp3.1 446μs 5.47μs 52.2μs 0 0 0 259.11 KB
#7927 StringConcatAspectBenchmark net472 398μs 2.08μs 10.2μs 0 0 0 270.34 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 13.7ns 72.6ns 0 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 3.57μs 18.2ns 83.2ns 0 0 0 1.7 KB
master EnrichedLog net472 3.82μs 3.48ns 13.5ns 0.247 0 0 1.6 KB
#7927 EnrichedLog net6.0 2.65μs 0.687ns 2.57ns 0 0 0 1.69 KB
#7927 EnrichedLog netcoreapp3.1 3.55μs 8.85ns 34.3ns 0 0 0 1.7 KB
#7927 EnrichedLog net472 3.88μs 4.2ns 16.3ns 0.251 0 0 1.6 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 47.4ns 177ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 183ns 635ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 22ns 79.3ns 0 0 0 4.51 KB
#7927 EnrichedLog net6.0 123μs 25.2ns 97.6ns 0 0 0 4.31 KB
#7927 EnrichedLog netcoreapp3.1 127μs 63.4ns 229ns 0 0 0 4.31 KB
#7927 EnrichedLog net472 166μs 33.1ns 128ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 11.4ns 42.7ns 0 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 6.89μs 9.59ns 37.1ns 0 0 0 2.26 KB
master EnrichedLog net472 7.54μs 6.67ns 25.8ns 0.3 0 0 2.05 KB
#7927 EnrichedLog net6.0 5.07μs 5.69ns 21.3ns 0 0 0 2.24 KB
#7927 EnrichedLog netcoreapp3.1 6.88μs 18.8ns 73ns 0 0 0 2.26 KB
#7927 EnrichedLog net472 7.63μs 11.2ns 43.4ns 0.306 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.98μs 9.51ns 39.2ns 0 0 0 1.12 KB
master SendReceive netcoreapp3.1 2.55μs 11.8ns 45.6ns 0 0 0 1.14 KB
master SendReceive net472 2.95μs 0.793ns 2.75ns 0.163 0 0 1.12 KB
#7927 SendReceive net6.0 1.99μs 4.2ns 16.3ns 0 0 0 1.12 KB
#7927 SendReceive netcoreapp3.1 2.6μs 1.17ns 4.39ns 0 0 0 1.14 KB
#7927 SendReceive net472 3.14μs 2.55ns 9.87ns 0.174 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.38μs 3.98ns 14.4ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.69μs 16.1ns 62.5ns 0 0 0 1.63 KB
master EnrichedLog net472 6.75μs 7.35ns 28.5ns 0.301 0 0 2.03 KB
#7927 EnrichedLog net6.0 4.43μs 6.22ns 22.4ns 0 0 0 1.58 KB
#7927 EnrichedLog netcoreapp3.1 5.76μs 21.1ns 81.6ns 0 0 0 1.63 KB
#7927 EnrichedLog net472 6.68μs 9.66ns 37.4ns 0.3 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 777ns 0.207ns 0.776ns 0 0 0 520 B
master StartFinishSpan netcoreapp3.1 950ns 4.51ns 18ns 0 0 0 520 B
master StartFinishSpan net472 886ns 0.186ns 0.695ns 0.0799 0 0 522 B
master StartFinishScope net6.0 903ns 0.52ns 2.01ns 0 0 0 640 B
master StartFinishScope netcoreapp3.1 1.12μs 5.32ns 20.6ns 0 0 0 640 B
master StartFinishScope net472 1.09μs 2.15ns 8.31ns 0.0934 0 0 602 B
master StartFinishTwoScopes net6.0 1.75μs 8.47ns 34.9ns 0 0 0 1.19 KB
master StartFinishTwoScopes netcoreapp3.1 2.19μs 0.92ns 3.44ns 0 0 0 1.19 KB
master StartFinishTwoScopes net472 2.11μs 1.18ns 4.59ns 0.169 0 0 1.08 KB
#7927 StartFinishSpan net6.0 748ns 3.61ns 15.3ns 0 0 0 520 B
#7927 StartFinishSpan netcoreapp3.1 955ns 4.8ns 22.5ns 0 0 0 520 B
#7927 StartFinishSpan net472 886ns 0.167ns 0.646ns 0.0799 0 0 522 B
#7927 StartFinishScope net6.0 933ns 1.3ns 4.85ns 0 0 0 640 B
#7927 StartFinishScope netcoreapp3.1 1.15μs 5.83ns 27.3ns 0 0 0 640 B
#7927 StartFinishScope net472 1.08μs 0.145ns 0.561ns 0.0918 0 0 602 B
#7927 StartFinishTwoScopes net6.0 1.82μs 1.08ns 4.17ns 0 0 0 1.19 KB
#7927 StartFinishTwoScopes netcoreapp3.1 2.15μs 9.05ns 35ns 0 0 0 1.19 KB
#7927 StartFinishTwoScopes net472 2.16μs 5.15ns 20ns 0.161 0 0 1.08 KB
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 4.13ns 16ns 0 0 0 640 B
master RunOnMethodBegin netcoreapp3.1 1.33μs 5.08ns 19.7ns 0 0 0 640 B
master RunOnMethodBegin net472 1.42μs 0.32ns 1.2ns 0.0923 0 0 602 B
#7927 RunOnMethodBegin net6.0 1.07μs 1.32ns 5.11ns 0 0 0 640 B
#7927 RunOnMethodBegin netcoreapp3.1 1.35μs 6.23ns 24.1ns 0 0 0 640 B
#7927 RunOnMethodBegin net472 1.46μs 3.02ns 11.7ns 0.0949 0 0 602 B

NachoEchevarria
NachoEchevarria approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoragoli igoragoli force-pushed the augusto/use-dd-octo-sts-on-windows-benchmarks branch from 44c5c90 to a3ff9fa Compare December 11, 2025 09:26
@igoragoli
Simplify Windows macrobenchmarks AMI build (#7928)
01d898b 
- [x] Revert [point to testing
branch](7a65ba3)
- [x] Make sure `HARDCODED_BUILD_ID` is set to `""` before merging.

## Summary of changes

- Remove unnecessary `.setup` hidden job and its references
- Reorganize CI job keys for readability across build and benchmarking
jobs.
- Rename AMI build job and stage to better match what's already on
`microbenchmarks.yml`.

## Reason for change

Improve readability on dd-trace-dotnet's macrobenchmark AMI build jobs.

## Implementation details

## Test coverage

AMI build job correctly running:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/1283243374

## Other details
<!-- Fixes #{issue} -->


<!--  ⚠️ Note:

Where possible, please obtain 2 approvals prior to merging. Unless
CODEOWNERS specifies otherwise, for external teams it is typically best
to have one review from a team member, and one review from apm-dotnet.
Trivial changes do not require 2 reviews.

MergeQueue is NOT enabled in this repository. If you have write access
to the repo, the PR has 1-2 approvals (see above), and all of the
required checks have passed, you can use the Squash and Merge button to
merge the PR. If you don't have write access, or you need help, reach
out in the #apm-dotnet channel in Slack.
-->
@igoragoli igoragoli merged commit a6063d8 into master Dec 11, 2025
108 of 113 checks passed
@igoragoli igoragoli deleted the augusto/use-dd-octo-sts-on-windows-benchmarks branch December 11, 2025 15:40
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 11, 2025
@bouwkast bouwkast added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

@andrewlock andrewlock Awaiting requested review from andrewlock

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@igoragoli @NachoEchevarria @bouwkast